From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <echaudro@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 23D931AF03
 for <dev@dpdk.org>; Fri, 29 Sep 2017 09:59:18 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 33732883A0;
 Fri, 29 Sep 2017 07:59:18 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 33732883A0
Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com;
 dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com;
 spf=fail smtp.mailfrom=echaudro@redhat.com
Received: from rhvm.imac (ovpn-116-180.ams2.redhat.com [10.36.116.180])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 3567F1815F;
 Fri, 29 Sep 2017 07:59:17 +0000 (UTC)
To: Olivier MATZ <olivier.matz@6wind.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org, jingjing.wu@intel.com
References: <22990026376b08418cb0eb6f028840c03e89f47f.1505221429.git.echaudro@redhat.com>
 <4147502.SWF1kaKTU5@xps> <2ff0680b-b73f-fd1f-9f41-caa38a13bcde@redhat.com>
 <20170919072818.zbhjsfhpbqf4fqxz@neon>
 <cb7d4d53-eb83-2a06-ad36-52626ad893fe@redhat.com>
 <20170925075319.agzytjfgai7usngs@platinum>
From: Eelco Chaudron <echaudro@redhat.com>
Organization: Red Hat
Message-ID: <eeec1767-b0f6-0aad-92be-85b136181113@redhat.com>
Date: Fri, 29 Sep 2017 09:59:38 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170925075319.agzytjfgai7usngs@platinum>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.26]); Fri, 29 Sep 2017 07:59:18 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: echaudro@redhat.com
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Sep 2017 07:59:19 -0000

On 25/09/17 09:53, Olivier MATZ wrote:
>> [SNIP]
>> I did not at add a log, as the rte log subsystem is not yet initialized.
>> However we could add a printf("WARNING: mlockall() failed with error %s")
>> like message. What do you think?
> Since it's not critical, maybe NOTICE is better than WARNING.
>
> One more question: what would be the drawback of calling
> mlockall() after eal_init()? (rte_log would be initialized)
>
Calling mlockall() after eal_init() does seem to have the same effect.
I'll send out a v2 patch later today with a rte_log(NOTICE).