From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E87EB43BCF; Thu, 7 Mar 2024 15:20:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE3FF4067E; Thu, 7 Mar 2024 15:20:18 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 63CCC40272 for ; Thu, 7 Mar 2024 15:20:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709821217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FBFRNMFnHfE/STSIdxGfiSuABuJ4uAsQ1OQiAVv7g1c=; b=FCEFZf6Heoy0AYkEfX7Fvrk97mvkSdD1LzLfgYZs6iHlI3tVbJ7oZsshmhS6RMYAaA7nme ZLruv3pbnd+yT9eNSfSAEZBiVp3T5eUEjZMBJ6klHBxE9p8qsHIGLdminnS0pT9dspi2mo 7lwcABnshTeawq90H+MwFl4k78TLzFQ= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-383-xQaudD2DNu-B8CBByi9o4w-1; Thu, 07 Mar 2024 09:20:15 -0500 X-MC-Unique: xQaudD2DNu-B8CBByi9o4w-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5133f0f1b9bso702894e87.2 for ; Thu, 07 Mar 2024 06:20:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709821214; x=1710426014; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FBFRNMFnHfE/STSIdxGfiSuABuJ4uAsQ1OQiAVv7g1c=; b=riLCrYf3tXImrHDai6gPgjJsyuHfzlIvHI4V7PsyM5pusuO2wqaPZ6WXZDTTPkxtr9 oNPZP9mys8MnNR25pzxO6XZXH9JN6ilvKezMq21EHVxsR52O5c3AeIJ12P5tSSZLRJ87 C9fyJp7K6oJcDzTIC7EFFC/hy00Zf4fEyfOPBPBnA2YMTI/ylLDvZC7KKF7ASZKVAfkt JbSswI0APQsll5vKQm2jM+j+XMaw86XHi3g67Qy67sYUbSnZLQry+Tug13qHoZkplbaC WTLfKfaBxwSHtXJTV7KZppMC3SAwpRTLqWWtQDDNG1sP8Bgq3/HgO1y0sBhQVuuwaHsW Mhvg== X-Forwarded-Encrypted: i=1; AJvYcCU6UWgaO7gShulTYQfXivCflEHHKy3PXZjD5tkh0sp42mz0LUvqHESk/uH/CIk6CMLD6g47HjcjHrqr1wQ= X-Gm-Message-State: AOJu0Yx83I3OzhHCZ4mpV5ydOTd4ZnB5zb2vQ1bs4VAgXoLikratfoum +IcP0wP18gReJaTGFEQzmhJn4RjnlRBVUNz9mGwKRUQXZvoSypZ6SkOFxjaqqn53oT92BOm7e4r V2Sj7JStV+ZX1BkqvPrmfIlk549UPZ0+++UOq/Y2vrnZOZ9vJ X-Received: by 2002:a05:6512:3a92:b0:513:4a02:1fe6 with SMTP id q18-20020a0565123a9200b005134a021fe6mr1956221lfu.64.1709821214045; Thu, 07 Mar 2024 06:20:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IEwetyozJI7bu5pdKsOsgUwSgP1UgEhZ4V+2j/+4qa0LlteFKWiPvb6D5Fgrv6XX7cUpD2WXg== X-Received: by 2002:a05:6512:3a92:b0:513:4a02:1fe6 with SMTP id q18-20020a0565123a9200b005134a021fe6mr1956205lfu.64.1709821213679; Thu, 07 Mar 2024 06:20:13 -0800 (PST) Received: from [192.168.0.36] ([78.17.251.53]) by smtp.gmail.com with ESMTPSA id h12-20020a05600c350c00b0041312d21a35sm1184587wmq.7.2024.03.07.06.20.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Mar 2024 06:20:13 -0800 (PST) Message-ID: Date: Thu, 7 Mar 2024 14:20:12 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] vhost: fix virtqueue access lock check for handlers To: David Marchand , dev@dpdk.org Cc: Maxime Coquelin , Chenbo Xia References: <20240307103624.610080-1-david.marchand@redhat.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: <20240307103624.610080-1-david.marchand@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 07/03/2024 10:36, David Marchand wrote: > As the vhost library may receive a request for an unsupported request, > it is necessary to check msg_handler before checking if locking queue > pairs is requested. > > Coverity issue: 415049 > Fixes: 5e8fcc60b59d ("vhost: enhance virtqueue access lock asserts") > > Signed-off-by: David Marchand > --- > lib/vhost/vhost_user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c > index 7fe1687f08..414192500e 100644 > --- a/lib/vhost/vhost_user.c > +++ b/lib/vhost/vhost_user.c > @@ -3171,7 +3171,7 @@ vhost_user_msg_handler(int vid, int fd) > * inactive, so it is safe. Otherwise taking the access_lock > * would cause a dead lock. > */ > - if (msg_handler->lock_all_qps) { > + if (msg_handler != NULL && msg_handler->lock_all_qps) { > if (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED)) { > vhost_user_lock_all_queue_pairs(dev); > unlock_required = 1; Acked-by: Kevin Traynor