Re: [dpdk-dev] [PATCH v4 0/2] fix pcap handlers for secondary

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 11/16/2018 2:54 PM, Ferruh Yigit wrote:
> On 11/15/2018 1:37 AM, Qi Zhang wrote:
>> Private vdev was the way previously, when pdump developed, now with
>> shared device mode on virtual devices, pcap data path in secondary is
>> not working.
>>
>> When secondary adds a virtual device, related data transferred to
>> primary and primary creates the device and shares device back with
>> secondary. When pcap device created in primary, pcap handlers (pointers)
>> are process local and they are not valid for secondary process. This
>> breaks secondary.
>>
>> So we can't directly share the pcap handlers, but need to create a new
>> set of handlers for secondary, that's what we done in this patch.
>>
>> Also so we use `rte_eth_dev->process_private` to store pcap handlers
>> separately for each process, so a handler in one process will not be
>> closed or overwritten by another process unexpectedly.
>>
>> v4:
>> - rx_burst/tx_burst should use the local pcap handler directly.
>> - add missing devargs memcpy for sharing to secondary process.
>>
>> v3:
>> - fix hardcoded queue number.
>> - use process_private.
>>
>> v2:
>> - fix init issue when try to dump to an iface.
>>
>> Qi Zhang (2):
>>   net/pcap: move pcap handler to process private
>>   net/pcap: enable data path for secondary
> 
> For series,
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 

Series applied to dpdk-next-net/master, thanks.