DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tomasz Kulasek <tomaszx.kulasek@intel.com>, yliu@fridaylinux.org
Cc: dev@dpdk.org, huawei.xie@intel.com, stable@dpdk.org,
	Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: fix close callfd on get vring base
Date: Fri, 2 Mar 2018 12:05:29 +0100	[thread overview]
Message-ID: <ef16ea71-b119-75a1-0d00-df2b6e91c126@redhat.com> (raw)
In-Reply-To: <75099b6d-b9ac-7edb-fd31-2bc4410390b4@redhat.com>

Hi Tomasz,

On 02/20/2018 10:09 AM, Maxime Coquelin wrote:
> 
> 
> On 02/09/2018 06:10 PM, Tomasz Kulasek wrote:
>> This prevents from destroying & recreating user device in "incomplete"
>> vring state. virtio_is_ready() was returning true for devices with
>> vrings which did not have valid callfd (their VHOST_USER_SET_VRING_CALL
>> hasn't arrived yet)
>>
>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
>> Cc:huawei.xie@intel.com
>> Cc:stable@dpdk.org
>>
>> Signed-off-by: Dariusz Stojaczyk<dariuszx.stojaczyk@intel.com>
>> Signed-off-by: Tomasz Kulasek<tomaszx.kulasek@intel.com>
>> ---
>>   lib/librte_vhost/vhost_user.c | 5 +++++
>>   1 file changed, 5 insertions(+)
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> and applied to dpdk-next-virtio/master.

I reworded the title:
vhost: cleanup device properly at stop time

Let me know if this is fine to you

Thanks,
Maxime

> Thanks,
> Maxime

      reply	other threads:[~2018-03-02 11:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09 17:10 Tomasz Kulasek
2018-02-20  9:09 ` Maxime Coquelin
2018-03-02 11:05   ` Maxime Coquelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef16ea71-b119-75a1-0d00-df2b6e91c126@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dariuszx.stojaczyk@intel.com \
    --cc=dev@dpdk.org \
    --cc=huawei.xie@intel.com \
    --cc=stable@dpdk.org \
    --cc=tomaszx.kulasek@intel.com \
    --cc=yliu@fridaylinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).