* [dpdk-dev] [PATCH] vhost: fix close callfd on get vring base
@ 2018-02-09 17:10 Tomasz Kulasek
2018-02-20 9:09 ` Maxime Coquelin
0 siblings, 1 reply; 3+ messages in thread
From: Tomasz Kulasek @ 2018-02-09 17:10 UTC (permalink / raw)
To: yliu; +Cc: dev, huawei.xie, stable, Dariusz Stojaczyk
This prevents from destroying & recreating user device in "incomplete"
vring state. virtio_is_ready() was returning true for devices with
vrings which did not have valid callfd (their VHOST_USER_SET_VRING_CALL
hasn't arrived yet)
Fixes: 8f972312b8f4 ("vhost: support vhost-user")
Cc: huawei.xie@intel.com
Cc: stable@dpdk.org
Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
---
lib/librte_vhost/vhost_user.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index 65ee33919..dd8682c09 100644
--- a/lib/librte_vhost/vhost_user.c
+++ b/lib/librte_vhost/vhost_user.c
@@ -897,6 +897,11 @@ vhost_user_get_vring_base(struct virtio_net *dev,
vq->kickfd = VIRTIO_UNINITIALIZED_EVENTFD;
+ if (vq->callfd >= 0)
+ close(vq->callfd);
+
+ vq->callfd = VIRTIO_UNINITIALIZED_EVENTFD;
+
if (dev->dequeue_zero_copy)
free_zmbufs(vq);
rte_free(vq->shadow_used_ring);
--
2.14.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] vhost: fix close callfd on get vring base
2018-02-09 17:10 [dpdk-dev] [PATCH] vhost: fix close callfd on get vring base Tomasz Kulasek
@ 2018-02-20 9:09 ` Maxime Coquelin
2018-03-02 11:05 ` Maxime Coquelin
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Coquelin @ 2018-02-20 9:09 UTC (permalink / raw)
To: Tomasz Kulasek, yliu; +Cc: dev, huawei.xie, stable, Dariusz Stojaczyk
On 02/09/2018 06:10 PM, Tomasz Kulasek wrote:
> This prevents from destroying & recreating user device in "incomplete"
> vring state. virtio_is_ready() was returning true for devices with
> vrings which did not have valid callfd (their VHOST_USER_SET_VRING_CALL
> hasn't arrived yet)
>
> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
> Cc:huawei.xie@intel.com
> Cc:stable@dpdk.org
>
> Signed-off-by: Dariusz Stojaczyk<dariuszx.stojaczyk@intel.com>
> Signed-off-by: Tomasz Kulasek<tomaszx.kulasek@intel.com>
> ---
> lib/librte_vhost/vhost_user.c | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
and applied to dpdk-next-virtio/master.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] vhost: fix close callfd on get vring base
2018-02-20 9:09 ` Maxime Coquelin
@ 2018-03-02 11:05 ` Maxime Coquelin
0 siblings, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2018-03-02 11:05 UTC (permalink / raw)
To: Tomasz Kulasek, yliu; +Cc: dev, huawei.xie, stable, Dariusz Stojaczyk
Hi Tomasz,
On 02/20/2018 10:09 AM, Maxime Coquelin wrote:
>
>
> On 02/09/2018 06:10 PM, Tomasz Kulasek wrote:
>> This prevents from destroying & recreating user device in "incomplete"
>> vring state. virtio_is_ready() was returning true for devices with
>> vrings which did not have valid callfd (their VHOST_USER_SET_VRING_CALL
>> hasn't arrived yet)
>>
>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
>> Cc:huawei.xie@intel.com
>> Cc:stable@dpdk.org
>>
>> Signed-off-by: Dariusz Stojaczyk<dariuszx.stojaczyk@intel.com>
>> Signed-off-by: Tomasz Kulasek<tomaszx.kulasek@intel.com>
>> ---
>> lib/librte_vhost/vhost_user.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> and applied to dpdk-next-virtio/master.
I reworded the title:
vhost: cleanup device properly at stop time
Let me know if this is fine to you
Thanks,
Maxime
> Thanks,
> Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-02 11:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-09 17:10 [dpdk-dev] [PATCH] vhost: fix close callfd on get vring base Tomasz Kulasek
2018-02-20 9:09 ` Maxime Coquelin
2018-03-02 11:05 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).