From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0067.outbound.protection.outlook.com [104.47.41.67]) by dpdk.org (Postfix) with ESMTP id 2734910E1B for ; Fri, 23 Dec 2016 12:07:31 +0100 (CET) Received: from BN6PR03CA0059.namprd03.prod.outlook.com (10.173.137.21) by BY2PR0301MB0744.namprd03.prod.outlook.com (10.160.63.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Fri, 23 Dec 2016 11:07:30 +0000 Received: from BY2FFO11OLC013.protection.gbl (2a01:111:f400:7c0c::189) by BN6PR03CA0059.outlook.office365.com (2603:10b6:404:4c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.803.11 via Frontend Transport; Fri, 23 Dec 2016 11:07:29 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; infradead.org; dkim=none (message not signed) header.d=none;infradead.org; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11OLC013.mail.protection.outlook.com (10.1.15.25) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.789.10 via Frontend Transport; Fri, 23 Dec 2016 11:07:27 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id uBNB7Ngv023737; Fri, 23 Dec 2016 04:07:24 -0700 To: Jan Blunck References: <1482332986-7599-1-git-send-email-jblunck@infradead.org> <1482332986-7599-22-git-send-email-jblunck@infradead.org> <20161221120953.0282b531@xeon-e3> CC: Stephen Hemminger , , David Marchand From: Shreyansh Jain Message-ID: Date: Fri, 23 Dec 2016 16:41:01 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131269648487026850; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(979002)(6009001)(7916002)(336005)(39840400002)(39380400002)(39860400002)(39400400002)(39410400002)(39850400002)(39450400003)(2980300002)(1109001)(1110001)(339900001)(377454003)(189002)(24454002)(199003)(8676002)(50466002)(64126003)(68736007)(77096006)(38730400001)(106466001)(105606002)(36756003)(81156014)(97736004)(189998001)(4001350100001)(8936002)(356003)(47776003)(65956001)(65806001)(83506001)(85426001)(230700001)(4326007)(31696002)(33646002)(626004)(93886004)(6666003)(104016004)(6916009)(2950100002)(2906002)(76176999)(54356999)(65826007)(50986999)(92566002)(5660300001)(31686004)(81166006)(305945005)(229853002)(69596002)(23676002)(86362001)(110136003)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB0744; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC013; 1:Nwc0z3/u8v5F+Z7P1wUr2c16pX7nKq4oqt+ZSXlOyvL6oA7oLYABq07gVO/EpuvoSI6waeBrpzCFzQNVwaZllYcLn89mDxNtSfQpG7h9FGJ1837TjXskc2DdTDW43/aIw6+WVz0dD6QbBAeiM+qlILMGzXVE2vxLaj9xyvYpmsxEocZEeh9os+Tmk5KXLQ4tZXax+ybVl05kOkO7lNUKS+QWrtpp9mmOUz9r/VeO9AL29RSGSEF2IdeJL4Sw3RB1r6gCYO9G3Tema0GuL5Sb7qQhsnNEZAMnhjG8T5xHUrihyGz0xqbvqHvMhTODaNMsAeN4Icqcep//UmnhKQNU6p3chVgC/4Efk6s7Hdjlpiv7fjY9/xfiEzmUUO8eQqT42e6uNOx0d7K98CW7fkOYiZ9xLbqXJe559oZ3lJyAS0GL2cmZbwh0HiId0TCQ1viy7xLvb1b7Ei8bPOGzmofq+B1wy5aYVC2D+i6dIGpqy/jP52am75wQmckDCuD+xp+p7Bk5AGOIGLbkb8C0WOhmCW9GxXQFPTFSiDh3hgFOaMIev2w9zXxbDyJPQeH6DcBX/3duERP1okjHDzRnd2OKSyBLOgVUFvCFk++onnHqIPM= X-MS-Office365-Filtering-Correlation-Id: 65c38791-e387-4120-af45-08d42b23e250 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY2PR0301MB0744; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0744; 3:GVF4gmYUwWQCxbn6y0plCX230O92MyzcE4T6jeEEkn+pdN2Oel8aSag/kHdzbU8tdP2xBUAKIFtfJtL08yQ2wWMoWAeX8zEYHyF1yHmlAfB4A913r+K7FmWxTbZHxszWjWkxinb8niY/XqdebREK7n1F7Yk1Chl7FPkUOyejQI5vH/w0x6JaGZXn6/5B80GvmIX+MGrwgckV5c2gr4QNd8vdcSgjZ9L//opza8rvFWxvhPCcAY6kv4J8cERIBEei/2uA+aJrVl08LavUUnmptUNBcEmt5qiRkirUEt0iExO4WdJPHcYeJZFpuUs2jUckpB7Ae3ixQ/TrT9rxgxM6txZ9Wqt/SYb6FzhdTvl/iKKCYvyE83zwCRFNZfn7pjku X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0744; 25:q78d18EGO9FAFqlzbx/QeiFgnBQS16auy9HfAPsqgeF9DCJvIx6uMz7hHqBgvJbiOde/0TrpsEQMx9yGNHtWISVH8LNJKlSDXQf+qJ6KZHvqkv5MT6TVuuG76cNJjmdHyw3s/+34FTYoHGlvOnMU6Npsxc6ZsmEMHxLGrkDCBTlJlFjiDu61Cqxn90jOYSQzNcqYD1JGwbH2oJcwYlN5ES+dlMuG9CQXKGdaOm7NnCXP3l5orJfyII+wb5OzBtQZfeGMStzHHWjFOirS635qnlnOXqVWMvMcidGvYD+G5Tq4hguZRtbbiwtSmeUDiQzxuxc4Jgqw/W3vttvj91TZyzGfAiPFAb5snxyJYrabKHdh2cxNrDez6nfLaol/FU6ZO+ljNDvMnEM0XVSlct4w6twzM9O0YORBA/3V0pFFvOyCLEhjoVjmzZWUjo5tZu/L0G/l73Lwsjd4Cb/FMxE6SjN8hheBMM2mfVBhLJCJo1sZPOx2GZPA7/udlPqnYXLxV4j+jEvbHd7OR1hyF/SyBzxvKaMy2sSU3jDLq1QSTkonoyBku2W9SQvB1mQy3IdA3IQjZ2uFAZx104iMM2pY8HEoVi64roSphkk6ujmrLWCahM59PZQnYfc1jY6pmcZrEJxksIHm63Skjv2f8yhRr7i/PsUnQrB5AvMoIZf6P9PYVVHikAegoOWEeQF0DKe9gwyMSI/gqucgXjnWGEgGoJS1Q6PqmQPZTRjhEOsn1QjrwG//7rNnOI8r9VkS/u0kGfrLrcT68lrspVc8TjWzLA== X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0744; 31:tuYDIbcygV5C/T/mrDB5b/35pxh99wf6VM7OQEwu2NshM1rRLO0PAg8MxdK7Z9Hjz+m5IZUH+0aY5ImgHjZVKmqe19WnGsBXhgnAER31Nwv7hP9E90pYQnLY3/PB/23QwTPe0MVDg7Wk2GpRskHAY8YcDabg9TGUPcLiZT0lMnE257BPLKrgDavlHl2ipydRrUE7N/LivoqoaCmg/3pXPhHAehjPtF5JZKV6RjMqtsWgsxgWDnARYWI55ClcPXuhUB88rl4flfFobNUtP2oCDA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13017025)(13015025)(13018025)(13023025)(13024025)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(20161123563025)(20161123559025)(20161123556025)(20161123561025); SRVR:BY2PR0301MB0744; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR0301MB0744; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0744; 4:yAtBeYC5CgleU9au7KhQgamZIWyg2LW1WKRyPYauc2y5ITuJbYB9bhLxOHqYUaPxgfpd5t2GyveGSzx1TFz1lQFjPKsdPVFaIQ3qTXleZs8qn8Hw2exZuZkx1m5GE4/Vm0LMFT548we+i7hwaNLEsGlxEzxumDomJwx0UFgWGDt/Tbkb4TGdO+8HTQFjiN0FaAv5MqOSYhCiGXKc/QmdasvY5XJy8RunTZ4uc5w+veWJcrsGH7+L+80bL/lbclGhexkHgT0R9gCbCrbgXiVI35YXj45vNHfVuNBEEgWrFisdymLViuQb1TeuUN/DbTaEEg8AEv9Q9pmPrPxxo6HYTkPip0E8/XJRzizcQXmMMaOUhK8irDtBfCuW7tSsPm4ORaC+ndBVgszv/oa2BYUfEdXaS92SzygpfRhc5TOY7aDQjPNE7xD5G5lx5wwF58hr2zYRKyKGjJpmBicJU/doK4QShTe19yhDuv/xSgnPUuA67jafg/6DsSFKhxe5Xb2BlsuckADTZ5JDNH9ZGcm4j6igRaj0SvAJSq9OVjXpZcsgozlVQI54MhY2tG5j7xHxI4BO2spviYATrmJOzQvFYp4sA+UtKvh92AsUS5kTcS5Utpy/DAeHb0o7EzgWeLDQlEp+KcTGHwjTg+qIZX9hNltkM0KSrj5VEyRGaNr4TF4sL8DhXGYkpCsNI6gjYSvk+B3h46/SkhxWW0e3QVF0b6hJXM2xntEtJS/gm3KB/NaYozlx7RLAghpUFxz79lcn X-Forefront-PRVS: 016572D96D X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjAzMDFNQjA3NDQ7MjM6N0dwL00yNlRLSEhCZENwS3E3RnJJODJ1?= =?utf-8?B?ZDBCN0M4WVJQT3ZaM010TlNPTiswZDJsS0hSMGFCZjhQU2NTNndFY3NGTkdU?= =?utf-8?B?SDQxV1hNZXFVemJOSjlqai91SnVqZ1JoQXRMUER0bmhOREF0K1BWNFd5b0ly?= =?utf-8?B?RzdMMUtBUkw2dXVnWVo1UlhyQ0dGL2tXbWJrZjhZYk5ZWjFHRVI5MG52QVN6?= =?utf-8?B?MXR5OEcrTWhudk5EMnFBZEZ0Q3Q0bEk4NS9YM0REdlRmd1FVUmZ2eFI4Q3pQ?= =?utf-8?B?eGFRTWVXeFpPWWx3eXBraXNXNFlQblozTFRzOTF0VGtxRDgzMkNRczhObUV4?= =?utf-8?B?SmNuNFRDbHljMDdLRElWNElRUDZYNzdNMHV3N0ZHYkRFTnl0b0ttczg1NkVR?= =?utf-8?B?UWZkWGYrVkdheEpneWZwemNNUjAyeSt6bWlPZFViR0V2K2VBWWpQek5NdUd4?= =?utf-8?B?L05FOVhtWlk4S2lMcXBIanl1NWZISzI0cWVkL2IrVEJNVEpKZU9yUTcrdnBF?= =?utf-8?B?ZHZhYUluUXBWS1MxcHNNcUhmRENuUkt4cTByV1Y4ZVBjMW9HdHVmODllMitH?= =?utf-8?B?WkRlWEJOOFBIcVFYdWxhbi84cmR3eXhETmNVMXB1Z3hXRGxVS01qQWdUTlVZ?= =?utf-8?B?RkgwTFZmUFc2bXNycVhETVJQcnFpSDdRVUg5WG44MkU5K3hreVdlWEw1eFgv?= =?utf-8?B?Y3JlRXJDSG9saVNpZ01RcTFRMHF5SU5ZNjByL3lCNFpjaHNVcVRDVHpWbkdQ?= =?utf-8?B?R21DcWNiSTFWVlFabXg1bHQ3TjQvRzllQXFVVGxLa0M1alVyRzQ2Wmdqd3RD?= =?utf-8?B?UjIrakl2Z2Rnd0plZEtVUGtuSHV4WjhTUEZkNFYwRjZOZnZKTWxlaW9xNTRV?= =?utf-8?B?eWNTeHdFRkJNZFppZGphMG53RU43MDFkQjdJemRIMlZEeThEdDVsWjJTbFhu?= =?utf-8?B?alhVaVFib3RROUdDSFh1dVA1T0VmWHFNY3JkZTNRTy91NG50Z0VONXU3VXAr?= =?utf-8?B?VU9hNzdHdmdncVZka21lakxMZzdCZy8yNGt0cXFyTXByZUVmOWcwNEpGTjNH?= =?utf-8?B?Y3lySEVVWjNXeVA3end3U3hMYUNYc215MG0xZkRMZWg0WldmM2hRVUh4Y2R2?= =?utf-8?B?UlN6VkRubUZBVWxwRDAxQjArQzZlTE9PM0wycUNRYW1sOTFYK1ZFUVROa2hJ?= =?utf-8?B?b2I1MWNYTS9YSEhINkY2Y2tXY0Ywd0kwZ3l5TWQrblRUelVJMFNFd2VieHdx?= =?utf-8?B?MWJqa1NEWjcrNURnZ1BlMTRqT1g1bnY3TGxGMTNDREo5QzAzN3BNT0Y4RXh3?= =?utf-8?B?T2FQOWNKbEgvaUl5aVdLVGNQNTRKNmNkQWNEdlRiVXQxb2l4QTUraGdUazVu?= =?utf-8?B?blE4VmJGTmZqVjd6Q2xLeWxKR3E3Mnc5YUtpQmZoT0N2bFNoQ2wyWWJ0MnpT?= =?utf-8?B?RFYxYUJvMGZwOWZHMGFySGdnRmJlQzVtcTQ3RDlFeUdjR0MrelV4WldhYlZY?= =?utf-8?B?NmJUYjcrUmFIQ2pyMlIwYmg1Z2NWNGR0ejZ6V09ZR2QvQXhNQWZmVlN1Tklv?= =?utf-8?B?R3QraW95SEFKeTVUa3RpeWxaZWpsRWlJNUw5M09DOGQ4Wk42UGh0ZUVLYk02?= =?utf-8?B?Z1h3K0pyK1NzUm5QTWIxYnBZRWMzck5oWm1uSDdwZFA4YjRGeEt2aXBsWncy?= =?utf-8?B?NFo1Y2JmbGhRd2lxa3RHK2xlZHZ3V3RNQ2RrNzRuZUd6MXVLRi9LT1ptbUF6?= =?utf-8?B?R3Nsb0pUbFVkMk41VWQwMklkTHFVdHVEMlBPNnJ3N1RaaU55M2p3ZkhkbVNJ?= =?utf-8?B?Q1ZuZlFtaThMRlBBZ2JBZm5HRkxSLzJSYlozbytYaks4YkFyV1kwZFVQVkc3?= =?utf-8?B?RFN5Q0llQ0VWd2VjR2pMNTA3d1p1MndpdnZkQ3JaZVU0TjZnb3cwbzFnejdn?= =?utf-8?B?ZlZnMnhTbU1ubVV4SGxrVC9xMWlDYjNaYldxcnNVbWZiMW4yQ1lRQVhoOHdM?= =?utf-8?B?Q2o5Z0dwVWNaSGZKZkF6Ni9yWlJObUR3alRwalVmK01oTlZJN21IQUh3UE9F?= =?utf-8?B?UWtjT29kYW1TYW5DYXlEOEVqY2V0YXkxOHhvQjNOdCtjZWdnNDF3R0R0MnM2?= =?utf-8?B?MnlmOXhkV1duMjhFZ2tZR1lPM1JQMUlOWDU2VzFSNXhWb0hsWmFzTXRMRXpu?= =?utf-8?B?Y09sbm9oRzNoKy9HbjBsWWRBczhQS1E9PQ==?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0744; 6:jC6YSDaBUz706AAuH/wTCwwRghlQvf/0ucLKbrl3dBp76HAoSNK/g8F9dsAODtWG/zGD3Vm1EuGHv2rGkRXr3JsG4uRof7vHgs9ewaqhwqeayP9KH98oWLRfqAB2BdWpEpYrUZRkLMlYvi8dVFRN/L0OyhTd9uNK0o8FTtUQrNePmH72gJljgTLYO/oAHV5D1nS/7QRmE95pHNX4jOgsgmaNJpTqVH6Efb+jjKsCBYBHLi6/ECpbeR51qvBYKWtTe7oQy73+EXpWgcaEzhgrOO5hdt2XGEWEZY3hWZAsDZWAR5QdrID/SBmXYEbg43ZnStPZ5q6AYh7QxeAFmOQCQP6Qt/85xNS9/H9KqBi5goVdi4A6oHNmF6Hk0oF9uRKBxURUlvQStVNgSgsqYq+KznTGF43jp/EsNpjOYVX+a6/p7kGJ62VIElcHwCZO3VvM; 5:X79jHsPNKTAXJEC/tKKWwl6ujbReA18uyBvF9/91e5QQ/YgNYvGHKeb7onRyMaRIIYf8uU79oN57Mcay/opjJakhmrzYv47CGara5gMkka3iUbqzw7m3rlUe2iIOn0evl45KCgKTEb1iPw+Zsk5VA1EB0jD4NqK0/xT14Cy2hFlNGLYqZCtvyySYT4lr2e3C; 24:R53FK+HFvlbFMjl8oY32/Mqb8zbuaz5XllSuRDW88pYUJuG1LgJvkzfM7Ct2HWrfEW88u9W3rEgFZvmkVeo8nqPkAe2uMvOP0jJprE6N6LY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0744; 7:RdlDYRptF9LrsIh4z6gq7Sd/JYZwIZtWXXH3u9DmXmdpn5jfJal3OhIcNUvsZhrU+9eVlT16FpC9W5TpQu/mvdNFWnvv+ncaKerwiGnf/8hDcVp7Ukgnn/d48BXoz2t7fNC+Er+dSk7iJ8B2UApqLxVRXq3dizDP75NG1UVSMjFO3Ws5l4RbmsHJ8G032cupq077Q7NlEC1XO5qlPh2xPK0enOMBKwYMA/25T2kjzzdjzlkjFDQ2zvo+06397YgjB/yAULkFxTo3+ZMFHbai+L1nE6+AHU+Df0i21myEP1r6qSL5p2jrbIda1tfl9iJODS9N7voWCIG9uMLFqcuwvMNm8Zw7PwrL1TtcD2XKejcMhttBwihB8dvLteAYfZRc4IkhsSPsnJ5tnJnrYe1D+UjKv3beVT1fmRWuyDunUMvvIRBkOqx0P1qjwRsy+eBtKIIcW6PzB1SPA2Y98GFAmQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2016 11:07:27.1895 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0744 Subject: Re: [dpdk-dev] [PATCH v4 21/23] ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2016 11:07:31 -0000 On Friday 23 December 2016 04:20 PM, Jan Blunck wrote: > On Thu, Dec 22, 2016 at 9:11 AM, Shreyansh Jain wrote: >> On Thursday 22 December 2016 01:39 AM, Stephen Hemminger wrote: >>> >>> On Wed, 21 Dec 2016 16:09:44 +0100 >>> Jan Blunck wrote: >>> >>>> Only the device itself can decide its PCI or not. >>>> >>>> Signed-off-by: Jan Blunck >>>> Acked-by: Shreyansh Jain >>>> --- >>> >>> >>> I would still like to kill dev_pci from the dev_info API. >>> > > I'm fine with that too. > >> >> +1. It should be rte_dev reference instead. >> > > Only if you can give use-cases for what users should be able to do > with it. If that is the case we need to clearly define what that > means. Do we want to enable users to control the low-level EAL device > directly and shortcut the ethdev driver? If that is necessary we need > to give control to the driver first to decide if it is safe to do so. > An ethernet device is not necessarily a PCI device. With planned removal of rte_pci_device from rte_eth_device, this will be realized. Similarly, the info is also not PCI device specific. With the '+1', my intention was not to say we should do it in this patch. We should prepare eth_dev_info in similar manner as done for pci_dev of rte_eth_dev (ETH_DEV_PCI_DEV() style macro, or inline). And now for whether we should expose lower level device details or not, I was of the view that keeping pci_dev linked to this structure exposes more lower level info than keeping rte_dev. Another view point could be to completely do away with pci_info within eth_dev_info - but, I am not sure of dependencies on it. - Shreyansh