From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id E13B37CE7; Thu, 13 Sep 2018 15:06:16 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3481236883; Thu, 13 Sep 2018 13:06:16 +0000 (UTC) Received: from [10.36.112.13] (unknown [10.36.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1724E2010CAA; Thu, 13 Sep 2018 13:06:13 +0000 (UTC) To: Anatoly Burakov , dev@dpdk.org Cc: tiwei.bie@intel.com, ray.kinsella@intel.com, zhihong.wang@intel.com, kuralamudhan.ramakrishnan@intel.com, stable@dpdk.org References: From: Maxime Coquelin Message-ID: Date: Thu, 13 Sep 2018 15:06:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 13 Sep 2018 13:06:16 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3 2/9] eal: don't allow legacy mode with in-memory mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Sep 2018 13:06:17 -0000 On 09/04/2018 05:15 PM, Anatoly Burakov wrote: > In-memory mode was never meant to support legacy mode, because we > cannot sort anonymous pages anyway. > > Fixes: 72b49ff623c4 ("mem: support --in-memory mode") > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov > --- > lib/librte_eal/common/eal_common_options.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c > index dd5f97402..873099acc 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -1390,6 +1390,12 @@ eal_check_common_options(struct internal_config *internal_cfg) > "--"OPT_HUGE_UNLINK"\n"); > return -1; > } > + if (internal_cfg->legacy_mem && > + internal_cfg->in_memory) { > + RTE_LOG(ERR, EAL, "Option --"OPT_LEGACY_MEM" is not compatible " > + "with --"OPT_IN_MEMORY"\n"); This is a general comment, as it is consistent with the style of the file. I generally prefer not splitting error strings into multiple lines even if it is longer than 80 chars, because it makes grepping for the error string more difficult. > + return -1; > + } > > return 0; > } > Other than that: Reviewed-by: Maxime Coquelin Thanks, Maxime