From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CD67A00C5; Thu, 4 Jun 2020 12:51:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8D2311D5D1; Thu, 4 Jun 2020 12:51:50 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 3B9401D421 for ; Thu, 4 Jun 2020 12:51:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591267907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RDCDnJibUX9EYbTzUk+Fb2057u6GwmpEF+a6et/Tv88=; b=IHX96ANBVIeDf+TONYVAgJqNueqc97HbOr2Kw7pKVH84cS1QG3nnoK1fQ8Iu4XIZuCw9mF J1W+BkipqttetU6iLfBzQFKBpx9CaoVVgKa862izBU/XDsr5jObEWzyqa0DYWl5G5Ro+ry TN04SaJ3/5D9z6T6Bzhrhgd91/YXOvY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-348-vxW3uX7hN0u-Qel5odBG4w-1; Thu, 04 Jun 2020 06:51:45 -0400 X-MC-Unique: vxW3uX7hN0u-Qel5odBG4w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C7600107ACF3; Thu, 4 Jun 2020 10:51:44 +0000 (UTC) Received: from [10.33.36.130] (unknown [10.33.36.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id 56FEE7CCC8; Thu, 4 Jun 2020 10:51:43 +0000 (UTC) To: Phil Yang , "Wei Hu (Xavier)" , "dev@dpdk.org" Cc: nd References: <1591251737-64598-1-git-send-email-xavier.huwei@huawei.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: Date: Thu, 4 Jun 2020 11:51:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix passing negative parameter to strerror X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04/06/2020 09:45, Phil Yang wrote: >> -----Original Message----- >> From: dev On Behalf Of Wei Hu (Xavier) >> Sent: Thursday, June 4, 2020 2:22 PM >> To: dev@dpdk.org >> Cc: xavier.huwei@huawei.com >> Subject: [dpdk-dev] [PATCH] app/testpmd: fix passing negative parameter to >> strerror >> >> Currently, there are coverity defect warnings as blow: >> Coverity issue: >> In nic_stats_clear function: >> CID 290021 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS) >> 5. negative_returns: ret is passed to a parameter that cannot be >> negative. >> >> CID 289974 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS) >> 6. negative_returns: ret is passed to a parameter that cannot be >> negative. >> >> In nic_xstats_clear function: >> CID 289985 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS) >> 5. negative_returns: ret is passed to a parameter that cannot be >> negative. >> >> CID 289850 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS) >> 6. negative_returns: ret is passed to a parameter that cannot be >> negative. >> >> This patch fixes them by passing '-ret' to the function strerror() when ret >> is negative. >> >> Fixes: af75078fece3 ("first public release") > > It was the commit da328f7f115a ("ethdev: change xstats reset function to return int") introduced this defect in nic_xstats_clear() function. > Not the "first public release" commit. :) > > The patch looks good to me. > +1 > Thanks, > Phil > >> Fixes: 9eb974221f44 ("app/testpmd: fix statistics after reset") >> Cc: stable@dpdk.org >> >> Signed-off-by: Wei Hu (Xavier) >> --- >> app/test-pmd/config.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c >> index 5381207..356d0d2 100644 >> --- a/app/test-pmd/config.c >> +++ b/app/test-pmd/config.c >> @@ -244,14 +244,14 @@ nic_stats_clear(portid_t port_id) >> ret = rte_eth_stats_reset(port_id); >> if (ret != 0) { >> printf("%s: Error: failed to reset stats (port %u): %s", >> - __func__, port_id, strerror(ret)); >> + __func__, port_id, strerror(-ret)); >> return; >> } >> >> ret = rte_eth_stats_get(port_id, &ports[port_id].stats); >> if (ret != 0) { >> printf("%s: Error: failed to get stats (port %u): %s", >> - __func__, port_id, strerror(ret)); >> + __func__, port_id, strerror(-ret)); >> return; >> } >> printf("\n NIC statistics for port %d cleared\n", port_id); >> @@ -333,14 +333,14 @@ nic_xstats_clear(portid_t port_id) >> ret = rte_eth_xstats_reset(port_id); >> if (ret != 0) { >> printf("%s: Error: failed to reset xstats (port %u): %s", >> - __func__, port_id, strerror(ret)); >> + __func__, port_id, strerror(-ret)); >> return; >> } >> >> ret = rte_eth_stats_get(port_id, &ports[port_id].stats); >> if (ret != 0) { >> printf("%s: Error: failed to get stats (port %u): %s", >> - __func__, port_id, strerror(ret)); >> + __func__, port_id, strerror(-ret)); >> return; >> } >> } >> -- >> 2.7.4 >