From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 21FDD1B680; Mon, 23 Oct 2017 18:36:40 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2017 09:36:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,423,1503385200"; d="scan'208";a="1234198536" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.136]) ([10.241.225.136]) by fmsmga002.fm.intel.com with ESMTP; 23 Oct 2017 09:36:38 -0700 To: Shijith Thotton Cc: Jingjing Wu , Gregory Etelson , Harish Patil , Thomas Monjalon , dev@dpdk.org, stable@dpdk.org, Jianfeng Tan , George Prekas , Sergio Gonzalez Monroy References: <20171020165511.47899-1-ferruh.yigit@intel.com> <44560a31-d8dc-b2e1-1589-95020fb654f3@intel.com> <20171023122807.GA17153@localhost.localdomain> From: Ferruh Yigit Message-ID: Date: Mon, 23 Oct 2017 09:36:38 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171023122807.GA17153@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 16:36:41 -0000 On 10/23/2017 5:28 AM, Shijith Thotton wrote: > On Fri, Oct 20, 2017 at 09:57:38AM -0700, Ferruh Yigit wrote: >> On 10/20/2017 9:55 AM, Ferruh Yigit wrote: >>> Remove device reset during application start, the reset for application >>> exit still there. >>> >>> Reset in open removed because of following comments: >>> 1- Device reset not completed when VF driver loaded, which cause VF PMD >>> initialization error. >>> Adding delay can solve the issue but will increase driver load time. >>> >>> 2- Reset will be issues all devices unconditionally, not very efficient >>> way. >>> >>> Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Ferruh Yigit >> >> Hi Jingjing, Shijith, Gregory, Harish, >> >> Can you please test this on top of current master (which has already Jingjin's >> fix) ? > > Hi Ferruh, > > Tested for LiquidIO cards and it works. Thanks Shijith, Is following commit needs to be reverted after pci_reset removed from open(): Commit: 9ed3f38770c6 ("net/liquidio: remove FLR request to PF driver") Thanks, ferruh > > Thanks, > Shijith >