From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F51FA04B5; Tue, 29 Sep 2020 18:57:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B8D81DA35; Tue, 29 Sep 2020 18:56:28 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 092551DA49 for ; Tue, 29 Sep 2020 18:56:24 +0200 (CEST) IronPort-SDR: +x2qok5fsg8B+sIF7jst7Hy/85ZzjWK4YrCuy0PKGWCE1BOE4hZ3dPHDPwz9Eqi1B9Arfyyu8c xWh4DiyxvDeQ== X-IronPort-AV: E=McAfee;i="6000,8403,9759"; a="149898007" X-IronPort-AV: E=Sophos;i="5.77,319,1596524400"; d="scan'208";a="149898007" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 09:56:20 -0700 IronPort-SDR: rLb24urHv59aekUgZ7PkWwQi2PmqzlruT1qololJ+vai3tP0aK6Gs2T7nweBzMh5js7TJp9cfk IvuitTaWxoHQ== X-IronPort-AV: E=Sophos;i="5.77,319,1596524400"; d="scan'208";a="492196817" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.220.198]) ([10.213.220.198]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 09:56:19 -0700 To: wangyunjian , dev@dpdk.org Cc: keith.wiles@intel.com, thomas@monjalon.net, jerry.lilijun@huawei.com, xudingke@huawei.com References: <9a94f272bc7c1e5650295ddf3e02fb19b15e7951.1598596042.git.wangyunjian@huawei.com> <1600343273-22432-1-git-send-email-wangyunjian@huawei.com> From: Ferruh Yigit Message-ID: Date: Tue, 29 Sep 2020 17:56:15 +0100 MIME-Version: 1.0 In-Reply-To: <1600343273-22432-1-git-send-email-wangyunjian@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] net/tap: release port upon close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/17/2020 12:47 PM, wangyunjian wrote: > From: Yunjian Wang > > Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private > resources for the port can be freed by rte_eth_dev_close(). > > Signed-off-by: Yunjian Wang > --- > v2: > Remove redundant check and assignment suggested > by Ferruh Yigit and Thomas Monjalon Hi Yunjian, There is a newer version of the tap close in the patchset related to the ethdev close updates: https://patches.dpdk.org/patch/79086/ I will update this one as 'Superseded', can you please check the above one? Thanks, ferruh