From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 34AC7968 for ; Tue, 19 Sep 2017 11:27:59 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2017 02:27:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,417,1500966000"; d="scan'208";a="901729723" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 19 Sep 2017 02:27:01 -0700 To: Matan Azrad , Gaetan Rivet Cc: dev@dpdk.org References: <1505403124-44297-1-git-send-email-matan@mellanox.com> From: Ferruh Yigit Message-ID: Date: Tue, 19 Sep 2017 10:27:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1505403124-44297-1-git-send-email-matan@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] doc: update failsafe feature list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2017 09:28:00 -0000 On 9/14/2017 4:32 PM, Matan Azrad wrote: > Add supported failsafe features to feature list. > Remove stats per queue feature from failsafe feature list since > queue_stats_mapping_set dev op has not implemented yet. > > Signed-off-by: Matan Azrad > --- > doc/guides/nics/features/failsafe.ini | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/nics/features/failsafe.ini b/doc/guides/nics/features/failsafe.ini > index a42e344..9f48455 100644 > --- a/doc/guides/nics/features/failsafe.ini > +++ b/doc/guides/nics/features/failsafe.ini > @@ -4,20 +4,33 @@ > ; Refer to default.ini for the full list of available PMD features. > ; > [Features] > +Speed capabilities = Y > Link status = Y > Link status event = Y > MTU update = Y > Jumbo frame = Y > +Scattered Rx = Y > +LRO = Y > +TSO = Y > Promiscuous mode = Y > Allmulticast mode = Y > Unicast MAC filter = Y > Multicast MAC filter = Y > VLAN filter = Y > +Ethertype filter = Y > +N-tuple filter = Y > +SYN filter = Y > +Tunnel filter = Y > +Flexible filter = Y > +Hash filter = Y > +Flow director = Y > Flow control = Y > Flow API = Y > +QinQ offload = Y > +L3 checksum offload = Y > +L4 checksum offload = Y > Packet type parsing = Y > Basic stats = Y > -Stats per queue = Y > ARMv7 = Y > ARMv8 = Y > Power8 = Y I am not sure if claiming support for these features is correct. Failsafe itself doesn't provide these features, but relies underlying hardware which we don't really know what they supports or not in this stage. OK for dropping "Stats per queue" >