From: "Roger B. Melton" <rmelton@cisco.com>
To: "Dai, Wei" <wei.dai@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"laurent.hardy@6wind.com" <laurent.hardy@6wind.com>
Subject: Re: [dpdk-dev] bug in net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update beginning in 17.05-rc3?
Date: Wed, 10 May 2017 08:19:10 -0400 [thread overview]
Message-ID: <ef7ae0d3-d518-7629-6e59-5cc4184f274e@cisco.com> (raw)
In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D650A7AC3A@PGSMSX106.gar.corp.intel.com>
Thanks -Roger
On 5/10/17 4:20 AM, Dai, Wei wrote:
> Yes, it is a bug.
> The hw->mac.ops.get_media_type of ixgbe VF is NULL.
> I have just submitted a patch to fix it.
> http://dpdk.org/dev/patchwork/patch/24188/
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Roger B Melton
>> Sent: Wednesday, May 10, 2017 1:53 AM
>> To: dev@dpdk.org; laurent.hardy@6wind.com
>> Subject: [dpdk-dev] bug in net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update
>> beginning in 17.05-rc3?
>>
>> After updating to 17.05-rc4 I hit a crash in
>> drivers/net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update(). The issue was
>> a NULL get_media_type FV for the VF driver.
>>
>> Looking at recent commits, I see the following added the
>> get_media_type() check:
>>
>> commit c12d22f65b132c56db7b4fdbfd5ddce27d1e9572
>> Author: Laurent Hardy <laurent.hardy@6wind.com>
>> Date: Thu Apr 27 17:03:42 2017 +0200
>>
>> @@ -3793,6 +3797,14 @@ ixgbe_dev_link_update(struct
>> rte_eth_dev
>> *dev, int wait_to_complete)
>>
>> hw->mac.get_link_status = true;
>>
>> + if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) &&
>> + hw->mac.ops.get_media_type(hw) ==
>> ixgbe_media_type_fiber) {
>> + speed = hw->phy.autoneg_advertised;
>> + if (!speed)
>> + ixgbe_get_link_capabilities(hw,
>> &speed,
>> &autoneg);
>> + ixgbe_setup_link(hw, speed, true);
>> + }
>> +
>>
>> This is fine for the PF driver, but we shouldn't invoke get_media_type
>> for the VF.
>>
>>
>> Laurent,
>>
>> Is this a bug, or am I missing something? If it is a bug, what's the
>> proper fix?
>>
>> Regards,
>> Roger
>>
>>
>>
>>
>> --
>>
>> ________________________________________________________________
>>
prev parent reply other threads:[~2017-05-10 12:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 17:52 Roger B Melton
2017-05-10 8:20 ` Dai, Wei
2017-05-10 12:19 ` Roger B. Melton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef7ae0d3-d518-7629-6e59-5cc4184f274e@cisco.com \
--to=rmelton@cisco.com \
--cc=dev@dpdk.org \
--cc=laurent.hardy@6wind.com \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).