[dpdk-dev] bug in net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update beginning in 17.05-rc3?

[dpdk-dev] bug in net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update beginning in 17.05-rc3?

[Roger B Melton]

After updating to 17.05-rc4 I hit a crash in 
drivers/net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update().  The issue was 
a NULL get_media_type FV for the VF driver.

Looking at recent commits, I see the following added the 
get_media_type() check:

    commit c12d22f65b132c56db7b4fdbfd5ddce27d1e9572
    Author: Laurent Hardy <laurent.hardy@6wind.com>
    Date:   Thu Apr 27 17:03:42 2017 +0200

        @@ -3793,6 +3797,14 @@ ixgbe_dev_link_update(struct rte_eth_dev
        *dev, int wait_to_complete)

                 hw->mac.get_link_status = true;

        +       if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) &&
        +               hw->mac.ops.get_media_type(hw) ==
        ixgbe_media_type_fiber) {
        +               speed = hw->phy.autoneg_advertised;
        +               if (!speed)
        +                       ixgbe_get_link_capabilities(hw, &speed,
        &autoneg);
        +               ixgbe_setup_link(hw, speed, true);
        +       }
        +

This is fine for the PF driver, but we shouldn't invoke get_media_type 
for the VF.


Laurent,

Is this a bug, or am I missing something?  If it is a bug, what's the 
proper fix?

Regards,
Roger




-- 
  ____________________________________________________________________
|Roger B. Melton                |          |      Cisco Systems      |
|CPP Software                  :|:        :|:     7100 Kit Creek Rd  |
|+1.919.476.2332 phone        :|||:      :|||:    RTP, NC 27709-4987 |
|+1.919.392.1094 fax       .:|||||||:..:|||||||:. rmelton@cisco.com  |
|                                                                    |
| This email may contain confidential and privileged material for the|
| sole use of the intended recipient. Any review, use, distribution  |
| or disclosure by others is strictly prohibited. If you are not the |
| intended recipient (or authorized to receive for the recipient),   |
| please contact the sender by reply email and delete all copies of  |
| this message.                                                      |
|                                                                    |
| For corporate legal information go to:                             |
| http://www.cisco.com/web/about/doing_business/legal/cri/index.html |
|__________________________ http://www.cisco.com ____________________|

Re: [dpdk-dev] bug in net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update beginning in 17.05-rc3?

[Dai, Wei]

Yes, it is a bug.
The hw->mac.ops.get_media_type of ixgbe VF is NULL.
I have just submitted a patch to fix it.
http://dpdk.org/dev/patchwork/patch/24188/

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Roger B Melton
> Sent: Wednesday, May 10, 2017 1:53 AM
> To: dev@dpdk.org; laurent.hardy@6wind.com
> Subject: [dpdk-dev] bug in net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update
> beginning in 17.05-rc3?
> 
> After updating to 17.05-rc4 I hit a crash in
> drivers/net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update().  The issue was
> a NULL get_media_type FV for the VF driver.
> 
> Looking at recent commits, I see the following added the
> get_media_type() check:
> 
>     commit c12d22f65b132c56db7b4fdbfd5ddce27d1e9572
>     Author: Laurent Hardy <laurent.hardy@6wind.com>
>     Date:   Thu Apr 27 17:03:42 2017 +0200
> 
>         @@ -3793,6 +3797,14 @@ ixgbe_dev_link_update(struct
> rte_eth_dev
>         *dev, int wait_to_complete)
> 
>                  hw->mac.get_link_status = true;
> 
>         +       if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) &&
>         +               hw->mac.ops.get_media_type(hw) ==
>         ixgbe_media_type_fiber) {
>         +               speed = hw->phy.autoneg_advertised;
>         +               if (!speed)
>         +                       ixgbe_get_link_capabilities(hw,
> &speed,
>         &autoneg);
>         +               ixgbe_setup_link(hw, speed, true);
>         +       }
>         +
> 
> This is fine for the PF driver, but we shouldn't invoke get_media_type
> for the VF.
> 
> 
> Laurent,
> 
> Is this a bug, or am I missing something?  If it is a bug, what's the
> proper fix?
> 
> Regards,
> Roger
> 
> 
> 
> 
> --
> 
> ________________________________________________________________
> ____
> |Roger B. Melton                |          |      Cisco Systems
> |
> |CPP Software                  :|:        :|:     7100 Kit Creek Rd  |
> |+1.919.476.2332 phone        :|||:      :|||:    RTP, NC 27709-4987 |
> |+1.919.392.1094 fax       .:|||||||:..:|||||||:. rmelton@cisco.com  |
> |
> |
> | This email may contain confidential and privileged material for the|
> | sole use of the intended recipient. Any review, use, distribution  |
> | or disclosure by others is strictly prohibited. If you are not the |
> | intended recipient (or authorized to receive for the recipient),   |
> | please contact the sender by reply email and delete all copies of  |
> | this message.
> |
> |
> |
> | For corporate legal information go to:                             |
> | http://www.cisco.com/web/about/doing_business/legal/cri/index.html |
> |__________________________ http://www.cisco.com
> ____________________|

Re: [dpdk-dev] bug in net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update beginning in 17.05-rc3?

[Roger B. Melton]

Thanks  -Roger


On 5/10/17 4:20 AM, Dai, Wei wrote:
> Yes, it is a bug.
> The hw->mac.ops.get_media_type of ixgbe VF is NULL.
> I have just submitted a patch to fix it.
> http://dpdk.org/dev/patchwork/patch/24188/
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Roger B Melton
>> Sent: Wednesday, May 10, 2017 1:53 AM
>> To: dev@dpdk.org; laurent.hardy@6wind.com
>> Subject: [dpdk-dev] bug in net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update
>> beginning in 17.05-rc3?
>>
>> After updating to 17.05-rc4 I hit a crash in
>> drivers/net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update().  The issue was
>> a NULL get_media_type FV for the VF driver.
>>
>> Looking at recent commits, I see the following added the
>> get_media_type() check:
>>
>>      commit c12d22f65b132c56db7b4fdbfd5ddce27d1e9572
>>      Author: Laurent Hardy <laurent.hardy@6wind.com>
>>      Date:   Thu Apr 27 17:03:42 2017 +0200
>>
>>          @@ -3793,6 +3797,14 @@ ixgbe_dev_link_update(struct
>> rte_eth_dev
>>          *dev, int wait_to_complete)
>>
>>                   hw->mac.get_link_status = true;
>>
>>          +       if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) &&
>>          +               hw->mac.ops.get_media_type(hw) ==
>>          ixgbe_media_type_fiber) {
>>          +               speed = hw->phy.autoneg_advertised;
>>          +               if (!speed)
>>          +                       ixgbe_get_link_capabilities(hw,
>> &speed,
>>          &autoneg);
>>          +               ixgbe_setup_link(hw, speed, true);
>>          +       }
>>          +
>>
>> This is fine for the PF driver, but we shouldn't invoke get_media_type
>> for the VF.
>>
>>
>> Laurent,
>>
>> Is this a bug, or am I missing something?  If it is a bug, what's the
>> proper fix?
>>
>> Regards,
>> Roger
>>
>>
>>
>>
>> --
>>
>> ________________________________________________________________
>>