From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-5.cisco.com (alln-iport-5.cisco.com [173.37.142.92]) by dpdk.org (Postfix) with ESMTP id 90849234 for ; Wed, 10 May 2017 14:19:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1972; q=dns/txt; s=iport; t=1494418752; x=1495628352; h=subject:to:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding; bh=JDte0yh8r9qZIhv2IzVhM0SYVKdssL5+4FSDajB7kkA=; b=AiBKI4lk///kDv5awcRpuN75lJyK8k114IJjR7ZaetwlimslBYCZ4m1M CM+crlN2pI4nXe+eru+IqT4uLjuwJzB2PR3NOWUn5kbm5ptM9wHHAk1kc Smg8iNZ3mJr2gt0cMpasmc1SEIlQsRRK+v0NakSUWNsCJQF6XXiwA3cvD g=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0DkAACKBBNZ/5JdJa1dGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg1VigQyDaYoYkTUhkROEX4IPLIV4AoR8PxgBAgEBAQEBAQFrKIU?= =?us-ascii?q?VAQEBAQMjBBFNBAsRAwEBAQECAiMDAgJGCQgGAQwGAgEBih0OskuBbDqKdQEBA?= =?us-ascii?q?QEBAQEBAQEBAQEBAQEBAQEBHoELhVSBXisLgmWEY4MOgmABBJ4KAYcbi3+CWYg?= =?us-ascii?q?phmlIk3sfOIEKcBWFcYFmJDaJGQEBAQ?= X-IronPort-AV: E=Sophos;i="5.38,319,1491264000"; d="scan'208";a="422609628" Received: from rcdn-core-10.cisco.com ([173.37.93.146]) by alln-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2017 12:19:11 +0000 Received: from [10.150.214.135] ([10.150.214.135]) by rcdn-core-10.cisco.com (8.14.5/8.14.5) with ESMTP id v4ACJABR013196; Wed, 10 May 2017 12:19:10 GMT To: "Dai, Wei" , "dev@dpdk.org" , "laurent.hardy@6wind.com" References: <2b994b06-0b9e-6e12-79b7-b5f270d0c3ee@cisco.com> <49759EB36A64CF4892C1AFEC9231E8D650A7AC3A@PGSMSX106.gar.corp.intel.com> From: "Roger B. Melton" Message-ID: Date: Wed, 10 May 2017 08:19:10 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D650A7AC3A@PGSMSX106.gar.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] bug in net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update beginning in 17.05-rc3? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2017 12:19:13 -0000 Thanks -Roger On 5/10/17 4:20 AM, Dai, Wei wrote: > Yes, it is a bug. > The hw->mac.ops.get_media_type of ixgbe VF is NULL. > I have just submitted a patch to fix it. > http://dpdk.org/dev/patchwork/patch/24188/ > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Roger B Melton >> Sent: Wednesday, May 10, 2017 1:53 AM >> To: dev@dpdk.org; laurent.hardy@6wind.com >> Subject: [dpdk-dev] bug in net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update >> beginning in 17.05-rc3? >> >> After updating to 17.05-rc4 I hit a crash in >> drivers/net/ixgbe/ixgbe_ethdev.c:ixgbe_dev_link_update(). The issue was >> a NULL get_media_type FV for the VF driver. >> >> Looking at recent commits, I see the following added the >> get_media_type() check: >> >> commit c12d22f65b132c56db7b4fdbfd5ddce27d1e9572 >> Author: Laurent Hardy >> Date: Thu Apr 27 17:03:42 2017 +0200 >> >> @@ -3793,6 +3797,14 @@ ixgbe_dev_link_update(struct >> rte_eth_dev >> *dev, int wait_to_complete) >> >> hw->mac.get_link_status = true; >> >> + if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) && >> + hw->mac.ops.get_media_type(hw) == >> ixgbe_media_type_fiber) { >> + speed = hw->phy.autoneg_advertised; >> + if (!speed) >> + ixgbe_get_link_capabilities(hw, >> &speed, >> &autoneg); >> + ixgbe_setup_link(hw, speed, true); >> + } >> + >> >> This is fine for the PF driver, but we shouldn't invoke get_media_type >> for the VF. >> >> >> Laurent, >> >> Is this a bug, or am I missing something? If it is a bug, what's the >> proper fix? >> >> Regards, >> Roger >> >> >> >> >> -- >> >> ________________________________________________________________ >>