From: Ivan Malov <ivan.malov@oktetlabs.ru>
To: "Jiang, YuX" <yux.jiang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Chas Williams <3chas3@gmail.com>,
"Min Hu (Connor)" <humin29@huawei.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Chas Williams <chas3@att.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: RE: [PATCH v2] net/bonding: make bonded device configure method re-entrant
Date: Tue, 1 Nov 2022 19:33:58 +0300 (MSK) [thread overview]
Message-ID: <ef8e5116-ca88-3bdf-9093-6977971f16fd@oktetlabs.ru> (raw)
In-Reply-To: <BYAPR11MB2711350CE4F9D0E10CE1AACCFE369@BYAPR11MB2711.namprd11.prod.outlook.com>
Hi,
Thanks for noticing the bug. A fix has been proposed already:
https://patches.dpdk.org/project/dpdk/patch/20221101161853.2702425-1-ivan.malov@oktetlabs.ru/
With the fix applied, does the problem still manifest itself?
Please let me know.
Thank you.
On Tue, 1 Nov 2022, Jiang, YuX wrote:
> Hi Ivan,
>
> This patch introduces a bug https://bugs.dpdk.org/show_bug.cgi?id=1119, can you pls have a look quickly?
>
> Best regards,
> Yu Jiang
>
>> -----Original Message-----
>> From: Ivan Malov <ivan.malov@oktetlabs.ru>
>> Sent: Wednesday, October 19, 2022 3:46 AM
>> To: dev@dpdk.org
>> Cc: Chas Williams <3chas3@gmail.com>; Min Hu (Connor)
>> <humin29@huawei.com>; Andrew Rybchenko
>> <andrew.rybchenko@oktetlabs.ru>; Chas Williams <chas3@att.com>; Burakov,
>> Anatoly <anatoly.burakov@intel.com>
>> Subject: [PATCH v2] net/bonding: make bonded device configure method re-
>> entrant
>>
>> According to the documentation, rte_eth_dev_configure() can be invoked
>> repeatedly while in stopped state.
>> The current implementation in the bonding driver allows for that (technically),
>> but the user sees warnings which say that back-end devices have already been
>> harnessed. Re-factor the code to have cleanup before each (re-)configure.
>>
>> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
>> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>> Acked-by: Chas Williams <3chas3@gmail.com>
>> ---
>
>
next prev parent reply other threads:[~2022-11-01 16:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 12:24 [PATCH] " Ivan Malov
2022-10-17 8:42 ` Andrew Rybchenko
2022-10-17 12:32 ` Chas Williams
2022-10-17 14:10 ` Andrew Rybchenko
2022-10-18 10:34 ` Chas Williams
2022-10-18 12:44 ` Andrew Rybchenko
2022-10-18 19:45 ` [PATCH v2] " Ivan Malov
2022-10-19 10:26 ` Andrew Rybchenko
2022-11-01 10:56 ` Jiang, YuX
2022-11-01 16:33 ` Ivan Malov [this message]
2022-11-02 5:20 ` Jiang, YuX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef8e5116-ca88-3bdf-9093-6977971f16fd@oktetlabs.ru \
--to=ivan.malov@oktetlabs.ru \
--cc=3chas3@gmail.com \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).