From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88243A00C2; Tue, 1 Nov 2022 17:34:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B46C40693; Tue, 1 Nov 2022 17:34:04 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 1965C40223 for ; Tue, 1 Nov 2022 17:34:03 +0100 (CET) Received: by shelob.oktetlabs.ru (Postfix, from userid 115) id 2C0A467; Tue, 1 Nov 2022 19:33:59 +0300 (MSK) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mail1.oktetlabs.ru X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_DISCARD, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from bree.oktetlabs.ru (bree.oktetlabs.ru [192.168.34.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPS id AE5EA5A; Tue, 1 Nov 2022 19:33:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru AE5EA5A Authentication-Results: shelob.oktetlabs.ru/AE5EA5A; dkim=none; dkim-atps=neutral Date: Tue, 1 Nov 2022 19:33:58 +0300 (MSK) From: Ivan Malov To: "Jiang, YuX" cc: "dev@dpdk.org" , Chas Williams <3chas3@gmail.com>, "Min Hu (Connor)" , Andrew Rybchenko , Chas Williams , "Burakov, Anatoly" Subject: RE: [PATCH v2] net/bonding: make bonded device configure method re-entrant In-Reply-To: Message-ID: References: <20220911122405.3995083-1-ivan.malov@oktetlabs.ru> <20221018194549.635113-1-ivan.malov@oktetlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Thanks for noticing the bug. A fix has been proposed already: https://patches.dpdk.org/project/dpdk/patch/20221101161853.2702425-1-ivan.malov@oktetlabs.ru/ With the fix applied, does the problem still manifest itself? Please let me know. Thank you. On Tue, 1 Nov 2022, Jiang, YuX wrote: > Hi Ivan, > > This patch introduces a bug https://bugs.dpdk.org/show_bug.cgi?id=1119, can you pls have a look quickly? > > Best regards, > Yu Jiang > >> -----Original Message----- >> From: Ivan Malov >> Sent: Wednesday, October 19, 2022 3:46 AM >> To: dev@dpdk.org >> Cc: Chas Williams <3chas3@gmail.com>; Min Hu (Connor) >> ; Andrew Rybchenko >> ; Chas Williams ; Burakov, >> Anatoly >> Subject: [PATCH v2] net/bonding: make bonded device configure method re- >> entrant >> >> According to the documentation, rte_eth_dev_configure() can be invoked >> repeatedly while in stopped state. >> The current implementation in the bonding driver allows for that (technically), >> but the user sees warnings which say that back-end devices have already been >> harnessed. Re-factor the code to have cleanup before each (re-)configure. >> >> Signed-off-by: Ivan Malov >> Reviewed-by: Andrew Rybchenko >> Acked-by: Chas Williams <3chas3@gmail.com> >> --- > >