From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5383DA04BA; Wed, 7 Oct 2020 11:37:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 743172BC7; Wed, 7 Oct 2020 11:37:28 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 27CEB1DBF for ; Wed, 7 Oct 2020 11:37:25 +0200 (CEST) IronPort-SDR: +hSgj8HupigSXOtpTK5NALeTxKhBg4lvGolrSpiCuFhsydvF09DhjPapz2m2L5ddTGyBwM/FqS wTosRNR0huWQ== X-IronPort-AV: E=McAfee;i="6000,8403,9766"; a="229018471" X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="229018471" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 02:37:23 -0700 IronPort-SDR: crI7lsTDv8H0xpv+XUH3uCxmHHogrdpSMGyXOgZ3Y5PhgDwN3YWuIeBxCRbtsCXy96UHH0AjqS 3zezzNmrXL2A== X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="461249006" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.193.102]) ([10.213.193.102]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 02:37:22 -0700 To: Kalesh Anakkur Purayil , Ophir Munk Cc: "dev@dpdk.org" , NBU-Contact-Thomas Monjalon References: <20200122101654.20824-1-kalesh-anakkur.purayil@broadcom.com> <20200930123314.27669-1-kalesh-anakkur.purayil@broadcom.com> <20200930123314.27669-4-kalesh-anakkur.purayil@broadcom.com> From: Ferruh Yigit Message-ID: Date: Wed, 7 Oct 2020 10:37:19 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC PATCH v4 3/3] app/testpmd: handle device recovery event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/7/2020 5:46 AM, Kalesh Anakkur Purayil wrote: > Hi Ophir, > > Thank you for the comments. I will address them in the next version. > > I will push these changes as Patches next time and not as an RFC. Hope that > is OK. > > Regards, > Kalesh > > On Tue, Oct 6, 2020 at 10:55 PM Ophir Munk wrote: > >> Hi Kalesh, >> Please find a few comments. >> The name you gave to the event (EVENT_RESET) is very close to an already >> existing one: "EVENT_INTR_RESET". >> But they are different. >> EVENT_INTR_RESET originates from a port reset. It requires application >> reaction. It is widely used. It is documented in *.rst files. >> EVENT_RESET originates from FW error (or maybe any error). It requires no >> application reaction (PMD manages by itself). It is not documented. >> I therefore suggest renaming it (maybe EVENT_ERR_RECOVERING) and please >> document it in *.rst files. +1 to renaming and documenting the event. And agree to proceed as regular patch instead of RFC. >> More comments below: >> >>> -----Original Message----- >>> From: dev On Behalf Of Kalesh A P >>> Sent: Wednesday, September 30, 2020 3:33 PM >>> To: dev@dpdk.org >>> Subject: [dpdk-dev] [RFC PATCH v4 3/3] app/testpmd: handle device >> recovery >>> event >>> >>> From: Kalesh AP >>> >>> Added code to handle device reset and recovery event in testpmd. >>> This is an indication from the PMD that device has reset and recovered >> error >>> condition. >>> >>> Signed-off-by: Kalesh AP >>> Reviewed-by: Ajit Kumar Khaparde >>> --- >>> app/test-pmd/testpmd.c | 6 +++++- >>> 1 file changed, 5 insertions(+), 1 deletion(-) >>> >>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index >>> fe6450c..1c8fb46 100644 >>> --- a/app/test-pmd/testpmd.c >>> +++ b/app/test-pmd/testpmd.c >>> @@ -380,6 +380,8 @@ static const char * const eth_event_desc[] = { >>> [RTE_ETH_EVENT_NEW] = "device probed", >>> [RTE_ETH_EVENT_DESTROY] = "device released", >>> [RTE_ETH_EVENT_FLOW_AGED] = "flow aged", >>> + [RTE_ETH_EVENT_RESET] = "device reset", >> >> "device reset" is similar to the existing "reset" string. Can you suggest >> a different one? Maybe "error under recovery" ? >> >>> + [RTE_ETH_EVENT_RECOVERED] = "device recovery", >> >> Wouldn't you prefer "device recovered" ? >> >>> [RTE_ETH_EVENT_MAX] = NULL, >>> }; >>> >>> @@ -394,7 +396,9 @@ uint32_t event_print_mask = (UINT32_C(1) << >>> RTE_ETH_EVENT_UNKNOWN) | >>> (UINT32_C(1) << RTE_ETH_EVENT_IPSEC) | >>> (UINT32_C(1) << RTE_ETH_EVENT_MACSEC) | >>> (UINT32_C(1) << RTE_ETH_EVENT_INTR_RMV) | >>> - (UINT32_C(1) << RTE_ETH_EVENT_FLOW_AGED); >>> + (UINT32_C(1) << RTE_ETH_EVENT_FLOW_AGED) | >>> + (UINT32_C(1) << RTE_ETH_EVENT_RESET) | >>> + (UINT32_C(1) << RTE_ETH_EVENT_RECOVERED); >>> /* >>> * Decide if all memory are locked for performance. >>> */ >>> -- >>> 2.10.1 >> >> >