From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id DE0D35323; Mon, 1 Apr 2019 19:18:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 10:17:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,297,1549958400"; d="scan'208";a="139228917" Received: from klaatz-mobl.ger.corp.intel.com (HELO [10.237.220.123]) ([10.237.220.123]) by fmsmga007.fm.intel.com with ESMTP; 01 Apr 2019 10:17:58 -0700 To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org References: <20190328153045.8178-1-bruce.richardson@intel.com> From: "Laatz, Kevin" Message-ID: Date: Mon, 1 Apr 2019 18:17:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190328153045.8178-1-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] telemetry: fix incorrect stat name to id mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2019 17:18:01 -0000 On 28/03/2019 15:30, Bruce Richardson wrote: > If we have two NIC ports which have a different set of NIC stats we can > end up having two different stats registered with xstats with the same > name. [Since the stats are updated in bulk as a contiguous set, the > second driver re-using the registration of the first is not possible.] > > This causes issues with the invalid stat for one driver being found due to > a lookup by name which is unnecessary. Instead of getting stat names > involved do the lookup by ID instead. > > CC: stable@dpdk.org > Fixes: 1b756087db93 ("telemetry: add parser for client socket messages") > > Signed-off-by: Bruce Richardson > --- Looks good to me! Thanks. Acked-by: Kevin Laatz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D8EB2A0679 for ; Mon, 1 Apr 2019 19:18:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C779854AE; Mon, 1 Apr 2019 19:18:02 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id DE0D35323; Mon, 1 Apr 2019 19:18:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 10:17:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,297,1549958400"; d="scan'208";a="139228917" Received: from klaatz-mobl.ger.corp.intel.com (HELO [10.237.220.123]) ([10.237.220.123]) by fmsmga007.fm.intel.com with ESMTP; 01 Apr 2019 10:17:58 -0700 To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org References: <20190328153045.8178-1-bruce.richardson@intel.com> From: "Laatz, Kevin" Message-ID: Date: Mon, 1 Apr 2019 18:17:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190328153045.8178-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] telemetry: fix incorrect stat name to id mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190401171758.2UA4iLqK1PcHoVS1HhWy10MwbO2YeSe5p3X9hGnCGnA@z> On 28/03/2019 15:30, Bruce Richardson wrote: > If we have two NIC ports which have a different set of NIC stats we can > end up having two different stats registered with xstats with the same > name. [Since the stats are updated in bulk as a contiguous set, the > second driver re-using the registration of the first is not possible.] > > This causes issues with the invalid stat for one driver being found due to > a lookup by name which is unnecessary. Instead of getting stat names > involved do the lookup by ID instead. > > CC: stable@dpdk.org > Fixes: 1b756087db93 ("telemetry: add parser for client socket messages") > > Signed-off-by: Bruce Richardson > --- Looks good to me! Thanks. Acked-by: Kevin Laatz