From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09AD041E64; Fri, 10 Mar 2023 22:11:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D928D40DD8; Fri, 10 Mar 2023 22:11:56 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id 0400440685; Fri, 10 Mar 2023 22:11:55 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kYwjEp9H3+jXJT1bwF958eE1zv7A1TR//aQfEcYSaxswtyWTKrPzOnjmIispVPUWHQ0H6qIBBiqCaeONJimQdramSX9O9VfAqxtwQU0AU/4SxnNhItJjoy1/5E+5XUcYNPVw8mhHUrzUHa5qWMA5ccoeWR8W/+87KM0v5z360P6wlenbLHY24wlb+7sSnec7IOju1amPtXLrZwWnFP9DCmcqwwcor5N1KES67VexQspIZ+nrReRglfVMZYS9SZGITXPgEdwm3actom48T1uw0TEWKnU+zVLMuP8DcXm2GxO3OW784sCdonD6zbLxrw6tWVSuOkxaatidfEs6+9Kn9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9NqKPiCu4EWASu1Opoe90JgDR+yfuRTg/8DHP0lG+z0=; b=C7thJmyaGJcvDKlIXVaG9Vtmu4cMcccJc4OAAG6YpylI97L93oYQIJuoQHlhtW+siatN0/d7UGvnWQhTKo0vWZMAsQs7sGX+x0QkeQ2Myf991ksrb8LMLE6F189xcbFeTiUuQzRAAdqQX4+bgLPCL35x4nHoJls9NNRYy+SaRCNxcl2Rh32uZ2FjSbknYmKrv5jno9ARra2evGn3sJ0bef0Xc4FesCT9qcyvDjao23q5TsWOUimNYkMnwaO6WgB1Kepgraot2Ar76djqBcM+AvlHmZqoobsm6PQFKvvDqxJmUfPiEzeXHdafNNKVWIln4nez8VHsYRIuVHINRqg34g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9NqKPiCu4EWASu1Opoe90JgDR+yfuRTg/8DHP0lG+z0=; b=j4doHYHYr0SxqI/XEuyHBOPd7IQixWpk9bbS3A/o3/huo91K0OiXpOspcjTdORifvoV+7kuQu7osIecaDsD2E2x4AmBQ2wz7G/vq85d23kzPRoMppU/++NVZm7viE5TwnNAyKPw1bxlC5u9+K8Aoup1LFJAiGw9RVQqyL0R57m0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM6PR12MB4530.namprd12.prod.outlook.com (2603:10b6:5:2aa::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Fri, 10 Mar 2023 21:11:53 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640%5]) with mapi id 15.20.6178.019; Fri, 10 Mar 2023 21:11:53 +0000 Message-ID: Date: Fri, 10 Mar 2023 21:11:47 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] net/bonding: fix forward packets failed Content-Language: en-US To: Kaiwen Deng , dev@dpdk.org, Chas Williams , "Min Hu (Connor)" Cc: stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com, Declan Doherty , Tomasz Kulasek , Thomas Monjalon References: <20230310044131.2052540-1-kaiwenx.deng@intel.com> From: Ferruh Yigit In-Reply-To: <20230310044131.2052540-1-kaiwenx.deng@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0020.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::32) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB4530:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d624833-3aaf-4d32-465a-08db21ac1266 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sfUxWRmgQ1qwLrBQKsph8soDY7/Xon+hOXFtAzmaVapb+QdKnW9E9aCUhMXe80l156XaPwmthNZtmjEJS97kwEr2XiCYHQtPpYwkZfgQViocsXkbv6QusYPDBOQZhtbl4vjbgf1YX0xJekxRPSRczJjjP4nHJQZj66IVK6+EP3x9/lJXDjMnH828kQW8i2+85XvjEQ+gX3uO00dT/ggEGnqHI9HWo2crugPuahT6RpMGmHdVeFl7l7yCjYkUWe47xyqBaxLV58pRR5umsza3kVGacr39jpL4J/gd9/OdND7IIIf2hLIw3N2noQJofYXdqwwRzpiTAd9w4R+saktlhZEVFFimIMM071jH21ZrVPMAMlAw0VgbNx7SXwedqQEjr8R53jb+ebtN68vQMkFBLt6IkcHhbk7wOuO8QnZAo2RWyNcl7PecYP/qXU5/jkxtmdlTj1WxnHHh9BoAD8+BwqWvtFkMzxQOy2B6oVxChvfZl5XgeAJq+pjhcKmot7Abo/7VOSSLmsnQcRjmXtCp6mo0xA2Gp86/E/QzGwpFOQumtLgrcxjebzhDIvtdA05nosQGFb47deauwYpWBMKBP3v9nNQTy574nYNKMRfi4PDGdWagurCzHkvbk7y7wQFL/8DdUM7wMs02DBPagGZdhSOsxTy2OWMk+2yoI1jplv626O3O1m4ZENypjmgUMfPyGsTVcDrXyDA5/ez3W3xxCOSSmPqbGxSXIrPnxfY68UI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(346002)(396003)(39860400002)(136003)(366004)(451199018)(2906002)(31686004)(83380400001)(44832011)(5660300002)(7416002)(36756003)(66476007)(66556008)(31696002)(8936002)(66946007)(8676002)(26005)(316002)(4326008)(38100700002)(6666004)(86362001)(110136005)(186003)(54906003)(478600001)(6506007)(2616005)(53546011)(6512007)(6486002)(41300700001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RERoL1RuSnQ4TUFzUGV0MVZpb1RlQ0FraXpCVkFiVXR5bEYyTlRVS0N6Yjg5?= =?utf-8?B?d0FZYlphMTJoSm1XRzM0NWJuWHhWajlvMDVCQ1ppRDkxd2Q0SW1pdFduUVJM?= =?utf-8?B?R3dWT2Z3WlowRzIwM0dsdm5HaGtBSlI5ZDBzSGU2d09zOXFEVjlrQTg4MHN5?= =?utf-8?B?dVVaWW1wdm4xTGNMM2pXbFNMUjNqQ29zQUhQOGJwcHZaYnBvSU9ZT1owTzB3?= =?utf-8?B?TlpHbFF3N3lLSUxWUEZRQ0RYY24vQVBqUE9KT2wvdWhmZzYwT1R2dHovUDFV?= =?utf-8?B?Nis2OW5JNFFhdUM2R2M5Vnc0dGdIUGV2QkN1Vno2dldLc2FuN2w2NzdPZUtD?= =?utf-8?B?WGRnL25LbnR3dEhUaStHNStTNWM0dXVmb2c5ZmNVUitucFhQcDZMOUhHVG0y?= =?utf-8?B?ckE5OTNwc3R1QWFqZVUxTWM5NnJTQTVRTWo0U1lseG1uZFlrUXFpb09XdXNV?= =?utf-8?B?U20zVW5nbHNMQ0VUbXY5WFhscWZYOVlsOGdxMS9DajU4VXBoeWp3WDByY1M2?= =?utf-8?B?aXkrR0N2VFRab0d1ZllmWmE0ckcrYVZMV1lFazdpQk41R3puMlFmL3JYbmwy?= =?utf-8?B?Z2tWb3JCekxlZmFDNGcvejNSM3E2WmdHRGZVaDE5SUNzdk44eWdxSVdhOXE2?= =?utf-8?B?L3AvR045RktxRVk2cm9SVW0rd3owNktKRjkreEptaVJzaUthTXZKYUFYOXRx?= =?utf-8?B?TDVXQlVFZEtITEtJVk5zWWt0RVRqY01QbWg4ZElNS2ZPdW1yWWVRc3RmWHp6?= =?utf-8?B?ZUNTM0N0UTlDK1p1LzNlaEtPajcwR2JBRHkwNXZ0OThBSGh1OFZxSWxld3N3?= =?utf-8?B?cnVYSGRHbkhtbHIwZDNub1VJY0s1d3VUYVh4Q2xldWxSUng0eXdmTXFvdHUw?= =?utf-8?B?a0E4K0pqSVZNZExCQmltMy9NYkxNM2c1TndkcjVlRVoyRmp5UklxN1FxQW1z?= =?utf-8?B?eU1UbnljN0hSa1plakNqT3prcnFNcytSVWcyTW81MnhndzhsclJTMW1Rc2c2?= =?utf-8?B?Um5lOUw3dVUrVnc0RXRZWjZZamhmd1B0WEMvM0ZIcDM3UzdITDBoOG5mYVd5?= =?utf-8?B?bWU3S1JBcDkxZ1AxY2xTYVhvbExzekllV1ZTbmlGdjFaMzNIT255bmhhM2th?= =?utf-8?B?TFZqZWtyeTFSdko4MFFGZG5BTGRXUkhNQWpHNzlnbExVZkNVa20xZ25BYm9q?= =?utf-8?B?dkVpY0tJcEtaeW12OE9FelAzd1VCTEVsRGVBdzBpT2hTN0MwU0VSWkF2NDg5?= =?utf-8?B?MXdiUndORTAwMDQ3bFNZMEFCRjZoZ3h5M0R0UHBnZ0VYM28xcnA1dWx0UGM0?= =?utf-8?B?QXFtUXVZL1FUNWd5VUN4b2ZiQWlkZCsreDgrbjJzcEVjaHgxcm9JVk5SMWdp?= =?utf-8?B?SElhY04xY1hkcm9nVWNoMmg0MjFDcE01a0IxaTBsb09EWTRJSVVqQ2hyQk1X?= =?utf-8?B?RDNPdklRN1hzTS9zc0R4aW5wQ2hIQkMzUWVFZmxTMjV0aTlZWkRpNExxS0F6?= =?utf-8?B?dTRxTFI3MXhzb084STZiT2hHWmFZQ3FZbkJMTXlFdzlNOU5FR2hlSDFyYys2?= =?utf-8?B?N1hGOTJ4SEd4VHV2ZUtRVVBkeGtQM0tMRHBrTlgyYzRteW5INVZySnhac3Jv?= =?utf-8?B?VjRNbW1ETlh6REUydEVRTmtIZUZXRXlKZGNMeWVoOGMxL0V3WE5UNVozSWcr?= =?utf-8?B?VDdpWEYxbWNqZE9yVHFRVEJnNGprYjd4OXFTZ2xYS3l0NEV4cHRlTkF5UFo1?= =?utf-8?B?VE9EakJkU3ZreHFpaStoOC9tbEJJK1RVUHpQeGpvZUd3dWlkKytsUzl2d2dT?= =?utf-8?B?KzQyRkQ2SS84Z1JrNU1RVHQrNzBtZmpkS1NsVy9Ha3lEcDE0aXJRRS9UaVVG?= =?utf-8?B?S0poVWdwYXU3blRuUU1CNk0zU0pFTUtlZmc1NzMvNWxRUjhVUTd1Mk1jdjZ6?= =?utf-8?B?c1ZFSjR3b0NvbXQ2eWcrcENieUw2YnIrREN5UzNyd0UyZnhiVUw0elAyTjRx?= =?utf-8?B?ZjQwR0NnSElvM21kZlc1Z0FFVlFoL0xMMEdoNHBPTEJRNlF6VjVVdC9jSkNG?= =?utf-8?B?VmFYMnk2NklUNXVpR0I2Wnd4Q0ZwL3RqY0ZOSjhDdmJYbmRaSnVxOHBtQUsy?= =?utf-8?Q?9AUeEjzIR8OzpCMqpjjQ0xehS?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d624833-3aaf-4d32-465a-08db21ac1266 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 21:11:53.2653 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +vMk6kfb7mVJI4WOA6w2VygVZHlTjk3U8OL6bwO6+wC9/VN2q7KX3g2zYHwQEl86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4530 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/10/2023 4:41 AM, Kaiwen Deng wrote: > The bond port is failed to forward packets in Link Aggregation > 802.3AD(4) mode. Because bond devices get LACP packets from > rx_ring instead of tx_ring. > > This commit will get LACP packets from tx_ring instead. > > Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control") > Cc: stable@dpdk.org > Fixes commit is from 2017, was 802.3AD mode broken since that time? Or is this for a specific use case? > Signed-off-by: Kaiwen Deng > --- > drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c > index 4a266bb2ca..b585752b00 100644 > --- a/drivers/net/bonding/rte_eth_bond_8023ad.c > +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c > @@ -941,7 +941,7 @@ bond_mode_8023ad_periodic_cb(void *arg) > /* Find LACP packet to this port. Do not check subtype, > * it is done in function that queued packet > */ > - int retval = rte_ring_dequeue(port->rx_ring, > + int retval = rte_ring_dequeue(port->tx_ring, > (void **)&lacp_pkt); > > if (retval != 0)