From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB2FD45CDF; Mon, 11 Nov 2024 01:14:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32E254027C; Mon, 11 Nov 2024 01:14:41 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2044.outbound.protection.outlook.com [40.107.236.44]) by mails.dpdk.org (Postfix) with ESMTP id 9B3AB40151 for ; Mon, 11 Nov 2024 01:14:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LqjXG6pp5HhKXUfE/zIoIFv9/kE1cwjzp7u7PgWUWubA8uC8vHSig/omdDBXBadqO2U4ulpxRdP9G93Ynjx8B/A8iWxXNVZPsFYCcjYPe80ljEf9AWJmIy6FuHoyIdcXntbjCpUKuJu6cPBcEV0m0iEtzAHgPC8Vh3JfsecmHk+PMr7E1ccPbYbSOW/rbTLkgLsXIqhSLiug+KPk7cLS6ZY/NDnANVPo1J8yIBmCGFYOSjmBI/tv0MtC96/zxii9tyPEQ4kyrwM26xcqmMnzgqBKE8Dpohwezks+943mkP+lTmqCXFeuuFliJtnbMseex0Tio2S0IDdMvgWMAgNL0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f1XxGlzLFB0sOQIBZdPTRoQEuwq1U6JB83Hr6d/b/TE=; b=Cp6/ljfJg4SpA233+m6TXIHkDkjAnm/STs6deOuL8ImMhHvuQikbe1XVsoJg7894B86VaXKmcPmYhphpuc0/GfRwg2K7w5N2jWu2DGyefA2Bjmswr1f5kvaJ1p7JoUjbPR3/OTxaC/zuokZ+8m0WZBS+sTmdNLB3NUFU/wLbXv3WE+J8tXjCIcGhp6l0ULx0ucTac0db4GPh5ZAbMLHpG3IQZn7b4pcRjvGcBOPv1UmOc31W0AhrCpZFsIaemzF7kZk3r8dtBEtzsCL7eECXO/PQSOU7XBkuKCKpN/g3ML+wCSMhfYckDjPtUqepegYebwlBDN3CNGO6+Vh8BemD9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f1XxGlzLFB0sOQIBZdPTRoQEuwq1U6JB83Hr6d/b/TE=; b=vfjXhr/o4i9xaBxd8CYycZOieHjt3f0NhvBVPbwl24PRorEQ8BKworBmsuwYttFXQmkmzSdjv8K0enezcCQ64fpdx0A7GiUYm2En/wxJ+SCkNiJd1OvX72vU5fCjQZ0w6YalL7JLqjU+N0h8nwqY3wmpbMHLpZN4HbvLFwdEhtU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by LV8PR12MB9264.namprd12.prod.outlook.com (2603:10b6:408:1e8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.26; Mon, 11 Nov 2024 00:14:36 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%3]) with mapi id 15.20.8137.027; Mon, 11 Nov 2024 00:14:36 +0000 Message-ID: Date: Mon, 11 Nov 2024 00:14:31 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 01/17] net/r8169: add PMD driver skeleton To: Howard Wang , dev@dpdk.org Cc: pro_nic_dpdk@realtek.com References: <20241108121123.248797-1-howard_wang@realsil.com.cn> <20241108121123.248797-2-howard_wang@realsil.com.cn> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20241108121123.248797-2-howard_wang@realsil.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0020.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::32) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|LV8PR12MB9264:EE_ X-MS-Office365-Filtering-Correlation-Id: 7050b67b-24e0-4d8e-c125-08dd01e5d336 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?N01FYytTRXErSUxEV0xBNGw0dHZtUlJEczhTdUdMa0FDSkdDVk9UaXptSklG?= =?utf-8?B?cVlyTEZHdjZZaTJRNHpvenNlSlZiTzFsRFZyWVBjemlpODRiVDVtSE84aU5T?= =?utf-8?B?K01zZVp0NzNyOUZhR1ViOVptd3VwR29VQzJMNXZ5cnR4TjBRNVl4dURUdno2?= =?utf-8?B?NGM1TCtnTk5qTGJpZUhrd0lUMzJ4WTVsOUZpQWdPbDZiR2swcWU0elBoMyts?= =?utf-8?B?d05EZ1NLNmQ1N2lhclQvN3R1UU8xVHZzOFk3MXhwOUt0dzlkSkJYZngvMzJw?= =?utf-8?B?UHBKYmw1eFRWSTVwd21KVGN2aEF4U1pFWFd4V21DUWJEMFdGa3JyV2pyUENu?= =?utf-8?B?d0xrZHF3M2grRjRBcGMxcGVldmw1ZUpGT0xnL2FmdENZRkFlUTI4bG9vS3hi?= =?utf-8?B?WWN1UVlBWDB0VVUyNXdHMkxFZndxbWUwYjNCSGV2TDhFVzVrYUFFNEhSRkRx?= =?utf-8?B?Q29ZYjgzWER0ZFFzZ3BKTGVSanlXbzNpRlFWQWhXQ0VSTkozaEVpTk91WSsy?= =?utf-8?B?MXJ6OE5QS2RobFVnalFoVUoxSEloYUc3MW9PdEdGVURwVHZ2TG1nbVZRYVJS?= =?utf-8?B?Yk1hSXFYYXNzdmRBQk9rRG05RkFMTW1HUlp4UVd3cmtzZnNGUzF4U3lXTWFG?= =?utf-8?B?ZHNhL3N3aWd3TzlqblR2SGZuZnZHMnlrOWF6KytqdHA1NnYwQ2dISXZlUnJl?= =?utf-8?B?d2JjV0k3TGlCZUxldXVHUFFTM2NoZmFPRlFjZFpLTURubjg3REhiNVV0UHRD?= =?utf-8?B?a09EUXZHVkNETWwyL2NmRk1xTTlZUWh1dEp5eFpvQXROOVJmaG5hblhxS1p0?= =?utf-8?B?U1JNR1JwZmZGMWtsMlFnSDlGNENhMTdjUzdUaXlwVndZMmg3WnptaG0wRkMy?= =?utf-8?B?QzF3NU1uQUhpRzV6cmd4bk0rUjNhZ1krVXk2ZEgwWEpaRW8wY1BndEZHK09t?= =?utf-8?B?SERVSWswVGlVWFlwcDNELys5RmpRc0dKTWllZ2pZTzA3bGc4YTZ2bUhQcGtB?= =?utf-8?B?NzVvN0t6R2FNNmZsMFBVdVBndCtrbytzQ0c4U3ZhaHZ5V0tmeGt0WHRpdUp5?= =?utf-8?B?c25oK1dlcXFVTFRCRk9TY1IxcEF3Rk05SU1nMTZ5U0hHYlJOeVcwT2dSMHdY?= =?utf-8?B?UDBXZDZTUVVad2gwTVBGMWN0RmJZeWZPdzRnWWlEWDdHWkp0MkdGNzl6cDRo?= =?utf-8?B?QktyRDRITkYyWDhRVWVwT3BNYjhLV3ozYm45aEg1UzkzLzNpck5QUmxIejRn?= =?utf-8?B?Tmh2SzZLYUtVMmZVUkcrMXB4QXJDR0twZVpTOGRpOHFlWkRSbGZ3K25FbTla?= =?utf-8?B?MmNxQmJaZjRxVFdJN2luc25jaHJTaHowQ2hyK3JIaEczSzZidDhaQlRjWFNR?= =?utf-8?B?U0lNZWdyL0tNdE9uR0pKeGc5YnVBTjhBdk52aWk1U3VpV3pQVFRqa2p1QXhM?= =?utf-8?B?QTNxaFpBZEZxWXNxUEJ0WTkzbDdQL0tDblRzQ1JERVgzMVZDeHNraFpKNGlv?= =?utf-8?B?enk4MU93aEFHNnh2WmRqQVpBaHRRWE5aYVREejRTMTgzcStSbTRyTjRCNGZh?= =?utf-8?B?a0dKZXNJbWJ0OGorUHlrdXNINGQ0NVlTNDM0aU1neFAxeEVieVA3Z0ZzbGNF?= =?utf-8?B?WFlTRlkvRUJRTU5zd2syZXZ3VHU4M0VSU2diZlVYemZKdHpob3NERHhFbTY5?= =?utf-8?B?RENGZUNXT3gzSU45ejNWOS9kRUY5d3YwRkZoaTdOLzdnYVhXY1RKV0E1ZUw0?= =?utf-8?Q?GgVkiTg17vN9pFi8L1tIbE/sA7UBSw4FoRi5S9k?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHdHcWErcDF3ZW5wZkk2TDFOYklNM2VmVWpxbTNzQ1V5aTYwbDYzcmsyeXJL?= =?utf-8?B?NmcxK3pwZW5TQ1FVZkFHVld6aUIrR0lyWGxUZWJ6dno4Nk1NcDlyNEVjSm1p?= =?utf-8?B?cjg4cHZ2ZjZRQXZuSHIzVStxeDNYSEdQWFliU3BsdGtydXlCTlBDL3kzWVN2?= =?utf-8?B?Rlh6MkQrNk55KzNFSU5SL1drYXhpc2pRNHpFVVpteFZkNitPZUxWODRVUG8v?= =?utf-8?B?elpOVitwUlc4UGc1QzZROHJZOUVKbHlRQVlFUU5QWDQ4WFZIM1ZUS1NQUnFE?= =?utf-8?B?ajRXZE1oMmEzak55aWhIREdUcjVta1NLZFFidlUrRG9iQUYwYjRaNlhKOFBl?= =?utf-8?B?TEorRmxvdEpMbjBJVURBRGpIK1J1cmE1anVlVUJ1b2d2WWJsemJzcmhpUjFI?= =?utf-8?B?OTNPeDNYWlNXL2ZWK2lZV1c5WlIweHF5dlUxRWdHRHhKZVhmZlBMUHFRYzBD?= =?utf-8?B?K2Z2WUtsak4vZjBOK0RDbkREbEw2VWdyU3NtUkdySUhjb2tJckNnc3BxOEw1?= =?utf-8?B?aVd3SlpaY3Q4S1VndmJmTlg2V0o0bTJvbzZneXRXMFp2UXQ3UkJwNTZtQ3Ft?= =?utf-8?B?Zm9jVW8rTW9QckRMRnQ0blU2c0J0azg0VTB6T3JGY3JCSmRCNDZHcmtyaUFQ?= =?utf-8?B?VDdiN052TCtOV2FWWER0MzloR2pySWo0dDZFOElSMEpTTVJncXM4TG90ZDhG?= =?utf-8?B?NmpGNVpDNHVNbENLN3hSSEEwcGxYZjRLM28yUHc2QjhhbXlLd215djdBaXo5?= =?utf-8?B?dFZPQ2FxQWVFcHJiWkNUVngxb0RleXZWM0FCbzMzbzlHWjNkblpkWFJIYml3?= =?utf-8?B?cWIvWjR2eFJEZXR2VDNjQlVnN1EyT3VmL1hkdkZhUmIwYzNrdmRhQWhiWWpD?= =?utf-8?B?TGg0L050YXFIUzNWUGhlSXFlR2p6cStmbFRlYjFxcDlGOXluaFkvWXlsRjlI?= =?utf-8?B?V2lFOHp6Um40KzJKM0hpdlIxT0NKczBIODRyWU5lblpYWWoza0dIbTlyaStx?= =?utf-8?B?VmRDT2pkTHArK25ESnlWZTdTQWRaNmEyNXFmZVpoejgxdDUwdHNaSGNUWXZ6?= =?utf-8?B?cjdyb2EwK1BZRkhEQ3NRSU5wY1k3b2I3S2hjdWlXVEF1eEhRWGUweHdBeThn?= =?utf-8?B?WUpTMFRZb3N2UlUwYldxWUpENXR1Q2NOa3pPaXY1VFZsZUxJUlp0TUEyNG1r?= =?utf-8?B?L3QrY3NQOHhDOG5sempzcnF2c0ZZS2dlNXc2ZHF6M1ZMVS91VEFpSlJRdFVt?= =?utf-8?B?WWd2V1A1ajljci9TYUFKS0I4bnF6dzZsaDYrNGE4S3Nnc1dSSzRRNHp5eXlr?= =?utf-8?B?RFR4QnVWVDdSM2d6OUo5U3BmMVJ5NVlkMG0xdUtWMCtVRTJKMUxRSW5weWlu?= =?utf-8?B?L0xYV0JRdURHR0pEVzZIanI0alpTUDZqQ1hQYjNZeW1iUkdBdW1JcW91YldD?= =?utf-8?B?ZHJjTnZXemN3L0FZak83UDNmYkxkYVI5Tk50UVQ5eGREV0FSM0tEOXVXUDQx?= =?utf-8?B?TjhrOHZCSUJSM0RTTGIrczk0dUtyOEVtVkZNcXQzQnl2dVlKSEc2ZWFIWDVF?= =?utf-8?B?MTE5UVJSc0hrNGR6c3RZTnFNWUVzZHhaR0NTWmJGaXRkQ1VsQWxZaVRvdW5B?= =?utf-8?B?SDRoSzgwN05vMmFkTUMrUm9lUmpTTUlLOHZyWTI3eVFiQWYyek42VWFZV0tH?= =?utf-8?B?UXJOeUFzUVJvU2JQcE1td2tjanh0dkZla1Z1bitlTXcwaVNQeEhDMFFlZjJq?= =?utf-8?B?VU5uOHRRUnViU1E4QlhLeC9TVWtqZ3dLalFzWU0wNXpGSFptVXU4aVVpc2Q0?= =?utf-8?B?YVZzN2RXRnF0SUxUcktNYmxSd29rdkxYMHNlZ3FxdmpUQzEyUlFjTHc5UXFT?= =?utf-8?B?SGlvOUpWSUNnWmlMNmhoTnNFMEVjb0Y5a3NVNWhGZ1FZSmo3b0hEdHltcEw2?= =?utf-8?B?SElRR1VtZXlNQ3dya3Q0dHpIV21yU2pMODZHYWFLNlJ4OWNIRmdLZHJiRXFy?= =?utf-8?B?L1BGMXl6UGovUjNWZy9lZS85WGpTMWtTVEt6bnZhUFZibFIrTldvR1BTdXBh?= =?utf-8?B?VEpKdGhNK0VkdFNTdzNZZDdnN01HT2RxTWxSbDY5M3dHUFNiUUxEOVhjL2pC?= =?utf-8?Q?3m7590mGQShFclRmHGS3UQYtG?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7050b67b-24e0-4d8e-c125-08dd01e5d336 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 00:14:36.0344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r/P1QAGvh4tg2MZh26v1iXYzsZ1qP/0aZtG1mBotr+bIKkpycgJlAcw4GxfkcTJJ X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9264 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/8/2024 12:11 PM, Howard Wang wrote: > Meson build infrastructure, r8169_ethdev minimal skeleton, > header with Realtek NIC device and vendor IDs. > > Signed-off-by: Howard Wang <...> > +/* > + * The set of PCI devices this driver supports > + */ > +static const struct rte_pci_id pci_id_r8169_map[] = { > + { RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8125) }, > + { RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8162) }, > + { RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8126) }, > + { RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x5000) }, > What do you think to add macros for the PCI device IDs, naming them makes it easier to know which devices are supported. <...> > + > +#define RTL_DEV_PRIVATE(eth_dev) \ > + ((struct rtl_adapter *)((eth_dev)->data->dev_private)) > + > This macro is only used a few patches later, what do you think to add this macro when used?