From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6ACD6A0471 for ; Fri, 19 Jul 2019 17:42:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4331C2C2B; Fri, 19 Jul 2019 17:42:43 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 0ECD12C17 for ; Fri, 19 Jul 2019 17:42:42 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 8145280075; Fri, 19 Jul 2019 15:42:40 +0000 (UTC) Received: from [192.168.1.11] (85.187.13.152) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 19 Jul 2019 16:42:33 +0100 To: Olivier Matz , Vamsi Krishna Attunuru , CC: Thomas Monjalon , Anatoly Burakov , Jerin Jacob Kollanukkaran , Kokkilagadda , Ferruh Yigit References: <20190719133845.32432-1-olivier.matz@6wind.com> <20190719133845.32432-2-olivier.matz@6wind.com> From: Andrew Rybchenko Message-ID: Date: Fri, 19 Jul 2019 18:42:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190719133845.32432-2-olivier.matz@6wind.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [85.187.13.152] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24776.000 X-TM-AS-Result: No-0.618100-8.000000-10 X-TMASE-MatchedRID: lORh06tOiKjmLzc6AOD8DfHkpkyUphL9y0Q+dW8+UWTg91xayX4L86QE EHwgB7x69H2sAtRgdiCJ7KpnKzsb3duIUha4/hqvngIgpj8eDcC063Wh9WVqgmWCfbzydb0g1Ao zErC5dcfkwjHXXC/4I7I7zVffJqTzg6BJePffrFshPgGsUQF4cjvn0P77MrkLjtHmjN4bJhat8o nrIyfXBdQ17CngTb9OBKmZVgZCVnezGTWRXUlrx+EijnvekEIH X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--0.618100-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24776.000 X-MDID: 1563550961-dqTbUn1GATtE Subject: Re: [dpdk-dev] [RFC 1/4] mempool: clarify default populate function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/19/19 4:38 PM, Olivier Matz wrote: > No functional change. Clarify the populate function to make > the next commit easier to understand. > > Rename the variables: > - to avoid negation in the name > - to have more understandable names > > Remove useless variable (no_pageshift is equivalent to pg_sz == 0). > > Remove duplicate affectation of "external" variable. > > Signed-off-by: Olivier Matz LGTM Reviewed-by: Andrew Rybchenko