From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: Rongwei Liu <rongweil@nvidia.com>
Cc: <dev@dpdk.org>, <matan@nvidia.com>, <viacheslavo@nvidia.com>,
<orika@nvidia.com>, <suanmingm@nvidia.com>, <thomas@monjalon.net>,
<getelson@nvidia.com>, <stable@dpdk.org>,
Bing Zhao <bingz@nvidia.com>
Subject: Re: [PATCH v1] net/mlx5: fix job leak on indirect meter creation failure
Date: Fri, 9 Jan 2026 18:43:15 +0100 [thread overview]
Message-ID: <ezowyzibcbouoq7njhnqqun27fjrsskdcjcve3npxcrsnoremg@yiyp2p6miwef> (raw)
In-Reply-To: <20251208101203.315647-1-rongweil@nvidia.com>
On Mon, Dec 08, 2025 at 12:12:03PM +0200, Rongwei Liu wrote:
> Indirect meter_mark action needs to allocate a job to track
> asynchronous HW operation to create the meter object.
>
> When meter_mark creation failed, the job may have been leaked
> because there was no job cleanup code for sync API.
>
> Add necessary code to check if meter_mark creation failed before or
> after HW operation is enqueued and call job_put accordingly.
>
> Fixes: 4359d9d1f76b ("net/mlx5: fix sync meter processing in HWS")
> Cc: getelson@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
Best regards,
Dariusz Sosnowski
prev parent reply other threads:[~2026-01-09 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 10:12 Rongwei Liu
2025-12-19 22:02 ` Patrick Robb
2026-01-09 17:43 ` Dariusz Sosnowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ezowyzibcbouoq7njhnqqun27fjrsskdcjcve3npxcrsnoremg@yiyp2p6miwef \
--to=dsosnowski@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rongweil@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).