From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A0E7BA04EF;
	Mon,  1 Jun 2020 03:35:16 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id D6E4E1D37F;
	Mon,  1 Jun 2020 03:35:15 +0200 (CEST)
Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35])
 by dpdk.org (Postfix) with ESMTP id 2E34F2F42
 for <dev@dpdk.org>; Mon,  1 Jun 2020 03:35:14 +0200 (CEST)
Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.60])
 by Forcepoint Email with ESMTP id 1579B7F65ECF20B510C8
 for <dev@dpdk.org>; Mon,  1 Jun 2020 09:31:50 +0800 (CST)
Received: from [127.0.0.1] (10.67.103.119) by DGGEMS410-HUB.china.huawei.com
 (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Mon, 1 Jun 2020
 09:31:45 +0800
To: Ferruh Yigit <ferruh.yigit@intel.com>, "Burakov, Anatoly"
 <anatoly.burakov@intel.com>
CC: dev <dev@dpdk.org>
From: oulijun <oulijun@huawei.com>
Message-ID: <f00687fe-61e0-0e2a-6cb3-144ed92b1862@huawei.com>
Date: Mon, 1 Jun 2020 09:31:45 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.103.119]
X-CFilter-Loop: Reflected
Subject: [dpdk-dev] Questions Questions about hash function enum
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh Yigit and others

    I am learning data structure defined by dpdk framework and I noticed 
a data structure definition below:

enum rte_eth_hash_function {
     RTE_ETH_HASH_FUNCTION_DEFAULT = 0,
     RTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */
     RTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */
     /**
      * Symmetric Toeplitz: src, dst will be replaced by
      * xor(src, dst). For the case with src/dst only,
      * src or dst address will xor with zero pair.
      */
     RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
     RTE_ETH_HASH_FUNCTION_MAX,
};

I have a little difficulty understanding that for the comment:

    /**
      * Symmetric Toeplitz: src, dst will be replaced by
      * xor(src, dst). For the case with src/dst only,
      * src or dst address will xor with zero pair.
      */

if user configure rss func for symmetric toeplitz, Rss type must be 
updated at the same time?

if user configure rss func for xor, rss type must be empty and the queue 
number is zero?

Must it be restricted like this? If so, what is his benefit?

Looking forward to your reply


Thanks

Lijun Ou