Re: [dpdk-dev] [PATCH] eventdev: prefix global variable

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 10/3/2018 2:48 PM, Ferruh Yigit wrote:
> A global defined with name "stats".
> 
> DPDK is a library, please don't define global variables with this
> generic name.
> 
> Fixes: b1ce8ebd97ba ("eventdev: add PMD callbacks for eth Rx adapter")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> There are already questions about that "stats" variable:
> - Why a global variable defined in header file?
> - It seems it is not used at all, remove it?
>   Forgotten to be removed in below commit, but because of generic
>   "stats" name, it didn't cause any compile error but happily used
>   global variable
>   Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter")
> 
> But this patch mainly sent as an RFC, to ask what would you think about
> a cleanup patch to add the library prefix for all the global variables
> that are defined in libries? (yes we have lots of them)
> 
> Like:
> zip_cc --> octeontx_zip_cc [1]
> valid_args --> qede_valid_args [2]
> scheduler --> crypto_scheduler [3]

The cleanup patch has been sent:
"fix static variables"
https://patches.dpdk.org/patch/46006/

This patch has been superseded by above one.