From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C58FBA0544;
	Wed,  1 Jun 2022 19:49:31 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7938840689;
	Wed,  1 Jun 2022 19:49:31 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id EB73E4003F
 for <dev@dpdk.org>; Wed,  1 Jun 2022 19:49:29 +0200 (CEST)
Received: from [192.168.1.126] (unknown [188.242.181.57])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 5E609AF;
 Wed,  1 Jun 2022 20:49:29 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 5E609AF
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1654105769;
 bh=OdYL7lhtPCz3rE7Qu6WvuzKHxiZaXCCENG8SBWAWqyc=;
 h=Date:Subject:To:References:Cc:From:In-Reply-To:From;
 b=HF7mXGMl/MdM2xqpURXkmSF+kkYzfYo8hxlmPz2ZuKGe93DwLWQUEBM71yT8+YXlT
 GrNKzdjjaoK07zW3ypBsr0Q7g28WHLRhMilzdeuf+3ngMP9+AHY1JbvYz6fcGV1wXU
 DS3VC9lhtX5wdlfoXqCFo96GCb7faO7sfrbUxbvs=
Message-ID: <f02166e8-7cda-b406-5b7b-90cb9e5a7c0e@oktetlabs.ru>
Date: Wed, 1 Jun 2022 20:49:22 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v4 0/2] ethdev: fix MAC addrs list
Content-Language: en-US
To: "Min Hu (Connor)" <humin29@huawei.com>, dev@dpdk.org
References: <20220514020049.57294-1-humin29@huawei.com>
 <20220601063949.43202-1-humin29@huawei.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
 Ferruh Yigit <ferruh.yigit@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <20220601063949.43202-1-humin29@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 6/1/22 09:39, Min Hu (Connor) wrote:
> The index zero of rte_eth_dev_data::mac_addrs array is as the default MAC
> index, and other indexes can't be the same as the address corresponding to
> index 0. If we break it, may cause following problems:
> 1) waste of MAC address spaces.
> 2) a fake MAC address in the MAC list, isn't in hardware MAC entries.
> 3) a MAC address is assigned to diffent pool.
> 
> Huisong Li (2):
>    ethdev: fix one address occupies two indexes in MAC addrs
>    ethdev: document default and non-default MAC address
> ---
> v4:
>    - fix broken in the patchwork
> 
> v3:
>    - first explicitly remove the non-default MAC, then set default one.
>    - document default and non-default MAC address
> 
> v2:
>    - fixed commit log.
> 
>   lib/ethdev/ethdev_driver.h |  7 ++++++-
>   lib/ethdev/rte_ethdev.c    | 39 ++++++++++++++++++++++++++++++++++++--
>   2 files changed, 43 insertions(+), 3 deletions(-)
> 

Please, don't forget to add maintainers in Cc when you send patches.
   --cc-cmd ./devtools/get-maintainers.sh
or
   --to-cmd ./devtools/get-maintainers.sh
(I'd prefer To and have dev@dpdk.org in Cc)

Don't worry about it right now. I'll add Thomas and Ferrh in my replies.