From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28700A04FA; Wed, 5 Feb 2020 13:51:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0F0991C1C7; Wed, 5 Feb 2020 13:51:05 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 768401C1A6 for ; Wed, 5 Feb 2020 13:51:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580907062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NBgpqzYTt76cPObabY39Lkjr1E+Z7xNkl2kHvcdQfZs=; b=B9SJAoLgDqh9b+2oYLUaRINkLYjEjdHRJ+0WhrWoWKN/5Ic4RKr1i8BPKhOE0Etzf3HXxJ G4x98ge58MrrEX+1eKspi47aeYsN05iVJV1iRw2ClhliTr3HO3hSoKYATEOGQmWUJlNYjE /oBILSLTbFzczG9zQl2AsRsyfTOiZiU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374-mEFKBy19OfSwSSSKnULggg-1; Wed, 05 Feb 2020 07:50:58 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3E7DF801A03; Wed, 5 Feb 2020 12:50:57 +0000 (UTC) Received: from aldebaran.drizzt.lan (dhcp19-189-71.ntdv.lab.eng.bos.redhat.com [10.19.189.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id 19D7D790C0; Wed, 5 Feb 2020 12:50:55 +0000 (UTC) From: Timothy Redaelli To: dev@dpdk.org Cc: anoobj@marvell.com, stable@dpdk.org Date: Wed, 5 Feb 2020 13:50:41 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: mEFKBy19OfSwSSSKnULggg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-dev] [PATCH 1/3] crypto/octeontx2: fix building with GCC 10 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: 2f8a1b963eb7 ("crypto/octeontx2: add PMD skeleton") Cc: anoobj@marvell.com Cc: stable@dpdk.org Signed-off-by: Timothy Redaelli --- drivers/crypto/octeontx2/otx2_cryptodev.c | 2 ++ drivers/crypto/octeontx2/otx2_cryptodev.h | 2 +- drivers/crypto/octeontx2/otx2_cryptodev_ops.h | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c b/drivers/crypto/oct= eontx2/otx2_cryptodev.c index 7fd216bb3..957bcd720 100644 --- a/drivers/crypto/octeontx2/otx2_cryptodev.c +++ b/drivers/crypto/octeontx2/otx2_cryptodev.c @@ -24,6 +24,8 @@ =20 int otx2_cpt_logtype; =20 +uint8_t otx2_cryptodev_driver_id; + static struct rte_pci_id pci_id_cpt_table[] =3D { =09{ =09=09RTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.h b/drivers/crypto/oct= eontx2/otx2_cryptodev.h index 8e0ebc292..c0aa661b3 100644 --- a/drivers/crypto/octeontx2/otx2_cryptodev.h +++ b/drivers/crypto/octeontx2/otx2_cryptodev.h @@ -38,6 +38,6 @@ extern int otx2_cpt_logtype; /* * Crypto device driver ID */ -uint8_t otx2_cryptodev_driver_id; +extern uint8_t otx2_cryptodev_driver_id; =20 #endif /* _OTX2_CRYPTODEV_H_ */ diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_ops.h b/drivers/crypto= /octeontx2/otx2_cryptodev_ops.h index a2724f722..f83e36b48 100644 --- a/drivers/crypto/octeontx2/otx2_cryptodev_ops.h +++ b/drivers/crypto/octeontx2/otx2_cryptodev_ops.h @@ -16,6 +16,6 @@ enum otx2_cpt_egrp { =09OTX2_CPT_EGRP_AE =3D 2 }; =20 -struct rte_cryptodev_ops otx2_cpt_ops; +extern struct rte_cryptodev_ops otx2_cpt_ops; =20 #endif /* _OTX2_CRYPTODEV_OPS_H_ */ --=20 2.24.1