From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Xiao Zhang <xiao.zhang@intel.com>, dev@dpdk.org
Cc: beilei.xing@intel.com, qi.z.zhang@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] net/i40e: add promiscuous configure unsupported check
Date: Mon, 2 Mar 2020 09:08:59 +0000 [thread overview]
Message-ID: <f02ad57b-e910-43f9-210d-374ed1197e6d@intel.com> (raw)
In-Reply-To: <1582860124-48237-1-git-send-email-xiao.zhang@intel.com>
On 2/28/2020 3:22 AM, Xiao Zhang wrote:
> Return ENOTSUP error code when configuring i40evf promiscuous mode to
> fix port start hang issue on platforms which are unsupported to configure
> promiscuous mode.
Hi Xiao,
What is the cause of the hang, was the application keep trying because of the
"-EAGAIN" error?
>
> Fixes: ddc7cb0d9453 ("net/i40e: re-program promiscuous mode on VF
> interface")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiao Zhang <xiao.zhang@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev_vf.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
> index c34f520..244397e 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -2191,6 +2191,8 @@ i40evf_dev_promiscuous_enable(struct rte_eth_dev *dev)
> ret = i40evf_config_promisc(dev, 1, vf->promisc_multicast_enabled);
> if (ret == 0)
> vf->promisc_unicast_enabled = TRUE;
> + else if (ret == I40E_NOT_SUPPORTED)
> + ret = -ENOTSUP;
> else
> ret = -EAGAIN;
>
> @@ -2206,6 +2208,8 @@ i40evf_dev_promiscuous_disable(struct rte_eth_dev *dev)
> ret = i40evf_config_promisc(dev, 0, vf->promisc_multicast_enabled);
> if (ret == 0)
> vf->promisc_unicast_enabled = FALSE;
> + else if (ret == I40E_NOT_SUPPORTED)
> + ret = -ENOTSUP;
> else
> ret = -EAGAIN;
>
> @@ -2221,6 +2225,8 @@ i40evf_dev_allmulticast_enable(struct rte_eth_dev *dev)
> ret = i40evf_config_promisc(dev, vf->promisc_unicast_enabled, 1);
> if (ret == 0)
> vf->promisc_multicast_enabled = TRUE;
> + else if (ret == I40E_NOT_SUPPORTED)
> + ret = -ENOTSUP;
> else
> ret = -EAGAIN;
>
> @@ -2236,6 +2242,8 @@ i40evf_dev_allmulticast_disable(struct rte_eth_dev *dev)
> ret = i40evf_config_promisc(dev, vf->promisc_unicast_enabled, 0);
> if (ret == 0)
> vf->promisc_multicast_enabled = FALSE;
> + else if (ret == I40E_NOT_SUPPORTED)
> + ret = -ENOTSUP;
> else
> ret = -EAGAIN;
>
>
next prev parent reply other threads:[~2020-03-02 9:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 3:22 Xiao Zhang
2020-03-02 2:20 ` Ye Xiaolong
2020-03-02 9:08 ` Ferruh Yigit [this message]
2020-03-03 2:01 ` Zhang, Xiao
2020-03-03 2:53 ` Ye Xiaolong
2020-03-03 2:59 ` Zhang, Xiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f02ad57b-e910-43f9-210d-374ed1197e6d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=xiao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).