From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2858A00C5; Thu, 4 Jun 2020 13:44:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 594051D5D0; Thu, 4 Jun 2020 13:44:35 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 60E0A1BE9B for ; Thu, 4 Jun 2020 13:44:33 +0200 (CEST) IronPort-SDR: oUYf1Qr9wEQu21131t9iQzAs1kSUdOFZ7WkvjY9hJp24F57bSHBTwKghVc30RGlh1HefBOWHHT h0guM7zHzrBg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2020 04:44:32 -0700 IronPort-SDR: kZKG7OntRrQvCNsOiOxJJBnLKUnpP4v0rwOkQoGsSNDTPOBZVrNH2LvQsAXyBzk3bWEsbDHo/k m9oLQitBN/sw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,472,1583222400"; d="scan'208";a="471502252" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.233.208]) ([10.213.233.208]) by fmsmga005.fm.intel.com with ESMTP; 04 Jun 2020 04:44:30 -0700 To: podovinnikov , Chas Williams , "Wei Hu (Xavier)" , "Wei Hu (Xavier)" Cc: dev@dpdk.org References: <20191125180323.E0B174C90@dpdk.org> <20191126115508.11138-1-podovinnikov@protei.ru> <906848bc-7411-79dd-0ee1-c0f3c5d1ff16@intel.com> <96d3e5ae-ad62-2f7d-c91f-e13d170d210d@intel.com> <2100656d-c4e1-1aed-8d7c-1e728371ea2a@intel.com> <02db28db-1bed-08d3-95ef-46ed787b6ca1@protei.ru> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: Date: Thu, 4 Jun 2020 12:44:30 +0100 MIME-Version: 1.0 In-Reply-To: <02db28db-1bed-08d3-95ef-46ed787b6ca1@protei.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] fix lacp check system address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/4/2020 8:52 AM, podovinnikov wrote: > Hi Ferruh! > > Unfortunately I didn't see any patch from this link > > https://patchwork.dpdk.org/user/todo/dpdk/?series=8679 It is archived, there is a new version of that patchset, can you please check it: https://patches.dpdk.org/project/dpdk/list/?series=9456 Thanks, ferruh > > 10.04.2020 13:24, Ferruh Yigit пишет: >> On 4/10/2020 11:21 AM, Ferruh Yigit wrote: >>> On 4/10/2020 11:15 AM, Ferruh Yigit wrote: >>>> On 11/26/2019 3:09 PM, podovinnikov wrote: >>>>> Hi Ferruh >>>>> >>>>>> This is bonding patch, please cc bonding maintainers (Chas, instead of John W. >>>>>> Linville). >>>>> Sorry about that. I have 2 patches ( one for af packet, one for bonding). >>>>> >>>>> I am a little confused. >>>>> >>>>> >>>>>> Can you please give more details, what is failing what is the impact etc. >>>>> In bond (lacp) we have several nics ( ports ) >>>>> >>>>> When we have negotiation with peer about what port we prefer, >>>>> >>>>> we send information about what system we preferred in partner system >>>>> name field. >>>>> >>>>> Peer also sends us what partner system name it prefer. >>>>> >>>>> When we receive a message from it we must compare its preferred >>>>> >>>>> system name with our system name, but not with our port mac address >>>>> >>>>> In my test I have several problems with that >>>>> >>>>> 1. If master port (mac address same as system address) >>>>> >>>>> shuts down (I have two ports) I loose connection >>>>> >>>>> 2. If secondary port (mac address not same as system address) >>>>> >>>>> receives message before master port, my connection is not established. >>>> Hi Vadim, >>>> >>>> Thanks for the info and sorry for late response, it is sitting in backlog for a >>>> long time now. >>>> >>>> @Chas, do you have any objection on the fix, if not I am planning to merge it soon. >>>> >>>> Thanks, >>>> ferruh >>> cc'ed Xavier, he also has a bonding patch in the backlog waiting for review [1]. >>> >>> >>> Vadim, Xavier, >>> >>> Since you both send bonding patches, I assume you both know about bonding at >>> some level, at least more than me, so would you mind reviewing eachother's >>> patch? So both can go it. >> + other email address of the Xavier. >> >>> Thanks, >>> ferruh >>> >>> >>> [1] >>> https://patchwork.dpdk.org/user/todo/dpdk/?series=8679 >>> >>>>> >>>>> 26.11.2019 16:27, Ferruh Yigit пишет: >>>>>> Hi Vadim, >>>>>> >>>>>> On 11/26/2019 11:55 AM, Vadim wrote: >>>>>>> Signed-off-by: Vadim >>>>>> Can you please provide full "Name Surname " signature? >>>>>> >>>>>> >>>>>> This is bonding patch, please cc bonding maintainers (Chas, instead of John W. >>>>>> Linville). >>>>>> >>>>>>> fix lacp check system address >>>>>> Can you please give more details, what is failing what is the impact etc. >>>>>> >>>>>>> --- >>>>>>> drivers/net/bonding/rte_eth_bond_8023ad.c | 17 ++++++++++++++++- >>>>>>> 1 file changed, 16 insertions(+), 1 deletion(-) >>>>>>> >>>>>>> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c >>>>>>> index b77a37ddb..d4dda790a 100644 >>>>>>> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c >>>>>>> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c >>>>>>> @@ -792,18 +792,33 @@ rx_machine_update(struct bond_dev_private *internals, uint16_t slave_id, >>>>>>> struct rte_mbuf *lacp_pkt) { >>>>>>> struct lacpdu_header *lacp; >>>>>>> struct lacpdu_actor_partner_params *partner; >>>>>>> + struct port *port, *agg; >>>>>>> >>>>>>> if (lacp_pkt != NULL) { >>>>>>> lacp = rte_pktmbuf_mtod(lacp_pkt, struct lacpdu_header *); >>>>>>> RTE_ASSERT(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP); >>>>>>> >>>>>>> partner = &lacp->lacpdu.partner; >>>>>>> + port = &bond_mode_8023ad_ports[slave_id]; >>>>>>> + agg = &bond_mode_8023ad_ports[port->aggregator_port_id]; >>>>>>> + >>>>>>> if (rte_is_same_ether_addr(&partner->port_params.system, >>>>>>> - &internals->mode4.mac_addr)) { >>>>>>> + &agg->actor.system)) { >>>>>>> /* This LACP frame is sending to the bonding port >>>>>>> * so pass it to rx_machine. >>>>>>> */ >>>>>>> rx_machine(internals, slave_id, &lacp->lacpdu); >>>>>>> + } else { >>>>>>> + char preferred_system_name[RTE_ETHER_ADDR_FMT_SIZE]; >>>>>>> + char self_system_name[RTE_ETHER_ADDR_FMT_SIZE]; >>>>>>> + rte_ether_format_addr(preferred_system_name, >>>>>>> + RTE_ETHER_ADDR_FMT_SIZE, >>>>>>> + &partner->port_params.system); >>>>>>> + rte_ether_format_addr(self_system_name, >>>>>>> + RTE_ETHER_ADDR_FMT_SIZE, &agg->actor.system); >>>>>>> + MODE4_DEBUG("preferred partner system %s not equal " >>>>>>> + "self system: %s\n", >>>>>>> + preferred_system_name, self_system_name); >>>>>>> } >>>>>>> rte_pktmbuf_free(lacp_pkt); >>>>>>> } else >>>>>>>