* [PATCH] app/testpmd: remove jumbo offload related code
@ 2022-10-17 9:05 Chengwen Feng
2022-10-20 7:21 ` Andrew Rybchenko
0 siblings, 1 reply; 2+ messages in thread
From: Chengwen Feng @ 2022-10-17 9:05 UTC (permalink / raw)
To: thomas, ferruh.yigit; +Cc: dev, aman.deep.singh, yuying.zhang
The jumbo offload was removed from patch [1], but testpmd still exist
jumbo offload related code, this patch removes it, and also updates
the rst file.
[1] ethdev: remove jumbo offload flag
Fixes: b563c1421282 ("ethdev: remove jumbo offload flag")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
app/test-pmd/cmdline.c | 12 ++++++------
app/test-pmd/testpmd.h | 1 -
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 ++++----
3 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 17be2de402..0667869a4d 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -714,7 +714,7 @@ static void cmd_help_long_parsed(void *parsed_result,
"port config <port_id> rx_offload vlan_strip|"
"ipv4_cksum|udp_cksum|tcp_cksum|tcp_lro|qinq_strip|"
"outer_ipv4_cksum|macsec_strip|"
- "vlan_filter|vlan_extend|jumbo_frame|scatter|"
+ "vlan_filter|vlan_extend|scatter|"
"buffer_split|timestamp|security|keep_crc on|off\n"
" Enable or disable a per port Rx offloading"
" on all Rx queues of a port\n\n"
@@ -722,7 +722,7 @@ static void cmd_help_long_parsed(void *parsed_result,
"port (port_id) rxq (queue_id) rx_offload vlan_strip|"
"ipv4_cksum|udp_cksum|tcp_cksum|tcp_lro|qinq_strip|"
"outer_ipv4_cksum|macsec_strip|"
- "vlan_filter|vlan_extend|jumbo_frame|scatter|"
+ "vlan_filter|vlan_extend|scatter|"
"buffer_split|timestamp|security|keep_crc on|off\n"
" Enable or disable a per queue Rx offloading"
" only on a specific Rx queue\n\n"
@@ -10960,7 +10960,7 @@ static cmdline_parse_token_string_t cmd_config_per_port_rx_offload_result_offloa
(struct cmd_config_per_port_rx_offload_result,
offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#"
"qinq_strip#outer_ipv4_cksum#macsec_strip#"
- "vlan_filter#vlan_extend#jumbo_frame#"
+ "vlan_filter#vlan_extend#"
"scatter#buffer_split#timestamp#security#"
"keep_crc#rss_hash");
static cmdline_parse_token_string_t cmd_config_per_port_rx_offload_result_on_off =
@@ -11043,7 +11043,7 @@ static cmdline_parse_inst_t cmd_config_per_port_rx_offload = {
.help_str = "port config <port_id> rx_offload vlan_strip|ipv4_cksum|"
"udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|"
"macsec_strip|vlan_filter|vlan_extend|"
- "jumbo_frame|scatter|buffer_split|timestamp|security|"
+ "scatter|buffer_split|timestamp|security|"
"keep_crc|rss_hash on|off",
.tokens = {
(void *)&cmd_config_per_port_rx_offload_result_port,
@@ -11092,7 +11092,7 @@ static cmdline_parse_token_string_t cmd_config_per_queue_rx_offload_result_offlo
(struct cmd_config_per_queue_rx_offload_result,
offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#"
"qinq_strip#outer_ipv4_cksum#macsec_strip#"
- "vlan_filter#vlan_extend#jumbo_frame#"
+ "vlan_filter#vlan_extend#"
"scatter#buffer_split#timestamp#security#keep_crc");
static cmdline_parse_token_string_t cmd_config_per_queue_rx_offload_result_on_off =
TOKEN_STRING_INITIALIZER
@@ -11151,7 +11151,7 @@ static cmdline_parse_inst_t cmd_config_per_queue_rx_offload = {
"vlan_strip|ipv4_cksum|"
"udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|"
"macsec_strip|vlan_filter|vlan_extend|"
- "jumbo_frame|scatter|buffer_split|timestamp|security|"
+ "scatter|buffer_split|timestamp|security|"
"keep_crc on|off",
.tokens = {
(void *)&cmd_config_per_queue_rx_offload_result_port,
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index e65be323b8..a9dbefd69b 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -1150,7 +1150,6 @@ uint16_t tx_pkt_set_dynf(uint16_t port_id, __rte_unused uint16_t queue,
void add_tx_dynf_callback(portid_t portid);
void remove_tx_dynf_callback(portid_t portid);
int update_mtu_from_frame_size(portid_t portid, uint32_t max_rx_pktlen);
-int update_jumbo_frame_offload(portid_t portid);
void flex_item_create(portid_t port_id, uint16_t flex_id, const char *filename);
void flex_item_destroy(portid_t port_id, uint16_t flex_id);
void port_flex_item_flush(portid_t port_id);
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index b3f31df69a..d0fe73dff6 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -1553,8 +1553,8 @@ Enable or disable a per port Rx offloading on all Rx queues of a port::
* ``offloading``: can be any of these offloading capability:
vlan_strip, ipv4_cksum, udp_cksum, tcp_cksum, tcp_lro,
qinq_strip, outer_ipv4_cksum, macsec_strip,
- vlan_filter, vlan_extend, jumbo_frame,
- scatter, timestamp, security, keep_crc, rss_hash
+ vlan_filter, vlan_extend, scatter, timestamp, security,
+ keep_crc, rss_hash
This command should be run when the port is stopped, or else it will fail.
@@ -1568,8 +1568,8 @@ Enable or disable a per queue Rx offloading only on a specific Rx queue::
* ``offloading``: can be any of these offloading capability:
vlan_strip, ipv4_cksum, udp_cksum, tcp_cksum, tcp_lro,
qinq_strip, outer_ipv4_cksum, macsec_strip,
- vlan_filter, vlan_extend, jumbo_frame,
- scatter, timestamp, security, keep_crc
+ vlan_filter, vlan_extend, scatter, timestamp, security,
+ keep_crc
This command should be run when the port is stopped, or else it will fail.
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] app/testpmd: remove jumbo offload related code
2022-10-17 9:05 [PATCH] app/testpmd: remove jumbo offload related code Chengwen Feng
@ 2022-10-20 7:21 ` Andrew Rybchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Rybchenko @ 2022-10-20 7:21 UTC (permalink / raw)
To: Chengwen Feng, thomas, ferruh.yigit; +Cc: dev, aman.deep.singh, yuying.zhang
On 10/17/22 12:05, Chengwen Feng wrote:
> The jumbo offload was removed from patch [1], but testpmd still exist
> jumbo offload related code, this patch removes it, and also updates
> the rst file.
>
> [1] ethdev: remove jumbo offload flag
>
> Fixes: b563c1421282 ("ethdev: remove jumbo offload flag")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-20 7:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-17 9:05 [PATCH] app/testpmd: remove jumbo offload related code Chengwen Feng
2022-10-20 7:21 ` Andrew Rybchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).