From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arybchenko@solarflare.com>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 9B0D95B38
 for <dev@dpdk.org>; Wed, 17 Oct 2018 08:27:15 +0200 (CEST)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id
 F1416800069; Wed, 17 Oct 2018 06:27:13 +0000 (UTC)
Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com
 (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 17 Oct
 2018 07:27:07 +0100
To: Thomas Monjalon <thomas@monjalon.net>, <ferruh.yigit@intel.com>
CC: <dev@dpdk.org>, <ophirmu@mellanox.com>
References: <20180907233929.21950-1-thomas@monjalon.net>
 <20181017015450.15783-1-thomas@monjalon.net>
 <20181017015450.15783-2-thomas@monjalon.net>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <f07035c8-cb5a-234c-eb4d-651f6f20dc4a@solarflare.com>
Date: Wed, 17 Oct 2018 09:26:27 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <20181017015450.15783-2-thomas@monjalon.net>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
X-Originating-IP: [91.220.146.112]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
 ukex01.SolarFlarecom.com (10.17.10.4)
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24160.003
X-TM-AS-Result: No-6.040900-8.000000-10
X-TMASE-MatchedRID: VPleTT1nwdQOwH4pD14DsPHkpkyUphL9QKuv8uQBDjqbVPV9Ctbcx/DV
 hLlEzlAWCPQkmxUZFjKEepLbI+P7qIZsGQNfA1lXQpxiLlDD9FVflOpBqBHTt1AoBBK61BhcgLv
 KbEFwC51F8uTfEEm3OfMVfR6ftjhyoFRkCzPw0nmxo9yzdPhMvU0nfB5U5KivmyiLZetSf8nJ4y
 0wP1A6AAOkBnb8H8GWQN6qaRgrxrxq8/xv2Um1avoLR4+zsDTtFAQvQYa7pIMoX7JTWv563Ee91
 WAnXFn4JMMvZRbb1RwmZZWwu41tMw==
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--6.040900-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24160.003
X-MDID: 1539757634-9VNajHWSkJGb
Subject: Re: [dpdk-dev] [PATCH v3 1/4] app/testpmd: allow detaching a port
	not closed
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Oct 2018 06:27:15 -0000

On 10/17/18 4:54 AM, Thomas Monjalon wrote:
> The testpmd application aim is for testing;
> so order of operations should not be enforced.
>
> There was a test to forbid detaching before closing a port.
> However, it may interesting to test what happens in such case.
> It is possible for a PMD to automatically close the port when detaching.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

I'm afraid it could be a problem which the patch, since port
close ensures that the port is not used for traffic forwarding.
Right now the check is gone and we can detach port which
is used for traffic forwarding on separate data cores.
So, almost guaranteed crash.