From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75D4AA0548; Mon, 20 Sep 2021 17:58:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D51B40DF7; Mon, 20 Sep 2021 17:58:21 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 74F0E40DF5 for ; Mon, 20 Sep 2021 17:58:19 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10113"; a="219969071" X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="219969071" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2021 08:58:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="612589933" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga001.fm.intel.com with ESMTP; 20 Sep 2021 08:58:15 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 20 Sep 2021 08:58:05 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 20 Sep 2021 08:58:05 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 20 Sep 2021 08:58:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KP8wyNsB2VaXryIBibe9BDBunkb/EldVh4Yrc275AevHuCpooqYVYm8jr7d3TkBLUgM380Zb023t+sloqvV64zBX6bpZbr1MipmNqLIimpHb8quBxvZ3MDpJzYDY4GmVUCHd6cHohyjiPCtP+fPcGyBSAZrjUpG7/y4S5ZUVzPJIIcwN75++xHVOnRugtKxlkqnwTKtob2yyGwtgIUsRQDvVeJpQE6s3j1mniMGOLrtQMGb99GJ/+ikBYb/gmRxaXBo+KjCZPpPX4kExpj9y683Jv2yDroT4I2eRyPKdbtn781n/4QdoPo6Nb/Ku8C818qnTmmUYp+94spy2enlsMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=yfcpZ+Ot0tb8vVqANZI7aEvPu0NLK28mBf8tPGGrjao=; b=hpce/qIEHSCunTO9b5GWhtNnfZFdHgFgP0kKB4upV2MwAIjlte2HWUDnVYQHqwfPbpSq0DxtQbsbmro9Rj8gYU8p3owp0hvyyL5nDlzC9qLJHwzGT8VasGmYbX8wYTuRDj6q48daorXq4n2NQYaAzpeyY49EXPWtMI3nybnP3F7Fvn35maLNLTtOz2TIJQkqBZ2gDMyPRojmynQGuDvn9YWd7f594gQTY6/BUEhJm9boCzhgL8Ro/GSunU8pJidPrCQWCG0ZX+GQ5QdNONUoOF7kDkgcK9cHjwMRDeP7NlHc5YcXqii3SLVR9Wnf88HC3nXbFlqA7eE/prskyV9vUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yfcpZ+Ot0tb8vVqANZI7aEvPu0NLK28mBf8tPGGrjao=; b=fQikdKhCHEkqyBrKhju64QPoefIGitgSmOMUF+7byzwPh60UGpAdg5/yNWdU2XW9z4UkEpl9Xrwdp09hixduOpwCxtU0IgKLetjLjNkDMYCc8KcXy0Z0AJvWyPLQ4GVvW3E4CyJwdfs7r8/hmmNSVePe3I60sESk1U0/nxu5lKo= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5143.namprd11.prod.outlook.com (2603:10b6:510:3f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16; Mon, 20 Sep 2021 15:58:04 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4523.018; Mon, 20 Sep 2021 15:58:04 +0000 To: Eli Britstein , CC: , Matan Azrad , Shahaf Shuler , Slava Ovsiienko , "Gregory Etelson" References: <20210913142535.9084-1-elibr@nvidia.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Mon, 20 Sep 2021 16:57:57 +0100 In-Reply-To: <20210913142535.9084-1-elibr@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB3PR06CA0025.eurprd06.prod.outlook.com (2603:10a6:8:1::38) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB3PR06CA0025.eurprd06.prod.outlook.com (2603:10a6:8:1::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16 via Frontend Transport; Mon, 20 Sep 2021 15:58:02 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b9471790-04ee-4ef9-2ca0-08d97c4f6e0c X-MS-TrafficTypeDiagnostic: PH0PR11MB5143: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1QwIkH8omt/kX4zf6qFuL4M50SSXZh2dJF36Eqf2n7FXTd0p4od9ZHVAdoBQYoMtv6AE/cVUcU5USJa1GV6BaxrhRQtJq7seXDNf8OBnkX+xY+vYSqS/qi/qF/eVmXJbQbwV8GN5WMpR66+xUtf7MgdyXej6g3NUw6cdR3Wd0NKoQ/nsWoLZjE9J9eamnbp1kdLjdMPRilYKNG0kuc6EaLDYtuuESF4Eh7JY3+xTYbnfPA8/+VlmkIZ80EEHUsVV0CsXTTbb8goTmzgmXINlgXViSdAPPTQUwFIVgFveQ5v6HYh8ycewsrSTdD3msfrwYR46FAWiZtUQoqUV/G4S/5OyfmjmTTBwdRnt2G0e8hUoUViMeMudmDjHuBAypeIPsUlOUHYP+/RwBcGr+RoOWs2ct+Z0RciNB/V/JeNq74IHdayYIf6XhBirDuxwaNkfxgkbFGanzAFxzcwkzsRWxc5b8EcA07KTvv+spZnMRdxFuJ+AXnYouKGfjFR47hn6iU4k6jLSsF6f0eVkCH8fyeMkCl5nc8q4w8jFKw3LvONDwEQZYqJvBBpu6SmuaxAav+xOZj0KwXRvMN0R1Idp0EWTDLIbrc22DH4gQmzt2hj8gH6qXJ9X5Kn49PG2759s3Ig53WTGKrboYDAdTo0uQIjMV0gqSul71N1IFv67fo5SEXU9N+7REHstF5PDTfdf6M6HSpe7BgBc3XNMhOo9Pg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2906002)(5660300002)(8676002)(36756003)(8936002)(53546011)(38100700002)(66556008)(4326008)(2616005)(66476007)(66946007)(508600001)(6486002)(16576012)(316002)(54906003)(186003)(31686004)(26005)(86362001)(44832011)(956004)(31696002)(6666004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXBSeXluUWVad2lwUFVRc29SRGdQQmpoRTdOemZJNWdyVXg3ZzcvakYxdWE5?= =?utf-8?B?QnFqQ1ViVzlyY2NSRmgvbU9UVWVGUGhxY1ZiVWJFMU5EbjFRNVc5MWUzZzVx?= =?utf-8?B?TWR3UkZYVlhqUjlINkI4SzI1RStZUjlIZFBjQjFQYzhNV1lLN2dMUzZTVGw0?= =?utf-8?B?TGhPS1BiMzB4N0huak1rWTBDOHhvbWlpYysyT2dJOFVndUxLVXVqcGdEbm0r?= =?utf-8?B?VldnbEpuT1J3d3dXV0pteDRCUDlBenJTaWFtOU5HeUtYMXdOVmJDTnlmdktR?= =?utf-8?B?dnlRbXlqYmtDcVNIc1h0eklFaHJUN1lmMWwrNGtPWjZCdW9FbEI4Y1pFWnVa?= =?utf-8?B?bCtPZDdWRzV6UDR5Ukp0NjhyOVBiQUdUazFpL1Znb0k2YzZxdFdPTlpuL25K?= =?utf-8?B?WUpiNUNXR1VTWGg4RFAzYXAvbXlkVkF5dWlUOFNNMHZxU3ErbG05VW5VU1hP?= =?utf-8?B?M0NNOW1leEVLalh4bU8vR3g1WTZFQ1lMTm13TnEzaUlTdWtML1MzUmNkZ2hY?= =?utf-8?B?Mklrb05JWmx2OS9GSE1XUkkwUWJXVEwxRlZlS0tsS2xPSnAwWE5Ea3NBWmxm?= =?utf-8?B?K3AxYXU2dmRzOUtPem56RnEzTVpkNC9VT0o2RUtnbStabGhWRVBTVkUxS0x3?= =?utf-8?B?R0lpRUgyb3ZBMlpNUTlTWnpaN1cyM2JEUSt1M3BjMG1uNDdiYmxrZHNhZXhm?= =?utf-8?B?U1hYcE1pdXhUYW9lMUJ1RXZTbnp4bjVSU2NNcGlCWThFUWpYUkpPQTF0Yi9P?= =?utf-8?B?WHN4YmF3NDlFQ2U2bnNTVG44VzNJUXlyZ0thelYwZk0xUlhYNkZXM2p6WmhU?= =?utf-8?B?aVlMSWh5ZW5pOHJsWm5VQXVZSFFPQ0xRQ0lhSzEzclBQTWVRdlR0UGh2NjZo?= =?utf-8?B?K0M1Ykh2b3RQQVo0enZLQ2h5c3JxWmtPYkMzWXA5S0pnSXZWZ1BySU82VFU2?= =?utf-8?B?YVdxUnBDSkNLT3phWC9KKzlueUduWHYvWEVxTkhuRUR5UFNKUU5YSzQrTG9T?= =?utf-8?B?a0RrR2J3SXZXaXhaU3EvcFI5Yk9iNGdiakY1QVl1ZzJoQzlQV1lPOHVSc3V1?= =?utf-8?B?R1VQQy9zOHVxYmMwdzJpa0NBWkVDWTNScnE1eElmaW1vZm02enkrSmYyeFhz?= =?utf-8?B?MWkvQmgwWVlxQll0bGExa0wzZjlaRjNSN0xEODZJRENWbnZNcDY5Q1lvVExn?= =?utf-8?B?TlQ2ZXRiU1lERHE0Q1g4TXNDR0hrcmluMEUvSWdtYnhDN1R5M3R5OFBKMW5G?= =?utf-8?B?aDlaTmxiMFVwdXRtRFdjRnhDbkIzc2tmdE9TRGsxa3R1Nm5PNEk4cnRCa0Y0?= =?utf-8?B?UFNHcG5zR2Y3b1RZVUFHUWowMFZsbCt0cmZ2MUs4eWlZb0htT1JBRG9YYzFY?= =?utf-8?B?WkFacHRUN1FmbGg2dHdIVC9EWmRmZTdJdGM5YkllbCtHZzc1RmFSOEJMMW44?= =?utf-8?B?eU54TDk4MTdjdHltK0FBcFVWZ1VxblBFL05CNWhoNU1JYW5ZL0szN3FVL0Mr?= =?utf-8?B?OWMxUXNMb2Y0Qkx2NzR3aHBBQnAyUi96enBLdkkrMUxhTzVlYU1jaEI0SXcz?= =?utf-8?B?ME5NbkdacjQyTSs3RUYvb205UlpIcmFuRXlsTWMwSllKanQ0WEsvNkxRWmxz?= =?utf-8?B?SFRPbkx5NXdXZGx4L0FFaXVvdmkvdS9ZT2ZlOFlBTXRSMHRnQXNlU2tlb3o3?= =?utf-8?B?MzhHM0NCMkFZVWtpT0ZKYTZsYVllK2NiTXl4Q0pGVWhtbVRDcE9qSjZYN1Fm?= =?utf-8?Q?4lyUn/nJdtD3XnIiD+AypZZs9icpsQvupVf4V3l?= X-MS-Exchange-CrossTenant-Network-Message-Id: b9471790-04ee-4ef9-2ca0-08d97c4f6e0c X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2021 15:58:04.1701 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fYg4wBFIGCnMaJgewtItOwe1kFxqg19NaBMOeu7c4Dvgl41I6tUShTrGEO+K+A+EvOlBNjG0IBdIAxzU5Czb8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5143 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add tunnel types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/13/2021 3:25 PM, Eli Britstein wrote: > Current testpmd implementation supports VXLAN only for tunnel offload. > Add GRE, NVGRE and GENEVE for tunnel offload flow matches. > Hi Eli, I assume tunnel types are added, but forgot to add the flow tunnel support for them, so this patch is fixing it. If so can you please add the fixes commits? Also it may help to give a sample of the enabled commands in the commit log, to record. Thanks, ferruh > Signed-off-by: Eli Britstein > --- > app/test-pmd/config.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 31d8ba1b91..fba388da5c 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -1212,6 +1212,15 @@ port_flow_tunnel_type(struct rte_flow_tunnel *tunnel) > case RTE_FLOW_ITEM_TYPE_VXLAN: > type = "vxlan"; > break; > + case RTE_FLOW_ITEM_TYPE_GRE: > + type = "gre"; > + break; > + case RTE_FLOW_ITEM_TYPE_NVGRE: > + type = "nvgre"; > + break; > + case RTE_FLOW_ITEM_TYPE_GENEVE: > + type = "geneve"; > + break; > } > > return type; > @@ -1272,6 +1281,12 @@ void port_flow_tunnel_create(portid_t port_id, const struct tunnel_ops *ops) > > if (!strcmp(ops->type, "vxlan")) > type = RTE_FLOW_ITEM_TYPE_VXLAN; > + else if (!strcmp(ops->type, "gre")) > + type = RTE_FLOW_ITEM_TYPE_GRE; > + else if (!strcmp(ops->type, "nvgre")) > + type = RTE_FLOW_ITEM_TYPE_NVGRE; > + else if (!strcmp(ops->type, "geneve")) > + type = RTE_FLOW_ITEM_TYPE_GENEVE; > else { > fprintf(stderr, "cannot offload \"%s\" tunnel type\n", > ops->type); >