From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7BDA45CE7; Mon, 11 Nov 2024 10:16:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B689540EAB; Mon, 11 Nov 2024 10:16:37 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mails.dpdk.org (Postfix) with ESMTP id 763C540E01 for ; Mon, 11 Nov 2024 10:16:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731316595; x=1762852595; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=wR5C9qHdpESta1fTxqcV4IEbQdpwheE6S+NLoQR6x6Y=; b=VF9Wd5Ulrh2LYs655b8Nk7svzRXLoHy1YvCQQypp1UcmEA6Y0iGUwGyN WvCT7fOUeK1wACfwVpFwSUNb5JiqGH65tUgFktjFk3zK5qotOmPPQHU8A Yv8k4H9D/ixTURSXeoY3VhCa4MSD62q01Jt3cNV0uIPiaG/249Stb/VpD Sa8Igvd8ios5H48yezOJZtysTXQs5brsN/P3PJ0joObKPvHvsSvRunX94 C5rNDAqvA6uEks6YYVbQQmlSczYS/0PB6UtzOxsBPGtqTmy9ixk6Zb30m FzgYmJX7IixVFmln5HtxSkXEzRvcn8g9tz6JQTJZbOlxCi1ljhqTcU0Ks w==; X-CSE-ConnectionGUID: OJDgiIThSk+NUXys3cECxg== X-CSE-MsgGUID: oqu6iL+GQFaettWjAsLM+A== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="31281239" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="31281239" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2024 01:16:34 -0800 X-CSE-ConnectionGUID: 6iPDXrOKS/Ksk/2+anhTcQ== X-CSE-MsgGUID: MXtCrSqwR+yVihN/1Gj4Gg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,144,1728975600"; d="scan'208";a="117634558" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Nov 2024 01:16:34 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 11 Nov 2024 01:16:33 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 11 Nov 2024 01:16:33 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.44) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 11 Nov 2024 01:16:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jYRDihQCSeZ2mraheM75EnyVbNHPWuz11diMK42Pv0aSE11fRoXySzlrDKkjpuC7SWk/Cah+65we+kW91tvfdLYActl8WRhqKJ1NZJ96ksoVTeLHnWcRdzuPHWKgwkJpFF1KbjgbZxnXqVMOoNSy1VelEcF5zH/hCwKyvcM09hyTIY5PEUNDpjVdGWA0iAzZ/hvzMgiFUumn3h+AIcQUF2bxE9uTMJqKzctgCX/wt6W18r3ag3qgnTNdDznfS9NwEVZqTJ+ZXResJuX8k521Kal1UlUpctK6vUwEl3WUrcQAf9+eM/Ij1fOBiV28v3/u8bY4BWrWdwKyUEzEsSFDaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iSnc6qbK1Hoc67by6zVxshdfRroDyOzVlQfUJoQyG9o=; b=MhByNnxRXRfxSojfEL7VIlXHUB6r4LKiIVCG+wwfR7O2XU6IVpILMMaj3n4XSUu0fk9UC6cKQhpOB9+FFawLDNlz6JhVdZu4EiyuK7aIy6QHcoA77ga5J21nEjIkzuwzcXhXb3QhoWsCFoNOGf7SGUpjDRTms/iTxrW9kjNVuIrZfbWu4QGrg2ZTNYly4hBvg6L2UN9F2KNt0SXPtKHBNABDT5TAN52rQ+nOJW3CsYvRiWS+ihXpTj2wklq4eaT9HpG5hibDTArcSnOYxnBOL0/xFSLf9sXkB1ZwrhG520orViUXaeAEAk6qm/ouwWDwpnvoAsoDyLr3DonDY21S2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by CY8PR11MB7873.namprd11.prod.outlook.com (2603:10b6:930:79::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.26; Mon, 11 Nov 2024 09:16:31 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%4]) with mapi id 15.20.8137.022; Mon, 11 Nov 2024 09:16:31 +0000 Message-ID: Date: Mon, 11 Nov 2024 10:16:26 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 10/20] net/ixgbe: remove use of VLAs To: Andre Muezerie , CC: Konstantin Ananyev References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1731116892-17109-1-git-send-email-andremue@linux.microsoft.com> <1731116892-17109-11-git-send-email-andremue@linux.microsoft.com> Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: <1731116892-17109-11-git-send-email-andremue@linux.microsoft.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0287.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::35) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|CY8PR11MB7873:EE_ X-MS-Office365-Filtering-Correlation-Id: ae268c08-2c3c-417d-f9d0-08dd023187b2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Y0srWURpY2Y1b2dRM0R1ejlsa283SlBzSXo2S2JiVU5LYlJRNit6SXZqVU81?= =?utf-8?B?YTlBZmVJNzdXUFdDSWJBV0JqQjgyai93azFmTCtSQUpJWGNGRmlFVERBV3NC?= =?utf-8?B?N2tseFBzSE93c1lJZy9TcitYdGNLdnpZaFlSVnd4QWdjakpienFacnZtM3Uv?= =?utf-8?B?ZDJwQytrUUkvcnN5MkUxY3Z3QjhsMjZ1VkhGK3BOMDhGeHlYRXVlTFlMOGkw?= =?utf-8?B?ancyQmMxRndnOXBHL3RqUGZDcmo2d09Bc3NqTXdvVFJyWU1QME9vSWFhMWF3?= =?utf-8?B?TXF5c3FXQzJielFiYnhZdG1EekI3Q0sremxKYTJuSFpFam5pc0pZQ1BXd1JC?= =?utf-8?B?VDJzTFIxMStyenlwUzJUUU9hYWY5eGViVFdxZ2Nza1BtUThaT1FveEFkeTRH?= =?utf-8?B?YkxVR0VHemEwYkt1TmNpOG1LQzg5R09NcEM1MXZqWTRFTVRFci9oZ0xJMGR6?= =?utf-8?B?RjR2c0JLWWVnd041elhXejlVWlhvTlZ1cmtiRnV6STUvN3dseHAyL1o5NUJj?= =?utf-8?B?Tzk3bGNKVG1iOEJCRkhlVmN2RnFBS0JzUWl4Rkd2UlJyVGVNRmR0QnNvN09u?= =?utf-8?B?dFZsOWFxRks0aEtGRkszQVhIa2ZlZFAvemovZ2dMUFY4NSs0UkFDcm5WdUhW?= =?utf-8?B?WjhUbTZlMHoyNk53UmZiamF6eDlGbjBvNGpWbk8wbENTNFB5OEkyb04rZ0Zi?= =?utf-8?B?eC8vWnBiUFk4WlNDV3ovSWMwNFhEcDd6NC9lSmlSaTM5blFVV2kxWlVjN1N6?= =?utf-8?B?dlBIWnM4YS93YWkrbkhtL2ZIT0hBVUlkdmhnbGhvL3dXWlp3Q3piK2lOR1Fs?= =?utf-8?B?WVd1dEh6ai9EVGhhQUdCNkZzaHVzMWt2Qnpyb2htbS9pOW9YbXBJWXBwVmxP?= =?utf-8?B?MDdsZXJRemozamZ3d3A5c1llNVFraWtUdXVTbG5ITWZNcGdEem9Cei9kOHdQ?= =?utf-8?B?TGxsb1MyYS9XaGptVG1OUEdhakNkeU5BUnVrcmErWVU4RXowcmpvbnp2Ylp6?= =?utf-8?B?UExXNzY0a05sL0JNL1FnUGVsNDFsZG5TZ3hVOUwzYlNKc1hOblNuYjIrTTFo?= =?utf-8?B?SFNucWZSaXYzMS93aFZCZGZyUmhVUks3TCtRWkYwTHkvS2F3WTJGWkNtdDFa?= =?utf-8?B?K3ptY0Ftakx5TklEWENja1pvcy9iN0NINTBxaVpBVUsvZCtEeDdYUWx3RmJj?= =?utf-8?B?NVdZTysyU1o3ZDB2UXhYakd1Z1Zkc0xPV1BGUFFTMDJjN0V0RHcrOXkrUTlu?= =?utf-8?B?WlBrSDRib004SnJDVndKc1U3K2FkOGRrTi9nVkM2SVNEcjRpVHU0dmdpTWJU?= =?utf-8?B?ajB5VjhDaVJOLzB6azBUVElrZHZWaEVWa2phdEJweW1NaE5kU1BHZ245ZDdn?= =?utf-8?B?SHRxSzNCNHlvY2JOb1VKZnd4WFVwVTAyM291RzdHOHlyQ0tFWml6eERVdDl0?= =?utf-8?B?M2x1Z0V3VTZla21DS1lucHpXUGtSTlJoZjd4ZVcvZ1dyejhpMlRQMHIvd3Vi?= =?utf-8?B?cGpoYkhwdWZpbFltaDJ6STVBUzUrd1FkNnJQOGhSOVlnaWJ3bVJPdGlValFt?= =?utf-8?B?UHMvMUFjQ29yOTYxT25Tb0RVbnpKOUJhOTlNbjdXUGRMN3N3Nm5KRmF0QUYw?= =?utf-8?B?TzVNNERnWWIwRjBKeU00ZTRTTkpqOXJBbmxrdkF3UzZtL0N3N2tWSGhNVmM1?= =?utf-8?B?dXp5eWFGdzVWNEc1UXFLeEQ3ZEVXUC9EekVvTjQ5bHBhaG5VUEQ3RE1EREt6?= =?utf-8?Q?IzsJXh6+SY6MW9GvSj3pG9KNOvTZlwO/iEEC5l2?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjhDaklRYmtFdE9FVDFXUGVlUU5wK0FDNGdCbGpJMHhtZkNkaFdORG96bVVN?= =?utf-8?B?ak9uUWNvZEVxQzRyeElzUHhjSmU1S20xdlh5SXRGRlNiaXJRdXo3amJwT0FT?= =?utf-8?B?TXR2bWczTWE0SEd1TnliZ1hwbkRmSTdOd2dFQnIvZHBWeFA3Umlzd3BvSmk0?= =?utf-8?B?ZTZ2eEtKcWR5QTdGSE9oQUN5VzQ3VnpzZzhMd0VoSHFhdndxeS9OVXMrQmww?= =?utf-8?B?VWc1aVVCYjhaYnVCRUYvSEFDN3hRTk5yNWF1Q3YwU1R0VzVrZ2hjemtjRHdU?= =?utf-8?B?cnQ3bDBBemdUTEYyamp0VGhzQVZ1dnJlZkJjR3Nwb0M5VnR0Z295Mkcweisy?= =?utf-8?B?VVhjUFNpdnVBMlZCY3J5dmxGS01OZXpqOXNTNE1YZkQ3eUNuR3ZEc1poVElt?= =?utf-8?B?OVBNNEYrK2RheGpZVEd4Q2tPbDdHSjczZm1TTTV4Rkh1LzZYV0gzb3NDc1Zi?= =?utf-8?B?UENENmY3QS9MYkJDWmdTdWVQS0lybXo4eGZrOWNpVUNCWXZPbkhuVmRxRHcw?= =?utf-8?B?VVV1Y0hZRGNTQU9hY2xhd3dxY2JRNGR6L3VYRFc4RjFVK082ZnBGUWdlOEVW?= =?utf-8?B?TkZ5Q3RJcFFLTGxXTjdBeGFSYzVaZ3dqM0JQdzJyZXEvUUNDMzY1cWMrVFVB?= =?utf-8?B?Ym45MFNhSWlqeUxLMm5lY2tjVUltVTJtVnRpNFY2cGMxVDhCZXNra1U5MUo1?= =?utf-8?B?cWdWSnRSNjBGbVB5cnozRDlyblhibmNXMi9XNVZmRXQxU2lXcVZHbFZFam1N?= =?utf-8?B?R2VlRUNTek9VM2NReXVBcEwrdTJFRUsvV051WXBSWjUxbmJyMVJFVTlaN0hn?= =?utf-8?B?VFp6OUNFOC9sSm1vcjZqMm5KQWs2Mi9ZOUpqcDBYOXA1ZU1nbVhEYU5sOE5Y?= =?utf-8?B?M3BvcFNJT1hkNVBZZHl2UU1BUDA2UTQzTTR1Qzdra2VyakNtUUx0NkNQczlu?= =?utf-8?B?WWMrQk8yNW1CZGpod1cvbGVOWlF1b2poRFB0ck9PQ1BoK2N2eWwwR0pBMWpy?= =?utf-8?B?SnphZEpLK0ovODZxSE9rQzZvV2M4RDhYYmtTY1Z5TFczK1IzdGpBQ3FpSExV?= =?utf-8?B?aTdkSjVzY3M4TVZjQVkvTGRud0lhdUZuQXFiaVdZWnZ1dnpOdmFBSUlremt2?= =?utf-8?B?RUttb3lESEtER09WcDJkY1ZMK1dWLzBlNGZBYzNodEhtODB3bFZtMVgyZ29y?= =?utf-8?B?QzBzVWlSczYrTktKVWRJTDN3TWwxK01VSEVENUlUTUlhSlBUc1FvOTdyeGFK?= =?utf-8?B?MnZGK3Y5N0hNZ2xrYzU3Um9aTWhFVkpobEF6bEkzQWRqdkN6dXBBaXNvWEhE?= =?utf-8?B?UjVSVW5GY2tITVRWT2cyTEVQU3ZRK3dKb3VzNkpvdHhKWVVWTEgwY3JOMkhM?= =?utf-8?B?dHN2cXNaT3pmUHp1SU5JWklaTXRxUG5PU1M1WWF0NHU5VmRid2ZSRnhCbzJU?= =?utf-8?B?aUFxT3VyT1BkZEtMUzRSNGhnblRPMXdQWHorVW9aZkxReVpUOTRFZ3JWOUdT?= =?utf-8?B?dmxMOEl4TERPdURodStjNDN1eFpmQTJLck5ZSSswdXlPanVldE1hVm4xVEsz?= =?utf-8?B?QjRFd1c3c2RHRE51ZW53SXpXdGJ3MFIxeUNvV3BSbDZaL0tPZWpGdUdQL1Nl?= =?utf-8?B?dm1JbVRmMFVEVVpXZGRqSW5Ma1N3OGxFT3hNVERBcS9BNVNRaDhzelFNMjVW?= =?utf-8?B?WWxubjZtN0ZIRDRrTEg1dGFFSHRBL1dPNTE2Z1JMV05RYlZhbkpmQTR2K2tn?= =?utf-8?B?cFZqa1NTb0ZQR0VLam9IZ3ROSS9ZRGJsNEJKTmhOR0V4U0piSkM2M3UwM3Np?= =?utf-8?B?UlE0L0dZNkUwRmx0cWt3MWRtcVoxN043NWUwdDhOVURENi9jMnZZZ2tkbHM2?= =?utf-8?B?V0dnMFdFYnJKbzhWSXArYzRsRjRIMGJuOCs2TnR3clN0ZGRHN29yNXB4dzdi?= =?utf-8?B?Vm9oZGZUMXZwdTJId3VxUVJ5OUtQMTdJUUROS0xMR1ZlZW1mTEN6QUlJQmJY?= =?utf-8?B?NmlIUGhEc3JHMnFJemtHMnRRSzdubk5NWWlRd3dlc24vUkV4MG9ZQmM3bEg3?= =?utf-8?B?RTY1R2RDNkxKUG1QZVFsSi9OSEFSV0h3VGZYVjZmQzJVaTJFeUVhamg2UWQy?= =?utf-8?B?c0tnc0hFVFhvaUNzVkNtWGhnU3NYZlphVEtyTVpIYVh4aWtpL2RtZ2hSUUhJ?= =?utf-8?B?b3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: ae268c08-2c3c-417d-f9d0-08dd023187b2 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 09:16:31.1799 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vhTCT2Defd2eSNeMwAWhptSWJP1Ph3ly3n3tGzMPy+2vXIO2luO7aHMFp2HRPUjkExLZlIefGLBxZ23kIm8G0AxoQuYk0iR7v90b7z2KU6I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7873 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 09/11/2024 02:48, Andre Muezerie wrote: > From: Konstantin Ananyev > > 1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning: > variable length array used [-Wvla] > 2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning: > variable length array used [-Wvla] > 3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning: > variable length array used [-Wvla] > > For first two cases: in fact ixgbe_xstats_calc_num() always returns > constant value, so it should be safe to replace that function invocation > just with a macro that performs same calculations. > > For case #3: reassemble_packets() is invoked only by > ixgbe_recv_scattered_burst_vec(). > And in turn, ixgbe_recv_scattered_burst_vec() operates only on fixed > max amount of packets per call: RTE_IXGBE_MAX_RX_BURST. > So, it should be safe to replace VLA with fixed size array. > > Signed-off-by: Konstantin Ananyev > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly