From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 68719A04C8;
Fri, 18 Sep 2020 20:12:50 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 385EC1DB11;
Fri, 18 Sep 2020 20:12:50 +0200 (CEST)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by dpdk.org (Postfix) with ESMTP id BE46F1DB09
for <dev@dpdk.org>; Fri, 18 Sep 2020 20:12:48 +0200 (CEST)
IronPort-SDR: jOEpxsP7z7OjZ7I9ea0hnIv3GhbQmmefCWSivx7R8eJ76hui4TxX9iQeU6vMbGdf3plxhqKI/G
oV7qyW/JIzqg==
X-IronPort-AV: E=McAfee;i="6000,8403,9748"; a="140003095"
X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="140003095"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
18 Sep 2020 11:12:43 -0700
IronPort-SDR: t19bSw/EjCahNmjUGA/FGTgcia1blToAfUe0xjsLFcE4XSLzeZQ/2oUpfaTNodiaV/GILrmMD0
LBbiS02Ycrtw==
X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="484306459"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.248])
([10.213.227.248])
by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
18 Sep 2020 11:12:36 -0700
To: i.dyukov@samsung.com, dev@dpdk.org, v.kuramshin@samsung.com,
thomas@monjalon.net, david.marchand@redhat.com, arybchenko@solarflare.com,
wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com,
qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com,
stephen@networkplumber.org, nicolas.chautru@intel.com,
bruce.richardson@intel.com, konstantin.ananyev@intel.com,
cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com,
declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com,
jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com,
anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com,
john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com,
yipeng1.wang@intel.com
References: <20200427095737.11082-1-i.dyukov@samsung.com>
<20200915190728.18143-1-i.dyukov@samsung.com>
<CGME20200915190833eucas1p2708ab17017315c193173b423c9fa1d0e@eucas1p2.samsung.com>
<20200915190728.18143-20-i.dyukov@samsung.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <f0e7ee6a-85fa-63c8-c52f-9dc1d34b96c2@intel.com>
Date: Fri, 18 Sep 2020 19:12:32 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
Thunderbird/78.2.2
MIME-Version: 1.0
In-Reply-To: <20200915190728.18143-20-i.dyukov@samsung.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v11 19/24] examples/multi_proc*: new link
status print format
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 9/15/2020 8:07 PM, Ivan Dyukov wrote:
> Add usage of rte_eth_link_to_str function to example
> applications
>
> Signed-off-by: Ivan Dyukov <i.dyukov@samsung.com>
> ---
> .../client_server_mp/mp_server/init.c | 15 ++++++---------
> examples/multi_process/symmetric_mp/main.c | 13 +++++--------
> 2 files changed, 11 insertions(+), 17 deletions(-)
>
> diff --git a/examples/multi_process/client_server_mp/mp_server/init.c b/examples/multi_process/client_server_mp/mp_server/init.c
> index c2ec07ac6..a7f5207c3 100644
> --- a/examples/multi_process/client_server_mp/mp_server/init.c
> +++ b/examples/multi_process/client_server_mp/mp_server/init.c
> @@ -185,6 +185,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)
> uint8_t count, all_ports_up, print_flag = 0;
> struct rte_eth_link link;
> int ret;
> + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN];
>
> printf("\nChecking link status");
> fflush(stdout);
> @@ -204,15 +205,11 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)
> }
> /* print link status if flag set */
> if (print_flag == 1) {
> - if (link.link_status)
> - printf("Port %d Link Up - speed %u "
> - "Mbps - %s\n", ports->id[portid],
> - (unsigned)link.link_speed,
> - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ?
> - ("full-duplex") : ("half-duplex"));
> - else
> - printf("Port %d Link Down\n",
> - (uint8_t)ports->id[portid]);
> + rte_eth_link_to_str(link_status_text,
> + sizeof(link_status_text), &link);
> + printf("Port %d %s\n",
> + (uint8_t)ports->id[portid],
> + link_status_text);
This is not related to your patch, but port is 16bits, it shouldn't be
cast to 'uint8_t'.
> continue;
> }
> /* clear all_ports_up flag if any link down */
> diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c
> index 9a16e198c..33643d354 100644
> --- a/examples/multi_process/symmetric_mp/main.c
> +++ b/examples/multi_process/symmetric_mp/main.c
> @@ -365,6 +365,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)
> uint8_t count, all_ports_up, print_flag = 0;
> struct rte_eth_link link;
> int ret;
> + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN];
>
> printf("\nChecking link status");
> fflush(stdout);
> @@ -384,14 +385,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)
> }
> /* print link status if flag set */
> if (print_flag == 1) {
> - if (link.link_status)
> - printf(
> - "Port%d Link Up. Speed %u Mbps - %s\n",
> - portid, link.link_speed,
> - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ?
> - ("full-duplex") : ("half-duplex"));
> - else
> - printf("Port %d Link Down\n", portid);
> + rte_eth_link_to_str(link_status_text,
> + sizeof(link_status_text), &link);
> + printf("Port %d %s\n", portid,
> + link_status_text);
> continue;
> }
> /* clear all_ports_up flag if any link down */
>