From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9903E43B0F; Wed, 14 Feb 2024 22:59:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DD2442EAA; Wed, 14 Feb 2024 22:59:24 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2082.outbound.protection.outlook.com [40.107.243.82]) by mails.dpdk.org (Postfix) with ESMTP id 6B40542E10 for ; Wed, 14 Feb 2024 22:59:22 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J4C22a20Q3Brapx4Dta4bDNbQphHpqibOXHuR8XnuGtbULAWCVgrgBmCU4Hza+k8cyQJ7qYfMKjrktzRbJ+7Rj/eM+gvptpHrGT/xpFjEw+Np7rc/mdkW534ZzL2UIC4g4sFJswpERm3X+YTZPvz5SzEnpiKj+Hbl5rGsRfA/BPe1C9lJcgGoKK55UU52i7z3FyeKUG9m48MK8sszH+5ynRqGxATbWcVHGrRyub+eh3Lg12W2QRfNGcZbrUnuQOwESm8rWA5+DeVAIF2n1P5mOrVgSL9axRdlCX46ppnsv4VsVWyyEnT2oTDcqVAf8ycqlmYT9BVTjm+AYv3wWaBEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bezYlRA+VlstTp0fdUngDZaw51dUh4EP6osfF4ism3k=; b=JUVbwzIhv5tAFz9+alH917+Ys5dlNb8Dcy293Aop6O/3ar9MDyP1FtxmERyPeM07Z4DE9axaJVpCAjmx5oAE85Fyps1IFLrv/K/ZNdph6e/8aHxm+GE8MZNcpw7a84H8/OYgUazHLluNwEXXWHyXpaSuH1d/ykobELSukqgartwSrR8vooHkL/oBG9+osqaXbj63WQ/Ka1DZ+d9+JRaucavGrNT26ENzlwtp5TRzD80FhZVrbsGkMfYXEEQWwldZGLfIUSDJrHL9UGqnLCnnf8fRz1Yy59gIGgJam0MALaBGFB66u49ih+fDfVqoV90ffRvyKN6DowEihoBlxovvxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bezYlRA+VlstTp0fdUngDZaw51dUh4EP6osfF4ism3k=; b=NAk3xmdCpzjT4cE0VoC9OYC7CbuJF7P+LZOwM3Rq89nDmtvHgy9vTvkDxUXfvNZgfygFMrq/FYmhlEJ190Ur9KnZOhdCPik96sY4nyZHxfqFu1cMyd4kpUKOP4jVe3NsimIteAoc/tELVUav8cUP58xrdS4rD2I0ID9xU5jlpH8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN2PR12MB4191.namprd12.prod.outlook.com (2603:10b6:208:1d3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25; Wed, 14 Feb 2024 21:59:20 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%4]) with mapi id 15.20.7292.028; Wed, 14 Feb 2024 21:59:20 +0000 Message-ID: Date: Wed, 14 Feb 2024 21:59:14 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7] ethdev: add template table resize API Content-Language: en-US To: "Etelson, Gregory" Cc: dev@dpdk.org, mkashani@nvidia.com, Ori Kam , Aman Singh , Yuying Zhang , Thomas Monjalon , Andrew Rybchenko References: <20231217093205.321082-1-getelson@nvidia.com> <20240214143218.62630-1-getelson@nvidia.com> <8dda8697-8719-46cb-be65-eababae1ccf4@amd.com> <91415555-d916-b2a4-9fbf-0c98bb271543@nvidia.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <91415555-d916-b2a4-9fbf-0c98bb271543@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0051.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:310::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN2PR12MB4191:EE_ X-MS-Office365-Filtering-Correlation-Id: 085c4cfb-4d05-4a11-5217-08dc2da83234 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VRG9mypj3cu5XxLnTxvHXh3m35D9Wqg7xCTGH/f7SmPnSAR2YCxNx4dKOEeTStycbzDQTabxMO9yL1XAfPbAlApztQNjMUUJiqXpb0EmxVyEjh73QYULtKfzyJceGF6nYA0zMzHVL9/m/ke7yL4UBku5VwG7oBrb/3s7Iu+pdxEaIJM90bQLUqAIMGmviofPYiCLE3fcjPQLpvxdf4xI3qYWHg4Wi7eVZrrdja4PnYraSMztgUyevIATdtKeGNL8ZNUBCXu2cq0Qzp4wHXGEGeTiMqhPSCffKy0DWSdI2WJalsngUyGx1fRo1EU/7mEmN9O5zj5mUfeZ9d23zxoIJekyqza/X6M+VtOigDab06q0WQVVF73RvhNAIm3n0gY8IWw72z+/aqDIjlvxQVu/5wgDo/W1zFpe1D7zYTdp3fOOZDOn+a/lBtemh00jWdXcmu55Ix0gD+ktRJYXQSPuKuXKqEby5xTa5aZQ/UD+ha7Lw9ACWhdeAT3KyAeZ5RiItlYRBbj8N92fJrRpITBtZfrV80+cZWciMvnHkiAbb72bekaOrdR20yV2lX6IHG5M X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(396003)(346002)(376002)(136003)(366004)(230922051799003)(230273577357003)(1800799012)(451199024)(186009)(64100799003)(44832011)(2906002)(31686004)(26005)(478600001)(41300700001)(2616005)(8936002)(5660300002)(53546011)(316002)(6916009)(4326008)(83380400001)(66556008)(66476007)(54906003)(66946007)(6666004)(36756003)(8676002)(38100700002)(31696002)(86362001)(6512007)(6506007)(6486002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0pJeHBOaUd5WXd5TU9XN2VoMDRMcW9ZVEtCaHpDVWlqY0dIbDhlUE1uamlm?= =?utf-8?B?VTNiSzhGQVZPenBocVdHOWlOdmx1ZXJ6TUZQNHZ0bHJmWExIMUpHY1dwcjNa?= =?utf-8?B?Tk5GY1FOUVdmMkRwL21LR1VkcHBDRUliMkxrUTc4dW1rMUVsSG91RGY4WDRS?= =?utf-8?B?U1dySVRHcC8wNzJWb1kyL2VoL1lLOFgxUE05RWlVbkt1ZE02WGlVazFVb2lU?= =?utf-8?B?VXIyRnlJTVk3RVFvdThZQXo0b0o5TG5hSFpVcTFmaS9ua0RKaGFPZ0ZjTXBP?= =?utf-8?B?YUk3a2xyNUZoT2hLSFl4ZjlNMEZTaDNBSUx1VENSR1hpOFZxSmpMekFMVjlj?= =?utf-8?B?bzN0aFJ6TDNhZFlhWE16SUxnRHYxT21KSnFKZEFrWDVEUldmSUE3VmtEa2RV?= =?utf-8?B?d2kwaWdzc25GY2VyeXFLazJWQUk5UUVIZXk4djFlWURLK1kzOVVpbGRRZk5u?= =?utf-8?B?emVXem53MUFRSUxwcTFiaXByVzV6c2xjRGlZSHJFNENYWUFyajIzaS9TblIx?= =?utf-8?B?U1J6eDdQb2hTREhEYlFEZUxOWllxZ1M3ZGV2NThHK3ErZTE2RHNPNEJFZUhI?= =?utf-8?B?TFNXbnVTdUNMMVA2UEp5Znk4b25NYXh4dXNEWTJxdkd6WkdYbzdKSGlTMXdV?= =?utf-8?B?eFNJOFNvai96ME55d0JSN0U4bWNIWUszc21YVWxnZTVQNUZHa2R5RzNDWGg5?= =?utf-8?B?TDhsdzFpRTBUbVRNZnU3MnFnejBtVlRTQnkwNGs1QXRKbzRyTll0S3pOZy9T?= =?utf-8?B?aDFzWVlFQzBVYStJeTVENngyQjU2RTd0NHhwbDhtOUFNT3R5NXo2UjVvc0Ra?= =?utf-8?B?WVZzVjlaNnBEbVdWYlBsT3dIeXJhVGhZNVphWnZDNktzb29pdm5ZT203V3l4?= =?utf-8?B?TWRoSnZkUjJrTnZVTE9ZZUxPWnptT1BESFFOVWlrbHA0QlIvU3RET1FTS1M5?= =?utf-8?B?eDZOWGp2cG5aQUdST1paNnlBTDNhSytUUEQrRDd3TXVOZUEzdzcxSTcvQ293?= =?utf-8?B?VlJTYkZKcTA0aVA1TDd0amg0NlYvOEhvT0VGMjMvS04yclBxcGdoUjdYSnR5?= =?utf-8?B?WWlEcEw5YTRlV1FBeFhtRzM4RmZrYlNEQms2ZG5VZGplamVEYWUrOVBabkFI?= =?utf-8?B?L1E2ZFhoamhEYXc2UFRrOWw3ZDN5Qnc0aVZBUUw0SDFieUszbjZBeExVNDh2?= =?utf-8?B?Y1NOZTF5VXhQRlJSb0R1dDVaaDRPZ2dSRVlTVGZ4N2ZERW04Z2xtdE9nODRj?= =?utf-8?B?dGpjQlhhdWJneFcrNXdCTzA0N3ljMERkaUZkT0FqV1R3QjN4L3J0SlFFT082?= =?utf-8?B?aWxHU0o2MnFTb3VUSlhiaGZGSXpwRWtUQUEvVXVhYlptejE4ZG96czZGRmpF?= =?utf-8?B?R2s1c3IvTjdnUlRIRzhFTnVXSEdrQzBRWG5CMk5TekN3RHB3cUZzUXRZTncz?= =?utf-8?B?SFpnQkdYblBLaFJwTWlMMFlFWlEwaStHYk1yNnRIaWNwR0dqd3VhWFlaQ3BH?= =?utf-8?B?c2pJbWFYZUtyOGwrMGl4ZHlyRWpoZXFZallrQ1lraXBzYmJsZWI5MnhYbzJC?= =?utf-8?B?bVdFMlhDcHdJUUg2WThHS083RnhndEpONHBHS0hUbWxSMndIS3ZtV2hFZ2NF?= =?utf-8?B?SE9hcHoxRTZQSVp1ZU5YQ3VlK2FQbkVlejR6aWJYSnhWcmFDbnIrQllRajZZ?= =?utf-8?B?c292d2ZiTDRjUUE4VDRnRXVMalFQb3Ywd251SlBZdTdXU0lLNGhUcnA1ZEJ6?= =?utf-8?B?UDFzSE5ZdWdQWHRUWm1xSlNPQVcyU1RtcHl6bmF6NTFXWkxrTHJWajJYbjI1?= =?utf-8?B?NFA0S1hseWhzeXBaWjlCaTRpMzRoemkzNHk3cnAwWGVjSHk3U2pJNEJPbkk4?= =?utf-8?B?NUI4RzAyRGtPYVd3NUlnWEh2T2E0UG0wTkpic3F5dENaR25wM2I2bWhzVUZT?= =?utf-8?B?dWEvK2pGckl0c3R4Sk9CR05wK2N1MTF3VFNCV2lER1dNV2dhYUZXc3R2cVl1?= =?utf-8?B?TDJnaUZJR1ZrRTNyVGRtdU9LMUMvaUU3L0VPQ21xSitjU0dCOENDb1kwUTdw?= =?utf-8?B?ZVI4UXFyN2RhYjFTSHVTbmZwRGd0VDRrV3F6Q08wb0MrRWVEZFNmSzVmV0E1?= =?utf-8?Q?VmgpdBWaKHK5ytyICQwVkDG/V?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 085c4cfb-4d05-4a11-5217-08dc2da83234 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 21:59:20.3968 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XIte1o9F/QCvRsxggVfqf4JWekfGoXFnPeD6LWVps0ACHW/lldwm9qWznFZ6bx0j X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4191 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/14/2024 5:07 PM, Etelson, Gregory wrote: > Hello Ferruh, > >> >> Having conflict while applying the patch, can you please rebase it on >> latest 'next-net'? > > Will rebase and update the patch. > >> >>> +    Query wheather template table can be resized. >>> >> >> s/wheather/whether/ >> >> <...> > > fix in updated patch > >> >>> +__rte_experimental >>> +bool >>> +rte_flow_template_table_resizable >>> +     (__rte_unused uint16_t port_id, >>> +      const struct rte_flow_template_table_attr *tbl_attr); >>> + >> >> Syntax above is odd, why not move parenthesis to first line. > > Agree that's odd style. > DPDK prefers that way. > Please check rte_flow_driver.h::rte_flow.ops. > True that is also odd but at least it is function pointers in a struct, but this is regular function deceleration, why not: ``` bool rte_flow_template_table_resizable(__rte_unused uint16_t port_id, const struct rte_flow_template_table_attr *tbl_attr); ``` >> >> This is different than previous version, I just want to confirm if this >> is intentional. > > That API version was discussed with Thomas. > The alternative was to introduce additional function call to query > whether a flow rule needs conversion after table resize. > As the result, the application still needs to iterate on all > table flow rules. > Either it or application needs to manage it. Agree that application can call update() on all flows is easier for app, that is why I asked for this clarification. But still it is different than API definition making it mandatory to call for new flows. What about something like, although it is a little longer: ``` Update flow for the new template table configuration after table resize. Should be called for rules created before table resize. If called for rules crated after table resize, API should return success, so application is free to call this API for all flows. ``` >> >> Rules created *before* resize must be updated. > > That part remains. The application must update > flow rules created before resize. > >> Rules created *after* resize not need to be updated, but if API accepts >> them and just returns a quick success, > > Calling update for new rules will return success without flow update. > >> this helps user and even user may >> prefer to not keep track of flows as before and after resize, > > The application now does not need to differentiate table flow rules. > All table flow rules must be updated after table resize. > >> >>> +/** >>> + * @warning >>> + * @b EXPERIMENTAL: this API may change without prior notice. >>> + * >>> + * Resume normal operational mode after table was resized and >>> + * table rules were updated for the new table configuration. >>> + * >>> + * @param port_id >>> + *   Port identifier of Ethernet device. >>> + * @param table >>> + *   Template table that undergoing resize operation. >>> + * @param error >>> + *   Perform verbose error reporting if not NULL. >>> + *   PMDs initialize this structure in case of error only. >>> + * >>> + * @return >>> + *   - (0) if success. >>> + *   - (-ENODEV) if *port_id* invalid. >>> + *   - (-ENOTSUP) if underlying device does not support this >>> functionality. >>> + *   - (-EINVAL) if there are rules that were not updated or >>> + *               *table* cannot complete table resize, >>> + *               unrecoverable error. >>> + */ >>> +__rte_experimental >>> +int >>> +rte_flow_template_table_resize_complete(uint16_t port_id, >>> +                                     struct rte_flow_template_table >>> *table, >>> +                                     struct rte_flow_error *error); >> >> I think I asked this before but perhaps missed the response, >> it is possible that user missed to update all flows and called this API, >> it will return -EINVAL, in this case it is not clear for user if there >> is a unrecoverable error or just need to update more flows. >> >> What do you think to send a different error for the case that there are >> flows not updated, so user can action on this information. >> >> > > A different error is good. > What about EBUSY ? > I don't know, can be EBUSY or EAGAIN. Or we can overload EEXIST as there are existing not updated flows.