From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2BB2FA0540;
	Wed, 21 Sep 2022 13:11:53 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BF28B4067C;
	Wed, 21 Sep 2022 13:11:52 +0200 (CEST)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id 1287C4014F
 for <dev@dpdk.org>; Wed, 21 Sep 2022 13:11:50 +0200 (CEST)
Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.57])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MXbH105BszlWrT;
 Wed, 21 Sep 2022 19:07:40 +0800 (CST)
Received: from [10.67.103.235] (10.67.103.235) by
 kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.31; Wed, 21 Sep 2022 19:11:47 +0800
Subject: Re: [PATCH v2 1/6] app/procinfo: add version dump
To: Stephen Hemminger <stephen@networkplumber.org>
References: <20220722091236.15469-1-liudongdong3@huawei.com>
 <20220920105148.7664-1-liudongdong3@huawei.com>
 <20220920105148.7664-2-liudongdong3@huawei.com>
 <20220920082124.315fb772@hermes.local>
CC: <dev@dpdk.org>, <reshma.pattan@intel.com>, <thomas@monjalon.net>,
 <ferruh.yigit@xilinx.com>, <andrew.rybchenko@oktetlabs.ru>, "Min Hu (Connor)"
 <humin29@huawei.com>, Maryam Tahhan <maryam.tahhan@intel.com>
From: Dongdong Liu <liudongdong3@huawei.com>
Message-ID: <f10ea6a7-97e8-b41b-7bff-95a6d5f1a241@huawei.com>
Date: Wed, 21 Sep 2022 19:11:47 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <20220920082124.315fb772@hermes.local>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.103.235]
X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To
 kwepemi500017.china.huawei.com (7.221.188.110)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Stephen

Many thanks for your review.
On 2022/9/20 23:21, Stephen Hemminger wrote:
> On Tue, 20 Sep 2022 18:51:42 +0800
> Dongdong Liu <liudongdong3@huawei.com> wrote:
>
>> From: "Min Hu (Connor)" <humin29@huawei.com>
>>
>> This patch add support for dump dpdk version and ethdev firmware version.
>>
>> The command is like:
>> dpdk-proc-info -a xxxx:xx:xx.x --file-prefix=xxx -- --show-version
>>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
>> ---
>
> Why mix DPDK and firmware version in one option?
Like ethtool -i command, one command can show kernel version
and ethdev firmware version.

ethtool -i eth0
driver: hns3
version: 5.13.0-rc4+
firmware-version: 1.20.0.17

>
> Why not use semi-standard convention of -V --version option for DPDK version
> and add --firmware-version option to show firmware.
Looks good, will do.

Thanks,
Dongdong
> .
>