From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C14C632A5 for ; Thu, 8 Dec 2016 17:45:04 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 08 Dec 2016 08:45:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,320,1477983600"; d="scan'208";a="910145254" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga003.jf.intel.com with ESMTP; 08 Dec 2016 08:45:00 -0800 To: Harish Patil , dev@dpdk.org References: <1480733039-13046-1-git-send-email-harish.patil@qlogic.com> <1480733039-13046-2-git-send-email-harish.patil@qlogic.com> Cc: Dept-EngDPDKDev@qlogic.com From: Ferruh Yigit Message-ID: Date: Thu, 8 Dec 2016 16:45:00 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1480733039-13046-2-git-send-email-harish.patil@qlogic.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/7] net/qede: refactor filtering code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Dec 2016 16:45:05 -0000 On 12/3/2016 2:43 AM, Harish Patil wrote: > The filter_config in qed_eth_ops_pass is a wrapper call driving all the > filtering configuration. This requires defining multiple structures and > passing different function arguments for each filter type which is > unnecessary. So as part of this refactoring we remove filter_config from > qed_eth_ops_pass and invoke base apis directly. Another change is to > use a singly list for unicast/multicast macs and thereby prevent duplicate singly linked list? > entries. > > This change is primarily intended to support future tunneling support > which makes use of existing L2 filtering/classifications. > > Fixes: 2ea6f76a ("qede: add core driver") What is fixed in this patch, isn't it a refactor? btw, all Fixes formats are wrong in the patchset, can you please use the git alias provided: http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body > > Signed-off-by: Harish Patil > --- <...>