From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7F2235599 for ; Tue, 14 Mar 2017 16:19:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1489504763; x=1521040763; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=Xln4Y2wUah//ohFMjh7N4H/94u9KdtO97q0ANcjakFA=; b=avGFkQQMTeH0x/FbyLaOcf8dKOG0m/+DzZncJNBnUKo4B3zP6rwPM2h0 TIR37NIS4I9dlVnabqG7d9c3XV2TuA==; Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2017 08:19:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,164,1486454400"; d="scan'208";a="76522658" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga006.fm.intel.com with ESMTP; 14 Mar 2017 08:19:21 -0700 To: "Lu, Wenzhuo" , "Legacy, Allain (Wind River)" References: <1489156701-185471-1-git-send-email-allain.legacy@windriver.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B56EE2A@shsmsx102.ccr.corp.intel.com> Cc: "dev@dpdk.org" From: Ferruh Yigit Message-ID: Date: Tue, 14 Mar 2017 15:19:21 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B56EE2A@shsmsx102.ccr.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/e1000: advertise offload capabilities for the EM PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Mar 2017 15:19:23 -0000 On 3/13/2017 3:15 AM, Lu, Wenzhuo wrote: > Hi, > >> -----Original Message----- >> From: Allain Legacy [mailto:allain.legacy@windriver.com] >> Sent: Friday, March 10, 2017 10:38 PM >> To: Lu, Wenzhuo >> Cc: dev@dpdk.org >> Subject: [PATCH] net/e1000: advertise offload capabilities for the EM PMD >> >> The hardware offload capabilities are not being advertised for the EM PMD. >> Because of this, applications that only enable these features if the device >> advertises them will never do so. >> >> Normally this is not an issue since normal packet processing should work even if >> hardware offload is not available. But, in older versions of Virtual Box the e1000 >> device emulation (Intel PRO/1000 MT Desktop 82540EM) assumes that it should >> enable VLAN stripping even if the driver does not request it. This means that any >> ingress packets that have a VLAN tag will be stripped. Since the application did >> not request to enable VLAN stripping it is not expecting these packets so they >> are not processed as VLAN packets. >> >> Regardless of the Virtual Box issue, the driver should be advertising supported >> capabilities as is done in other drivers. >> >> Signed-off-by: Allain Legacy > Acked-by: Wenzhuo Lu Applied to dpdk-next-net/master, thanks.