From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id CF59E1D7 for <dev@dpdk.org>; Wed, 20 Dec 2017 02:51:24 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2017 17:51:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,429,1508828400"; d="scan'208";a="13218214" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.69]) ([10.241.225.69]) by FMSMGA003.fm.intel.com with ESMTP; 19 Dec 2017 17:51:23 -0800 To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org References: <20171219063840.18981-1-stephen@networkplumber.org> From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <f1355dc4-bce7-eba6-7374-5cd9ca31424d@intel.com> Date: Tue, 19 Dec 2017 17:51:22 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171219063840.18981-1-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 00/11] Dynamic logging (just do it) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 20 Dec 2017 01:51:25 -0000 On 12/18/2017 10:38 PM, Stephen Hemminger wrote: > This patch set implements dynamic logging for 11 drivers. > All these patches are compile tested only. I don't have > access to most of this hardware. > > It makes more sense to "just do it" for dynamic logging rather > than keeping TODO lists in the documentation and expecting the > vendors to fix their own code. The advantage of common repository > is that global changes can be done. Hi Stephen, Thank you for the update, there a few minor comments in relevant patches, except from them set lgtm. Overall do you think keeping todo list is a bad idea? There are a few more issues like this and I am not sure how to communicate them with PMD maintainers, any suggestion is welcome. > > Stephen Hemminger (11): > avp: implement dynamic logging > bnx2x: implement dynamic logging > vmxnet3: implement dynamic logging > ixgbe: implement dynamic logging > e1000: implement dynamic logging > virtio: implement dynamic logging > nfp: implement dynamic logging > fm10k: implement dynamic logging > ena: implement dynamic logging > qede: implement dynamic logging > lio: implement dynamic logging <...>