From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Wang, ShougangX" <shougangx.wang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Rong, Leyi" <leyi.rong@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/iavf: unify Rx ptype table
Date: Mon, 23 Mar 2020 16:02:38 +0000 [thread overview]
Message-ID: <f1538dd85b6c4c1584b7344cb86fadd3@intel.com> (raw)
In-Reply-To: <bac74c24653a45a9917cd96d8a1be4ff@intel.com>
> -----Original Message-----
> From: Wang, ShougangX <shougangx.wang@intel.com>
> Sent: Monday, March 23, 2020 4:16 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org
> Cc: Rong, Leyi <leyi.rong@intel.com>
> Subject: RE: [PATCH] net/iavf: unify Rx ptype table
>
> > -----Original Message-----
> > From: Wu, Jingjing
> > Sent: Monday, March 23, 2020 10:09 AM
> > To: Wang, ShougangX <shougangx.wang@intel.com>; dev@dpdk.org
> > Cc: Rong, Leyi <leyi.rong@intel.com>
> > Subject: RE: [PATCH] net/iavf: unify Rx ptype table
> >
> >
> >
> > -----Original Message-----
> > From: Wang, ShougangX
> > Sent: Friday, March 6, 2020 10:24 AM
> > To: dev@dpdk.org
> > Cc: Rong, Leyi <leyi.rong@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> > Wang, ShougangX <shougangx.wang@intel.com>
> > Subject: [PATCH] net/iavf: unify Rx ptype table
> >
> > From: Wang Shougang <shougangx.wang@intel.com>
> >
> > This patch unified the Rx ptype table.
> >
> > Signed-off-by: Wang Shougang <shougangx.wang@intel.com>
> > ---
> > drivers/net/iavf/iavf.h | 3 +-
> > drivers/net/iavf/iavf_ethdev.c | 3 +
> > drivers/net/iavf/iavf_rxtx.c | 604 +++++++++++++++++++++++---
> > drivers/net/iavf/iavf_rxtx.h | 3 +
> > drivers/net/iavf/iavf_rxtx_vec_avx2.c | 21 +-
> > drivers/net/iavf/iavf_rxtx_vec_sse.c | 25 +-
> > 6 files changed, 561 insertions(+), 98 deletions(-)
> >
> > diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h index
> > fe25d807c..526040c6e 100644
> > --- a/drivers/net/iavf/iavf.h
> > +++ b/drivers/net/iavf/iavf.h
> > @@ -119,7 +119,7 @@ struct iavf_info {
> > uint16_t rxq_map[IAVF_MAX_MSIX_VECTORS]; };
> >
> > -#define IAVF_MAX_PKT_TYPE 256
> > +#define IAVF_MAX_PKT_TYPE 1024
> >
> > /* Structure to store private data for each VF instance. */ struct iavf_adapter
> > { @@ -131,6 +131,7 @@ struct iavf_adapter {
> > /* For vector PMD */
> > bool rx_vec_allowed;
> > bool tx_vec_allowed;
> > + const uint32_t *ptype_tbl;
> > bool stopped;
> > };
> >
> > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index
> > 34913f9c4..ee9f82249 100644
> > --- a/drivers/net/iavf/iavf_ethdev.c
> > +++ b/drivers/net/iavf/iavf_ethdev.c
> > @@ -1334,6 +1334,9 @@ iavf_dev_init(struct rte_eth_dev *eth_dev)
> > return -1;
> > }
> >
> > + /* set default ptype table */
> > + adapter->ptype_tbl = iavf_get_default_ptype_table();
> > +
> > As the ptype table is static, is that necessary to define a function to get it? Is
> > there any consideration for future extension?
>
> Yes, I'm used to encapsulating it as a function for future extension.
> Do I need to set it as a global table instead of encapsulating in function?
Is there any chance the default ptype table change? If so, I think you can keep it as a function.
>
> Thanks.
> Shougang
next prev parent reply other threads:[~2020-03-23 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 2:24 Shougang Wang
2020-03-12 9:02 ` Rong, Leyi
2020-03-16 1:49 ` Ye Xiaolong
2020-03-23 2:09 ` Wu, Jingjing
[not found] ` <bac74c24653a45a9917cd96d8a1be4ff@intel.com>
2020-03-23 16:02 ` Wu, Jingjing [this message]
2020-03-24 8:56 ` Wu, Jingjing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1538dd85b6c4c1584b7344cb86fadd3@intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=leyi.rong@intel.com \
--cc=shougangx.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).