From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 5A66B1B1B9 for ; Mon, 16 Apr 2018 09:27:50 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DC4BF40241FB; Mon, 16 Apr 2018 07:27:48 +0000 (UTC) Received: from [10.36.112.56] (ovpn-112-56.ams2.redhat.com [10.36.112.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 718262166BAD; Mon, 16 Apr 2018 07:27:47 +0000 (UTC) To: Thomas Monjalon , Fan Zhang , ferruh.yigit@intel.com Cc: dev@dpdk.org, jianjay.zhou@huawei.com, jianfeng.tan@intel.com, pawelx.wodkowski@intel.com References: <20180404142504.31836-1-roy.fan.zhang@intel.com> <20180405160137.56413-8-roy.fan.zhang@intel.com> <1845545.r90AWaGVlL@xps> <1635741.7WSiDOFoul@xps> From: Maxime Coquelin Message-ID: Date: Mon, 16 Apr 2018 09:27:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1635741.7WSiDOFoul@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 16 Apr 2018 07:27:48 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 16 Apr 2018 07:27:48 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v7 7/8] examples/vhost_crypto: add vhost crypto sample application X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 07:27:50 -0000 On 04/15/2018 07:35 PM, Thomas Monjalon wrote: > 15/04/2018 16:34, Thomas Monjalon: >> Hi, >> >> 05/04/2018 18:01, Fan Zhang: >>> This patch adds vhost_crypto sample application to DPDK. >>> >>> Signed-off-by: Fan Zhang >>> --- >>> examples/vhost_crypto/Makefile | 32 +++ >>> examples/vhost_crypto/main.c | 541 ++++++++++++++++++++++++++++++++++++++ >>> examples/vhost_crypto/meson.build | 14 + >>> 3 files changed, 587 insertions(+) >> >> There are 3 misses: >> >> - not in examples/Makefile >> - not in MAINTAINERS >> - no documentation in doc/guides/sample_app_ug/ >> >> It won't be accepted in master as-is. > > The doc is (curiously) in the next patch. I will move it here. > I will also fix the Makefile and the MAINTAINERS file: > > ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y) > DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += vhost_crypto > endif > > Vhost-user > M: Maxime Coquelin > M: Jianfeng Tan > T: git://dpdk.org/next/dpdk-next-virtio > F: lib/librte_vhost/ > [...] > F: examples/vhost_crypto/ > > > Ferruh, Maxime, I hope you agree with this last-minute fix. > > Agreed. thanks. Maxime