DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH v1] net/virtio: simplify variable name
@ 2020-06-24  8:45 Joyce Kong
  2020-06-24 19:45 ` Honnappa Nagarahalli
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Joyce Kong @ 2020-06-24  8:45 UTC (permalink / raw)
  To: jerinj, maxime.coquelin, zhihong.wang, xiaolong.ye, ruifeng.wang,
	honnappa.nagarahalli, phil.yang
  Cc: dev, nd

Virtio_hw *hw has been pointed to vq->hw, it is better to use
hw instead of vq->hw in later code.

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
---
 drivers/net/virtio/virtio_rxtx_simple_neon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/virtio/virtio_rxtx_simple_neon.c b/drivers/net/virtio/virtio_rxtx_simple_neon.c
index 363e2b330..8e6fa1fd7 100644
--- a/drivers/net/virtio/virtio_rxtx_simple_neon.c
+++ b/drivers/net/virtio/virtio_rxtx_simple_neon.c
@@ -71,8 +71,8 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
 	 */
 	uint16x8_t len_adjust = {
 		0, 0,
-		(uint16_t)vq->hw->vtnet_hdr_size, 0,
-		(uint16_t)vq->hw->vtnet_hdr_size,
+		(uint16_t)hw->vtnet_hdr_size, 0,
+		(uint16_t)hw->vtnet_hdr_size,
 		0,
 		0, 0
 	};
-- 
2.27.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v1] net/virtio: simplify variable name
  2020-06-24  8:45 [dpdk-dev] [PATCH v1] net/virtio: simplify variable name Joyce Kong
@ 2020-06-24 19:45 ` Honnappa Nagarahalli
  2020-06-28  4:57 ` Xia, Chenbo
  2020-06-30  7:27 ` Maxime Coquelin
  2 siblings, 0 replies; 5+ messages in thread
From: Honnappa Nagarahalli @ 2020-06-24 19:45 UTC (permalink / raw)
  To: Joyce Kong, jerinj, maxime.coquelin, zhihong.wang, xiaolong.ye,
	Ruifeng Wang, Phil Yang
  Cc: dev, nd, Honnappa Nagarahalli, nd

<snip>

> Subject: [PATCH v1] net/virtio: simplify variable name
> 
> Virtio_hw *hw has been pointed to vq->hw, it is better to use hw instead of
> vq->hw in later code.
> 
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> ---
>  drivers/net/virtio/virtio_rxtx_simple_neon.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtio_rxtx_simple_neon.c
> b/drivers/net/virtio/virtio_rxtx_simple_neon.c
> index 363e2b330..8e6fa1fd7 100644
> --- a/drivers/net/virtio/virtio_rxtx_simple_neon.c
> +++ b/drivers/net/virtio/virtio_rxtx_simple_neon.c
> @@ -71,8 +71,8 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf
> **rx_pkts,
>  	 */
>  	uint16x8_t len_adjust = {
>  		0, 0,
> -		(uint16_t)vq->hw->vtnet_hdr_size, 0,
> -		(uint16_t)vq->hw->vtnet_hdr_size,
> +		(uint16_t)hw->vtnet_hdr_size, 0,
> +		(uint16_t)hw->vtnet_hdr_size,
>  		0,
>  		0, 0
>  	};
> --
> 2.27.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v1] net/virtio: simplify variable name
  2020-06-24  8:45 [dpdk-dev] [PATCH v1] net/virtio: simplify variable name Joyce Kong
  2020-06-24 19:45 ` Honnappa Nagarahalli
@ 2020-06-28  4:57 ` Xia, Chenbo
  2020-06-30  7:27 ` Maxime Coquelin
  2 siblings, 0 replies; 5+ messages in thread
From: Xia, Chenbo @ 2020-06-28  4:57 UTC (permalink / raw)
  To: Joyce Kong, jerinj, maxime.coquelin, Wang, Zhihong, ruifeng.wang,
	honnappa.nagarahalli, phil.yang
  Cc: dev, nd


> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Joyce Kong
> Sent: Wednesday, June 24, 2020 4:45 PM
> To: jerinj@marvell.com; maxime.coquelin@redhat.com; Wang, Zhihong
> <zhihong.wang@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>;
> ruifeng.wang@arm.com; honnappa.nagarahalli@arm.com; phil.yang@arm.com
> Cc: dev@dpdk.org; nd@arm.com
> Subject: [dpdk-dev] [PATCH v1] net/virtio: simplify variable name
> 
> Virtio_hw *hw has been pointed to vq->hw, it is better to use hw instead of vq-
> >hw in later code.
> 
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> ---
>  drivers/net/virtio/virtio_rxtx_simple_neon.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtio_rxtx_simple_neon.c
> b/drivers/net/virtio/virtio_rxtx_simple_neon.c
> index 363e2b330..8e6fa1fd7 100644
> --- a/drivers/net/virtio/virtio_rxtx_simple_neon.c
> +++ b/drivers/net/virtio/virtio_rxtx_simple_neon.c
> @@ -71,8 +71,8 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf
> **rx_pkts,
>  	 */
>  	uint16x8_t len_adjust = {
>  		0, 0,
> -		(uint16_t)vq->hw->vtnet_hdr_size, 0,
> -		(uint16_t)vq->hw->vtnet_hdr_size,
> +		(uint16_t)hw->vtnet_hdr_size, 0,
> +		(uint16_t)hw->vtnet_hdr_size,
>  		0,
>  		0, 0
>  	};
> --
> 2.27.0

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v1] net/virtio: simplify variable name
  2020-06-24  8:45 [dpdk-dev] [PATCH v1] net/virtio: simplify variable name Joyce Kong
  2020-06-24 19:45 ` Honnappa Nagarahalli
  2020-06-28  4:57 ` Xia, Chenbo
@ 2020-06-30  7:27 ` Maxime Coquelin
  2020-06-30  7:41   ` Maxime Coquelin
  2 siblings, 1 reply; 5+ messages in thread
From: Maxime Coquelin @ 2020-06-30  7:27 UTC (permalink / raw)
  To: Joyce Kong, jerinj, zhihong.wang, xiaolong.ye, ruifeng.wang,
	honnappa.nagarahalli, phil.yang
  Cc: dev, nd



On 6/24/20 10:45 AM, Joyce Kong wrote:
> Virtio_hw *hw has been pointed to vq->hw, it is better to use
> hw instead of vq->hw in later code.
> 
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> ---
>  drivers/net/virtio/virtio_rxtx_simple_neon.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtio_rxtx_simple_neon.c b/drivers/net/virtio/virtio_rxtx_simple_neon.c
> index 363e2b330..8e6fa1fd7 100644
> --- a/drivers/net/virtio/virtio_rxtx_simple_neon.c
> +++ b/drivers/net/virtio/virtio_rxtx_simple_neon.c
> @@ -71,8 +71,8 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
>  	 */
>  	uint16x8_t len_adjust = {
>  		0, 0,
> -		(uint16_t)vq->hw->vtnet_hdr_size, 0,
> -		(uint16_t)vq->hw->vtnet_hdr_size,
> +		(uint16_t)hw->vtnet_hdr_size, 0,
> +		(uint16_t)hw->vtnet_hdr_size,
>  		0,
>  		0, 0
>  	};
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v1] net/virtio: simplify variable name
  2020-06-30  7:27 ` Maxime Coquelin
@ 2020-06-30  7:41   ` Maxime Coquelin
  0 siblings, 0 replies; 5+ messages in thread
From: Maxime Coquelin @ 2020-06-30  7:41 UTC (permalink / raw)
  To: Joyce Kong, jerinj, zhihong.wang, xiaolong.ye, ruifeng.wang,
	honnappa.nagarahalli, phil.yang
  Cc: dev, nd



On 6/30/20 9:27 AM, Maxime Coquelin wrote:
> 
> 
> On 6/24/20 10:45 AM, Joyce Kong wrote:
>> Virtio_hw *hw has been pointed to vq->hw, it is better to use
>> hw instead of vq->hw in later code.
>>
>> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
>> ---
>>  drivers/net/virtio/virtio_rxtx_simple_neon.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/virtio/virtio_rxtx_simple_neon.c b/drivers/net/virtio/virtio_rxtx_simple_neon.c
>> index 363e2b330..8e6fa1fd7 100644
>> --- a/drivers/net/virtio/virtio_rxtx_simple_neon.c
>> +++ b/drivers/net/virtio/virtio_rxtx_simple_neon.c
>> @@ -71,8 +71,8 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
>>  	 */
>>  	uint16x8_t len_adjust = {
>>  		0, 0,
>> -		(uint16_t)vq->hw->vtnet_hdr_size, 0,
>> -		(uint16_t)vq->hw->vtnet_hdr_size,
>> +		(uint16_t)hw->vtnet_hdr_size, 0,
>> +		(uint16_t)hw->vtnet_hdr_size,
>>  		0,
>>  		0, 0
>>  	};
>>
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Thanks,
> Maxime
> 

Applied to dpdk-next-virtio/master

Thanks,
Maxime


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-24  8:45 [dpdk-dev] [PATCH v1] net/virtio: simplify variable name Joyce Kong
2020-06-24 19:45 ` Honnappa Nagarahalli
2020-06-28  4:57 ` Xia, Chenbo
2020-06-30  7:27 ` Maxime Coquelin
2020-06-30  7:41   ` Maxime Coquelin

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox