From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE620A00C5; Thu, 30 Apr 2020 11:09:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8CFDA1DA24; Thu, 30 Apr 2020 11:09:39 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 9A70D1DA23; Thu, 30 Apr 2020 11:09:38 +0200 (CEST) IronPort-SDR: KOpfCfsOyQZVT1LUnm6cw01Mx5YLkhnP0Un5fc2LAjIr0zt+TYKzsI0ZiZBJCI9vyjDa3LA9F7 AnoJWxdTLENg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2020 02:09:37 -0700 IronPort-SDR: 84HCC/YP2gbKMcIsMntip1R7qf9zCKeSjrwRrCAPRCW5uyv486D3KBaOJjofqfqhk65q71G9IB Y1xZOAhomN5w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,334,1583222400"; d="scan'208";a="293498898" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 30 Apr 2020 02:09:37 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Apr 2020 02:09:34 -0700 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 30 Apr 2020 17:09:31 +0800 Received: from shsmsx604.ccr.corp.intel.com ([10.109.6.214]) by SHSMSX604.ccr.corp.intel.com ([10.109.6.214]) with mapi id 15.01.1713.004; Thu, 30 Apr 2020 17:09:31 +0800 From: "Xiao, QimaiX" To: "Jiang, JunyuX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Jiang, JunyuX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ice: fix core dumped issue in switch filter Thread-Index: AQHWHfo7N1VkYQGLEkqKmTi+t92OMaiRXDbw Date: Thu, 30 Apr 2020 09:09:31 +0000 Message-ID: References: <20200429072516.65403-1-junyux.jiang@intel.com> In-Reply-To: <20200429072516.65403-1-junyux.jiang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ice: fix core dumped issue in switch filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: Xiao, QimaiX Regards, Xiao Qimai > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Junyu Jiang > Sent: Wednesday, April 29, 2020 3:25 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Jiang, JunyuX > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ice: fix core dumped issue in switch filt= er >=20 > The number of queues in queue group should be checked before using it to > avoid NULL pointer. This patch fixed the issue. >=20 > Fixes: 47d460d63233 ("net/ice: rework switch filter") > Cc: stable@dpdk.org >=20 > Signed-off-by: Junyu Jiang > --- > drivers/net/ice/ice_switch_filter.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/ice/ice_switch_filter.c > b/drivers/net/ice/ice_switch_filter.c > index 179430136..c2762e331 100644 > --- a/drivers/net/ice/ice_switch_filter.c > +++ b/drivers/net/ice/ice_switch_filter.c > @@ -1296,6 +1296,8 @@ ice_switch_parse_action(struct ice_pf *pf, > switch (action_type) { > case RTE_FLOW_ACTION_TYPE_RSS: > act_qgrop =3D action->conf; > + if (act_qgrop->queue_num <=3D 1) > + goto error; > rule_info->sw_act.fltr_act =3D > ICE_FWD_TO_QGRP; > rule_info->sw_act.fwd_id.q_id =3D > -- > 2.17.1