From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH v2] devtools: fix 32-bits build
Date: Wed, 11 Nov 2020 12:34:15 +0000 [thread overview]
Message-ID: <f1bcef74-cb7a-04fb-5485-452c0576ad17@intel.com> (raw)
In-Reply-To: <3084224.aG0oiDBsVl@thomas>
On 11/9/2020 9:02 PM, Thomas Monjalon wrote:
> 09/11/2020 18:44, Thomas Monjalon:
>> 09/11/2020 18:20, Thomas Monjalon:
>>> 09/11/2020 18:15, Ferruh Yigit:
>>>> On 11/9/2020 5:01 PM, Thomas Monjalon wrote:
>>>>> 09/11/2020 17:48, Ferruh Yigit:
>>>>>> I can send a new version to reset 'CUSTOM_PKG_CONFIG_PATH',
>>>>>> what is the intention/plan with the config file?
>>>>>
>>>>> You should use a config file to set PKG_CONFIG_PATH, PATH,
>>>>> DPDK_MESON_OPTIONS, etc accordingly to build with all
>>>>> your non-installed dependencies.
>>>>> CUSTOM_PKG_CONFIG_PATH is a way to avoid using the config file
>>>>> in a single case.
>>>>>
>>>>
>>>> Either use 'PKG_CONFIG_PATH' environment variable or a config file, both has the
>>>> same problem that we need two different pkg config path, one for 64bit and one
>>>> for 32bit.
>>>
>>> No. In the config file, you can set the right value by testing $DPDK_TARGET.
>>> Note: the config file is a shell script.
>>>
>>>> v2 of this patch provides a way to use correct one when needed.
>>>
>>> This is not a global fix.
>>>
>>>> Moving the default values from system environment or script hardcoded values to
>>>> a config file is something else and can be done later, what do you think?
>>>
>>> The root cause of your issue is using variables from the environment.
>>> The global fix is then to reset them all,
>>> while keeping a default value for PATH which is not only for compilation config.
>>
>> This is what we have currently:
>>
>> export PATH=$default_path
>> export PKG_CONFIG_PATH=$default_pkgpath
>> export CPPFLAGS=$default_cppflags
>> export CFLAGS=$default_cflags
>> export LDFLAGS=$default_ldflags
>> unset DPDK_MESON_OPTIONS
>>
>> The PATH needs to be restored at each run to avoid using a wrong toolchain.
>> The default value is best taken from the start environment,
>> at the condition no conflicting toolchain is already set.
>>
>> PKG_CONFIG_PATH is specific to each target.
>> I believe it can be reset at each run and configured
>> only from the config file.
>> A default PKG_CONFIG_PATH for all targets does not make any sense.
>>
>> CPPFLAGS, CFLAGS and LDFLAGS could be used to customize some options
>> applying to all targets in some build tests without touching the config file.
>>
>> DPDK_MESON_OPTIONS could be the same as CFLAGS: take a global default from env
>> and restore the value at each run, so each target can have additional options
>> from the config file.
>
> The implementation of the above is done in this patch:
> https://patches.dpdk.org/patch/83861/
>
>
self nack this patch on behalf of above one.
prev parent reply other threads:[~2020-11-11 12:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 13:00 [dpdk-dev] [PATCH] " Ferruh Yigit
2020-11-09 13:19 ` Thomas Monjalon
2020-11-09 13:24 ` Ferruh Yigit
2020-11-09 13:35 ` Bruce Richardson
2020-11-09 13:51 ` Thomas Monjalon
2020-11-09 14:55 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2020-11-09 15:28 ` Thomas Monjalon
2020-11-09 15:44 ` Bruce Richardson
2020-11-09 16:14 ` Thomas Monjalon
2020-11-09 16:19 ` Bruce Richardson
2020-11-09 16:48 ` Ferruh Yigit
2020-11-09 17:01 ` Thomas Monjalon
2020-11-09 17:15 ` Ferruh Yigit
2020-11-09 17:20 ` Thomas Monjalon
2020-11-09 17:44 ` Thomas Monjalon
2020-11-09 21:02 ` Thomas Monjalon
2020-11-11 12:34 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1bcef74-cb7a-04fb-5485-452c0576ad17@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).