From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65BAEA00C3; Tue, 29 Nov 2022 19:23:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A5F440693; Tue, 29 Nov 2022 19:23:31 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2043.outbound.protection.outlook.com [40.107.212.43]) by mails.dpdk.org (Postfix) with ESMTP id 743F440691; Tue, 29 Nov 2022 19:23:29 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IC+9gdivjjDUUzKf0YOTSu3CWjhE0EsW1KV+U2Zx+z5AltWulUAS/S9cJ4GwpYXa1SshVL+RqIkSTWUJbBzyTIDAf0lAos9Zz3AMvz+ba8lsG4gyexgEFoSQ0f2Y0SklmZmsO8dj4AN3h1ar+HohPDbW4Zm7hRVPWEGhHXyhabLnj4UrUHmZsaPQ67KPVaisZtwGaoRP97Qdj5XhgcnUNCkwwgwVVwUtdmPoQOEfZgVv4kT5GPK4fNWUxH5yLnwVWSt9Iv02v2pnhHcq9wy8CXz/dBa63CzMmnJp5yaEs52aqpq63gU0xN1N+h9lsGngA4Z2oyONDiFEWQi2Ym0c9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9kTZ42sSQwu+fgyjGjB9ZGOFsOltwh7LLGilfV3MJqw=; b=QKpTmHiabU5Og+ZP++pyfxdRWn73xonaGITRAH/4JGqVJH/vBqGohmg4YCcKZzQ92GkXDK+W0IajNE5+uHYjJhvqg7CNnk3pcwbOceKPfeY6kvmrSlX5ydBDr3Ay8ILRGBELaiJHwP7NuUfiDfP6fHhYeFdz+LLM5Zqau197aj4U+dgyUYFnM+eoFeCydcfSfxccOFw2VUGCwAExeWkB6HmUNP02L/Clp9s1zksKy7RT414KXCQdAmnzcdCGNc82PaLzMLaoFgkpzpiPmUt9twKLtsj4RgnIy7Ye133ApXdwOtB4k0FCJNiyyEFCLcDbiq48HktXzjHiVo0m/KC84w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9kTZ42sSQwu+fgyjGjB9ZGOFsOltwh7LLGilfV3MJqw=; b=P1K/eKeCMg/TZohnuONcM/G3bJIgmbJbh7YLmHigmq6BS1sulKL2rtnY8kzmn+tfscYzoYZ8eyWLdGAI7r3dDBjm8MXVTYi83vRtEZF4sbqq6SNe/lCUs8+J2FLlaIj4KzOpMc8e/iUttY1FbqWoEhJCWihYJ0D8hY+A0RJFTHU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB7629.namprd12.prod.outlook.com (2603:10b6:8:13e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 18:23:26 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%9]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 18:23:26 +0000 Message-ID: Date: Tue, 29 Nov 2022 18:23:21 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] drivers: fix symbol exports when map is omitted Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: stable@dpdk.org, Luca Boccassi , Bruce Richardson , =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= References: <20221129140032.35940-1-david.marchand@redhat.com> From: Ferruh Yigit In-Reply-To: <20221129140032.35940-1-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0207.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB7629:EE_ X-MS-Office365-Filtering-Correlation-Id: 58826143-f3b6-4b3b-ecea-08dad236cebe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EVGI0onDRbv5obbHtZ1k8gNbX7bqh8OJ+xkDOnA59nWVhJJCMkvV7sj1vY9dWaSee/cPCUaNGJyvPhLePtqyVB82CrIheCtwdgAT5dP3xRGW99y61TjpHgxGJcF0I0V6DuMmO6BD/lgltMB0WY0l+2gv68RXpVYe/tpmBLqI6NX3Uni4sGDEhsanO+9MsUzkXZVC1GGBShISlbBv6TwtaArfuIbobzzMs7qDhcb2M4eZuKGUOzvgT0cfmIZkj82U4JQgx1Vs1FoZiaOjSrJGfn8VHCIDPx1FBXV+Pxb/5KHSiIZLCv7hEFI1NHbqAu+2iw+eeuoXhLwYG3aMlkHViUCmVZ67OGaeM8tel2mhajMnYyYt5RjPrauTL6jHQx0H5QzI1xs8QNg0zOEL+x4mLU6Po5lPBejdUDeRmpBzBay3wXKnKa4ICQl4kNe42XwSC6Koz5vib1qoRkQAu8ElmfPq3wFtWZi8q7dYQXcdIw7fcgFX1m/gDLFEehDv73h1n1FmyRhtPn3uruZs+9ItaZKbpEVl2O/ULKYR+pwq15nCDK9l6VxvtXFlqrayWNeQ0CqZixALm9oWMSDlIxNbRRCDKK4SXXfZlSotthz+PkSnI+zPo2O44AJjBJQg3zVxjAyhlrHVAY558X3OTXpRgZ65zDpTtEioVO8z6izGhvBz2pAPCfU7iaHPp115Oj5xOEfmM6wfXPhVUoXvID5B31f6Enl7W3/jC3pQJbvLnzI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(396003)(136003)(376002)(39860400002)(366004)(451199015)(54906003)(2616005)(6512007)(26005)(53546011)(36756003)(186003)(316002)(6486002)(6666004)(478600001)(45080400002)(38100700002)(31696002)(86362001)(83380400001)(5660300002)(6506007)(2906002)(44832011)(31686004)(4326008)(66556008)(66476007)(8676002)(66946007)(8936002)(41300700001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkZVYnN3YTVzR0liV2N5VWRsN2hYdGcvUkU0OVJ4dm83enRkVUVjZ0haM21m?= =?utf-8?B?aWRSWUNtRGNDTWpiZEI2N0k0cUFIWTlIT0ZDbGZqM01NOEFaK1RIdi9hOTFn?= =?utf-8?B?emJuOXM2dlNLdlZGQWwxaGlUa1hveWtJdWdXeTJOVnA0ZnpWTjFLWTRSZHBT?= =?utf-8?B?OVRYNFBlN3pRV0tsOTcrb0JRNlZwR00wVzhzQkRkWk9TMG9HdXRrMFlLUmx2?= =?utf-8?B?QW0vZXcrajdiMXI2S3lUVk1udVR5VHVPeUFWQVNnK29RTFFWM3VaREsvc3I0?= =?utf-8?B?KzgrVWQvZlVDbDAvKzNhT2dkZUFXUUlUZjd5clRFNlg4aHJlcFJlS2FTd0M5?= =?utf-8?B?ejJheFd4TmhHdlh1V005eVdaUnJrSnZVLzQzY2hXNmFTZ24xQk1YM29YZmxM?= =?utf-8?B?QUt4VkUwRDh0M1hBcGhHKzdDbzRzN0dncnpEbWtzdjUrTEExRmIyTHJtOVVv?= =?utf-8?B?TEIrYTNkSG8yWlJRam1ZVlZoRDNRNTZzUzJUR2JnUlBFYXAzQVJBV3p3a1Rt?= =?utf-8?B?TStRTU1icG5sZmhLZ2Mrd25ZRkwrYWc0a0ZTVFJ1Y0xnLzh5VUVjU1BVSFdI?= =?utf-8?B?RWhsd2Y5c29Zb09HMmg1L0Q3TlUxdVFZVkwxcWN6QlN3dm5Fd2Nnb1FidW5O?= =?utf-8?B?c1E0OFBERnY5bHhMdzV4Rm5mNWVJVzR0dEhESWZxN0ZKVi94aUVGdmNFUHNT?= =?utf-8?B?T3gyQ2xoMHhSYmJybTJpYlVtdkdBVU01UERVcUNPZVRobDFQb1ZEb2RDcjZh?= =?utf-8?B?ZjU5aXIvNHFuaENsVVljY25Cb01zeTNFTlY0N2dHek9uSHdUTUU2eUNxdHhZ?= =?utf-8?B?LzRqY3NuRzh6eFh0V2oxcWNrTG03a1JGOERudzJiaWlBZFFZM1dtbkVIcmNR?= =?utf-8?B?NVJFMVpWRTZIdms2M3FpclhnaFdVK2FNYXBsZjQyZHE5MGZPbGxNeXo5dHh4?= =?utf-8?B?cUd1dmlXaDZrS0FpdmRoNVcyNXlobXFOc3cvQm5TZVpRNUphOGloNzQ0cy9k?= =?utf-8?B?VVQ0d3VOdkZtNlVSZnVsS1JxaG5WOEJUOUtneE53K2pRZnBaNFZUTjFMRlhD?= =?utf-8?B?VndNYjVieGNXRUFPMTNSQzhvWFhBMURjeGJ1cDJOdGVzOVVYTFE2Rm5RU09n?= =?utf-8?B?WjZEZTZSU1dxRmdiOTI2bkxFZTJYcU1VcmdMZkhGaW5oU3dHY1AvSC9Uc2VH?= =?utf-8?B?RUpiOVFubGJ6bmdMQ3NjSkc3cDdhWXlWdmdyV0krZ2NXeG42RmExWVQ0Nit3?= =?utf-8?B?TFFpd0RaWkFMVnMzd3oyT3piRXR0aXdlamcvc0pOd1VhRS9DVUxHcGVKTWph?= =?utf-8?B?R3hLanRMTWQ4NDRESWVpRHZGUGU1S1JYTzFDRnliSFJJdE0vcFA2a2lKUjlm?= =?utf-8?B?SldFTEZjTUd5L3c4WE5XRDQ0NGg0azN2QzJmSGM2Zk1vb0NRUU9TNUZucHJG?= =?utf-8?B?M1BYaWkrZ2J0MGU1ZnJtL2Q5cUUvN0NUbG1iTG1QN0RObkFsRkVjK3NuWHp4?= =?utf-8?B?c3Q3b04zbXdtZzFNNmVMV2JZNjBwenFsQ2lIdUtibnFNZzZiRXZWaFhUQm11?= =?utf-8?B?UEJYVTZRaGJ5SjkvYkIyVzJ5ZHB5cXFuZTNYR0VsaEw5MHJiTngrU0pGa25q?= =?utf-8?B?Mmh6YTJsZzVzS2VLS1k3TlFpQ2xIUXN5ZnZSNmhtWERDVFNqb2VacDlTZ3BW?= =?utf-8?B?aXRtL2NTazRVcDk4aFhPaFFGekh1c2QvM21pUmhjZk0zK25YQWI0L0VWdGp4?= =?utf-8?B?SHhqTTVVZTR2UlN0ZTNHQ1BUVnJjYU5sakM0MEFkeTM4VmtxcHdFZUU0K2Fo?= =?utf-8?B?Q245ZmlXd0pvQWdZVzJwdkJJeEFYcFJodU5yR2JpOGlQWC9nTFpyY2V5NkRY?= =?utf-8?B?dGR2RC9hL3l3YmVXZnVFNForU0dSVHJ6N2F3aFFzVlN6OE5uaTR5bzNpVE5w?= =?utf-8?B?djFUUVV4L0xpTkhadElwRFBqZnNndVlhSnVKc1BNT29FY3pIa2c5Q1kwSE1l?= =?utf-8?B?eGFpUSs3K1dxRmJhSjRnQll2cnJjQTZFTDNlclhJT2NMMXlpUVQ4dmZIUHpa?= =?utf-8?B?K2Q3bnBBR094aFNxVFVSblA3eUlXZHZPZ0lOdStFZmtpTlNIK1JHdXRZbHl3?= =?utf-8?Q?2s29S7zbX8dtrnARyelt9rLUF?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58826143-f3b6-4b3b-ecea-08dad236cebe X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 18:23:26.7857 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DozknncjLzL5loXZI/xVtpmaM/0JqjIx7KBY+SWOIF25kqsxrVXD1l3BJYdrwjzx X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7629 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/29/2022 2:00 PM, David Marchand wrote: > ld exports any global symbol by default if no version script is passed. > As a consequence, the incriminated change let any public symbol leak > out of the driver shared libraries. > > Hide again those symbols by providing a default map file which > unexports any global symbol using a local: * catchall statement. > I assume this will cause warnings for ABI check scripts, how can we prevent the warnings? > The check on symbols is skipped for this default map file as it is > intentionnally an empty map (see commit b67bdda86cd4 ("devtools: catch > empty symbol maps")) and there is nothing to check in it. > How it is skipped, './devtools/check-symbol-maps.sh' still complains about 'drivers/version.map' for me. > While at it, move Windows specific objects where needed for better > readability. > +1 > Fixes: 7dde9c844a37 ("drivers: omit symbol map when unneeded") > Cc: stable@dpdk.org > > Reported-by: Luca Boccassi > Signed-off-by: David Marchand Not tested on Windows, but for Linux: Tested-by: Ferruh Yigit