Re: [PATCH 1/3] net/nfp: add the elf module

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 3/4/2024 1:13 AM, Chaoyong He wrote:
>> On 2/28/2024 10:18 PM, Stephen Hemminger wrote:
>>> On Tue, 27 Feb 2024 19:15:49 +0800
>>> Chaoyong He <chaoyong.he@corigine.com> wrote:
>>>
>>>> From: Peng Zhang <peng.zhang@corigine.com>
>>>>
>>>> Add the elf module, which can get mip information from the firmware
>>>> ELF file.
>>>>
>>>> Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
>>>> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
>>>> Reviewed-by: Long Wu <long.wu@corigine.com>
>>>> ---
>>>
>>> Why are you rolling your own ELF parser?
>>> There are libraries to do this such as libelf.
>>> Libelf is already used in the BPF part of DPDK.
>>>
>>
>> There cons and pros to depend external library, as this is in the limited scope of
>> the driver I am less concerned about local code.
>>
>> Chaoyong, what is your take on the issue, did you consider using libelf library
>> option?
> 
> Firstly, the nffw firmware file is a customed ELF file, we are not sure the libelf library can meet our needs totally.
> Then, we share the same logic with our BSP code, and we don't want to have two different logic for the same requirement.
>

Looks reasonable to me, thanks for clarification.