From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E776243B7D; Mon, 4 Mar 2024 09:51:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BD574026B; Mon, 4 Mar 2024 09:51:06 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2047.outbound.protection.outlook.com [40.107.95.47]) by mails.dpdk.org (Postfix) with ESMTP id BA02440041 for ; Mon, 4 Mar 2024 09:51:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C7hHV0kf6qjMptcTNMMsG7Z4omIlbSolsi41j77lpXyzPIHBHjBZ+PJ4ma8Lu7AtvKLG4iffu50MuMN2ywSIdmoqw0CmB09v3EjGx0uk72s8HBdkKB7632j1P8gqLE1sSfrMViac4jUCG0XndRwKE6rluVvHvJOINHIIw4o7+Iibp58dyFGMTX5kd4LZSIO+NcXqeRt1MU09C2GSAsFQF+mib+A57/On4trS8bDZZj2/NDVaN/7qiFKxU1ZyxNI/NkznTa7JboNs05wiNqngujxnUvBbgfD9et2ibC1y+kl/xcOQXUQO5xkmohvcx9YcuIlVWaVvlfLXLb5G1CEIoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XO8xtTmwOqGU8Z7WyQkviP5CI/SR7hUE8OnooFMDHyY=; b=X1NfQO8eeg9n39zTGO4qdOMI2LQHUfrHFO0MN6BGMnbJS3O1tdKtCbTGRqm55K+4DfnnvPPh0GEFMtHjYHjyTQMjOcvtTRYRqtbKxVRuGZ3q5xwoAYR4rGEF1G8pBpObUEwN//V64mTSjfId2b2hAyUcG9GduTlluNA0Wmz8yLuaIxIhWgNoJOjZHCVQDTpyGUv6cgUqz8S80eSIqW+7I8x9rpQn4Sd9c/Xj50UC/gHWh2KRv5ZYSYS4ZqJtF+lYL4yNRcTHyJRIOhx9GgFcxzknG5iKJ5YIQYJnuqSJhaInSppNZWboOI77pbuE4xVp6seVEIa3yjxJsr+owDBwzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XO8xtTmwOqGU8Z7WyQkviP5CI/SR7hUE8OnooFMDHyY=; b=eF34d/SpXN68HmsRSxRj0GgFm/CwtVvAgpUxc0fI/RToSbBLI20881vpU89YjigtqD/qWg3J0ubttSGTLcOkFS5bmYY145KW9E9x34+3LEl1kPe/pbjJoV2IpKlVXncALonWar0Rki+rbblshm8vX8CAPMq7EcEJSJLYUJEz3f8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by MW6PR12MB8706.namprd12.prod.outlook.com (2603:10b6:303:249::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38; Mon, 4 Mar 2024 08:51:02 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::716d:e3ce:141a:f22d]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::716d:e3ce:141a:f22d%7]) with mapi id 15.20.7339.035; Mon, 4 Mar 2024 08:51:02 +0000 Message-ID: Date: Mon, 4 Mar 2024 08:50:43 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] net/nfp: add the elf module To: Chaoyong He , Stephen Hemminger Cc: "dev@dpdk.org" , oss-drivers , Nole Zhang , Long Wu References: <20240227111551.3773862-1-chaoyong.he@corigine.com> <20240227111551.3773862-2-chaoyong.he@corigine.com> <20240228141851.4122231f@hermes.local> <6c833fe5-0a9f-4612-af3a-d505834737c8@amd.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0182.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|MW6PR12MB8706:EE_ X-MS-Office365-Filtering-Correlation-Id: a4ad37e5-4009-4f15-1f3a-08dc3c283108 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bAw20HWHQWlqSW2B8xW7wtvgFSSUxWPW7cbMeA1lr/xB0LHRDtI1nILb8XXFHcFUyPOT+lB96jsKdnFYzICbLee6gYYrG07qF02RMIaz+LhO6TyW7ZXa3L7sCQxZyORVxAwoavqWiLp8xKK31PSOKGterfYEqvQ0KSgU8el0u0nfL+lMDoGEhe+rzlnlTV/7XOPEcxdI/BeZIITy/vlcqKmoySFbkAZyFhlv54Iow4HXlZz7JufG75v+5EpFdoRwIOghSyADE+ssp8fc1Y8LRhR8WOoUhDUw5zztqv8QmZzUNd600gJaw6UcOpwQeuqaCKrIFVqbZZqiYI/+TepkEtR5XORycSjVyNYHfa+FdXGyfe9bKhO6FB1hRxkTZlJmKrFUZavRC5IAe+fmA69EQCMKddZEiqmhjGkeumNxgxwq6wITCcPe9EIWAPO0IuYbptv3jZGPa9FEczlyFBQ6bmh2h49XQ/4Xk6SB0eSCHXiTNMAtNzxov8szwhiUj3e6iYU6SE6ypElfFuw4MgP4qvqK061rrOTJ9VNyPbo0+NskaueurfZzfsdYacA0dKgLXibfIMtKWIqzuEWHCJ9LyAPJBEncFzOw3gDnu0tHkjuDxAazDXu/ImuaPxDk5WoMW9mZ8a/OB2l+eP8gzctR84LqnzgqOA60j1OrwExoYIs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VS9Id0ErYjlXbXlQMm1jY2NVa3d2SVBHeHdtZnlGWlA1WE5OcVRjY2VmaGVC?= =?utf-8?B?QjY5SFdBR1JmU1pjamtkMkdpMU9IYjNaTXJhZEhydWV1R28wcm91WmNRemlU?= =?utf-8?B?SGRtamx4TW5LQ3o1ZFVVNkk3enp0Z2J6c1dUcDJUSlV5L00zRWR2TEpldFVZ?= =?utf-8?B?OXF5eG85c2l6NWNvR3Jpb3pvcGVDSFVSNHdmYWs3d2J5QWd3RlFVN0VOQk1U?= =?utf-8?B?amRqVTFISTZEZEljeDFVbi83RVFsenJCUkRxdFo3N2xYQWdMRlNROXJzVEla?= =?utf-8?B?OVdrdUM0U2Q4cjAyZVpoODlteEVzU3RaME55TGp6bHNBUmoySjNRY1UybWor?= =?utf-8?B?bjcrNUtqbkoyM2tjTmpYRmhGWVVMNy9CZWNwVitiVmZiUHprYVBOd1R5NU1I?= =?utf-8?B?U2liRkl0d0Z6NUNFVzRaSUFUdW5SdGptbFd0ZHA1ckZ4REVwQnJxQ3BQVlZs?= =?utf-8?B?MzNDTlFrSXRwSWNJUCtPNVc3VGhRd2tzM2g2THF0elJiSEg4Ty8wSmQwNUFj?= =?utf-8?B?d1RDSlcrTjZoUnZIWW9Edyt2RVhaZkdpM0JaY244UldTNmlhZzBqYmxqalpQ?= =?utf-8?B?UHZhVno4cndIcEozRjJ6RTkzREdmZThicExaRmdmcmFRdmp0aFo5S2toR2Jx?= =?utf-8?B?dFRQWW5CMi9MSHAzUDl2NjVYQXVBbU5PdGV3NFArKzJlamZCbWd5WEdLOE5r?= =?utf-8?B?VWxBSVd3WWtxbmh4c0J0Y0ZzYmJ6alNEVGhWR0kvWW5jcGhPMnl2ZFhHN2s0?= =?utf-8?B?OGZTTGN3NVdJYXZkcXdiVXAraDhONWxCWEhUbDQzYkFUSDNPU0Z2TWNLZTNQ?= =?utf-8?B?bzdySW4vbUFKOU9kYndMNzhOb1EvVFczODdUZnZnN1hmZG1mUTExQUJHZ0lW?= =?utf-8?B?dUNNeHhtMkdHR1g2QWxkMWpiaEo3WE9KR00wdFFNbVhXYXpFNWZXODk0MzhD?= =?utf-8?B?L2V4S3NxMU5FbDVOaEJaVDJFbTlXZ2JtN1Ewby9QZnlZd2NtYzdnT1RiOXJO?= =?utf-8?B?Wm5iQnZGYVNmdGREeGZnYm00S1F2YW91d2xjeGxKY29LWUhOQk51WXBrYWZ3?= =?utf-8?B?NUVCakJUdHpvYUphYlNEM1NCaDk0ZlhwN2wyZDY5SDliUTlockdzL2ZLa2pn?= =?utf-8?B?dE05S2pRRHBWcXZoMVZ2ZHRDeUdOWStkdW5xNlJlc1BXdzNBdENCeUdHeWNW?= =?utf-8?B?RUJaVmRFS2EySDF6LzBXcGpHV24yR1M0NDVrcjRuamxvYXNjd1M1Q0RrZmVt?= =?utf-8?B?WTRaTENQS2tJL3FIeDFta2cvRGlzN3FaYjhxOVFJN2JnWnd6UXZmMmRuSHZt?= =?utf-8?B?bzNUbXVRa0ZQZWYrUU8zeS9wY2E1alRtZVdiWDdRVTYyc0NSWjNOQzJuTlg0?= =?utf-8?B?L0Zndk41T3VTanZtaFVLNCtZeFJHSE1XRmFRUHBBaU1PWTB0S2N5ZHNrS1Fi?= =?utf-8?B?emRUaDlCTWFzRUlUZWdZTFNMcEtUZmJ1N09LR3NqdmV0b0Y5U2sveTd6RzhW?= =?utf-8?B?UldvYzdFVVdERC81SnAzeFgvZUZTSVBWNy9YcU5GOStTTHhFWWRkZTNPbG9S?= =?utf-8?B?Z3Z3aFpnVlh5NmxPenJlaS8xaEo0UTZVYVlJU3NUTzZsQzJsNmRXZ1FFTXhO?= =?utf-8?B?T21hZm1yRE83NUkwb3dKOVJ2ZVpKcmY5Um5oc3FlM2w3b2dycEZrOWlvMDlY?= =?utf-8?B?K2YvdWxqNjVldHNFNXNpcG03SElPYk94R2FvT1V0WTJ6bVN1SFMrbkdCL0Nh?= =?utf-8?B?cjRpbk55U2xLekxDZHljMkQwTmdaRklEWEo4RUpkOVdtTkpMVHRXUGFwVWJn?= =?utf-8?B?Mjh1U3ZDcjc3eCtOWWU1dFRJMXFIeHdXK1BVYVlCVnBzT093UVY3MCtGaTN5?= =?utf-8?B?LzBqOHVCcWlwd2Y1M2VtWThTdU5qcC9MN2doMGZTaDJnLzJzeGlabUw0a25G?= =?utf-8?B?M3Z2bUNpQUVka3pOWmhOQ0hnempEYXA2NW9uNlBvUEtvUUFzNnpWSFA4Tk9O?= =?utf-8?B?cGoweksxY2gzdnpsRkUrUk91QmxZMmhBcnp0aGNQTFZ1Tk9lZGJ6bGtkRXdu?= =?utf-8?B?UmgvajR3NzR4M3FKMytsS2xTUHpSR08zTWwvcUVEZzNLR3U4MzZxVUp2V21G?= =?utf-8?Q?hDFBkLzu2bkdLDTyrk3c6vqiX?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4ad37e5-4009-4f15-1f3a-08dc3c283108 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 08:51:02.2849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vt6CYHs4Ici86YxodQHWdbpNXEp4DKEVW/rN8i2pX3zfHI85czrhLD+1CQEbwcmx X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8706 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/4/2024 1:13 AM, Chaoyong He wrote: >> On 2/28/2024 10:18 PM, Stephen Hemminger wrote: >>> On Tue, 27 Feb 2024 19:15:49 +0800 >>> Chaoyong He wrote: >>> >>>> From: Peng Zhang >>>> >>>> Add the elf module, which can get mip information from the firmware >>>> ELF file. >>>> >>>> Signed-off-by: Peng Zhang >>>> Reviewed-by: Chaoyong He >>>> Reviewed-by: Long Wu >>>> --- >>> >>> Why are you rolling your own ELF parser? >>> There are libraries to do this such as libelf. >>> Libelf is already used in the BPF part of DPDK. >>> >> >> There cons and pros to depend external library, as this is in the limited scope of >> the driver I am less concerned about local code. >> >> Chaoyong, what is your take on the issue, did you consider using libelf library >> option? > > Firstly, the nffw firmware file is a customed ELF file, we are not sure the libelf library can meet our needs totally. > Then, we share the same logic with our BSP code, and we don't want to have two different logic for the same requirement. > Looks reasonable to me, thanks for clarification.