From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA84CA052A; Fri, 10 Jul 2020 20:51:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 10B451DE49; Fri, 10 Jul 2020 20:51:59 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 146161DE44 for ; Fri, 10 Jul 2020 20:51:58 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200710185157euoutp0173010ea84d1c6ddf7b8063c2b4f513a6~geNNlBY4P2578625786euoutp016; Fri, 10 Jul 2020 18:51:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200710185157euoutp0173010ea84d1c6ddf7b8063c2b4f513a6~geNNlBY4P2578625786euoutp016 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594407117; bh=Nre1R5ePaFR1ByQHx8aBIRoTg9pFa1Rh42wH6+sOXs8=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=Gd67Uxq3UBMo0AXz667mlDhe/aRKQAFEFacpVJ7/nDjzqAl447k3CsJ2AsNTBEGkC srJeR8F5uNz4zRq8mN+Vira7z0Rmw5zeuV5hSC0T6CN25RWBnhAS45QrUVxii4ebAk nK/6OJymQuK4/Wpz0lKPjrnMxKFUBu3IOxX5Q0G8= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200710185157eucas1p145edd754197300a99caedd8c6a24f1cf~geNNUN8DY1255212552eucas1p1V; Fri, 10 Jul 2020 18:51:57 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id C5.DC.06456.CC8B80F5; Fri, 10 Jul 2020 19:51:57 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200710185156eucas1p2180472250d616519a8e116025bf64b3b~geNMlUxu12766427664eucas1p22; Fri, 10 Jul 2020 18:51:56 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200710185156eusmtrp1f94042e9359eb0f8fbca277f432fc229~geNMj2yl12455124551eusmtrp1V; Fri, 10 Jul 2020 18:51:56 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-ae-5f08b8cc96d3 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 96.EF.06017.CC8B80F5; Fri, 10 Jul 2020 19:51:56 +0100 (BST) Received: from [106.109.129.29] (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200710185154eusmtip10be495c158a491b261705e1bf10bd9f6~geNKscE460900809008eusmtip1G; Fri, 10 Jul 2020 18:51:54 +0000 (GMT) To: Stephen Hemminger , "Yigit, Ferruh" Cc: "dev@dpdk.org" , "v.kuramshin@samsung.com" , "thomas@monjalon.net" , "david.marchand@redhat.com" , "arybchenko@solarflare.com" , "Zhao1, Wei" , "Guo, Jia" , "Xing, Beilei" , "Yang, Qiming" , "Lu, Wenzhuo" , "mb@smartsharesystems.com" , "Chautru, Nicolas" , "Richardson, Bruce" , "Ananyev, Konstantin" , "Dumitrescu, Cristian" , "Nicolau, Radu" , "akhil.goyal@nxp.com" , "Doherty, Declan" , "skori@marvell.com" , "pbhagavatula@marvell.com" , "jerinj@marvell.com" , "kirankumark@marvell.com" , "Hunt, David" , "Burakov, Anatoly" , "Li, Xiaoyun" , "Wu, Jingjing" , "Mcnamara, John" , "Singh, Jasvinder" , "Marohn, Byron" , "Wang, Yipeng1" From: Ivan Dyukov Message-ID: Date: Fri, 10 Jul 2020 21:51:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200710082216.19edf2c4@hermes.lan> Content-Transfer-Encoding: 8bit Content-Language: ru-RU X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUxTZxiG855zes6hWvdaNDxDtpkuRvwARPfjyWZ0M4aczP1wf8wyFTzq CaJQTSs6Z5YR3BpWoTAwfsDSdKBBGQlRiq1VVGqgYIVG4gfiV1HUAFOwCIIKjvZgxr/rvZ/7 yf3cySuy+no+Vsww7lZMRjnTwGu5s02jgYRWt5i25HwZgzXX7AQfPahgMXjoPo8HB35jsKNq JV5w/aXB4oc5DNqKXzLoOmnl8d9gLocvQi4G79X7BQx5nwlYECgj+OxdL4vHHIMEA/Y6DY42 eHjsf1fOoe3NTYKFzmaCvvyXHB465yZosVIcOFUpYMW9TzEUbObQf6dWwOqh6yzWXRsj+Kev hmCr5b3m67nSG8cJjVRxoYeRSv6+zkpNdw4LUn6LnZFOv3AzUv/Fm7xkc1YR6eqjg6z0T/cI v1b7o3b5ViUzY49iSlqxSbvNVtSn2VXN/2SpG2JySI7GSqJEoF9Ab6CZC7OeniTQOfyxlWgn +BWBkT8cjDoYJDDc8OuHhdHz9znVVEkgv/G4Rn30Ewj2+NmwK5qugVBBS2R7Fk0Fz8VLQtjE 0tdauHLjViSPp/Hgz7NHTDq6Aiz1lRGdo/Mg90SXEObZ9Ad4X/yYUz0zoeVYd4SjaDIUjR4l YWbpZ3CgroxVOQYGXA18OAzoiAiNrru8evdqCBTlCipHQ6/POclx4C/J51TeD6/P3BbU5TwC D8p/nzStBGdf2wSLEwkLoMaTpMrfQKWlPiIDnQEdz2eqN8yA4rNHWFXWQZ5Fr7oNcLmlfVIG GHs7vYgYSqcUK51SpnRKmdL/Yx2EqyIxSrY5K10xJxuVvYlmOcucbUxP3LIz6wyZ+NT+cV/I TYbaN3sJFYlhus4hi2l6jbzHvC/LS0BkDbN0q1r9qXrdVnnfz4ppZ5opO1Mxe8kckTPE6JaV 92zU03R5t7JDUXYppg9TRoyKzSHRpNuoK7wV7Dyy/lLZ8N3OgqMLFhemTsvzfBkd457PpZ7a 7Bt/uGp2nzXzuy67u+LJ4XWr40xrEnoHk56GDni9vsvzPzLK1dnUJb8S58T98n2TsDg2Ye6G r9bfaG73Znxr+3xaysKBpbHbG9viNyU1OsY9xqZabF3qHOuojf9kUVeKgTNvk5MXsiaz/B/W U3W50AMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRiA+c5tR3P1NZU+LLJG0QWabTp9DTMLigPRjfohXbSDHlzkXOxM S3+JlsU0NYuoGWs1hmmFlJqzMtgIdc6KQUaGloUUdvGWQV666Czw3wPv87zwwsvTqgAbxR/L sUjmHDFbzYUy/t/tfRu63Hz6xtIiDPVddgQf3jpp6L/Ux0HpyGkKXtdtgcfN11ioeldIQXnV KAXNt6wcfO0vYmBorJmC3la/Asa8nxRw/kU1gk/Tn2m46viO4IW9iYUJz0MOhqdvMlA+2Y2g orEDQXvZKAOXWtwISqwYRmprFODsXQ5j/R0M+HsaFHDnR4CGpq5fCC601yN4VvKHTVkhTDpc rOB8PEgJF28EaKGt57JCKPPZKeHekJsShp90c0J5Yx0SOj+U0sLtgZ/c3tCDmiSzKdcirTCY ZMtm9SEt6DTaRNDo4hI12tiEI5t0enVMclKmlH0sTzLHJB/VGMorv7An7nCnSpp+UIWokLWi EJ7gODLxqI+xolBehV2IOL+10FbEzwwI+TJAzznhZPqVlZtzviHiD7RQs4NwvJOMnfcFOQKn kak3dcFFNC5eQFzdH4O1Cnsocn0kKHF4LfGfswdZiZNJSWsNM8sMXk2KXO8VsxyJU8l3z1Nu zllMfFcHgk4I1pLKiStolmkcT+wN7+k5jibFTdX/eAkZafZwlUhlm5fb5iW2eYltXuJATB2K kHJlY5ZR1mlk0Sjn5mRpMkzG+2jmnR60TTS6kXVovxdhHqnDlA6RT1exYp6cb/QiwtPqCOW2 Z/40lTJTzC+QzKZ0c262JHuRfua4C3RUZIZp5jlzLOlavTYBErUJsQmx8aBeojyHPYdVOEu0 SMcl6YRk/t9RfEhUIYobrU906Pt2RmeK460NFcXusF3Lz+6rPXnlnW+r3nX52kqyufFknvPi upBdySurNVUFg4PhmYZ6Yc/GpWd6bMNTqzoMA/d6lcLCybANd/MXRCctYgNob8qU7rqX2LZT 8RWdxujVBSk7fGtSx5fWlo3fjXpp6liW5I3c/fzPrdoDgpqRDaJ2PW2Wxb+bwnwbZAMAAA== X-CMS-MailID: 20200710185156eucas1p2180472250d616519a8e116025bf64b3b X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200710070242eucas1p2d638073836aab0f37966a801996ee08b X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200710070242eucas1p2d638073836aab0f37966a801996ee08b References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> <20200710070226.6045-3-i.dyukov@samsung.com> <20200710082216.19edf2c4@hermes.lan> Subject: Re: [dpdk-dev] [PATCH v7 02/25] ethdev: add a link status text representation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10.07.2020 18:22, Stephen Hemminger пишет: > On Fri, 10 Jul 2020 13:06:02 +0000 > "Yigit, Ferruh" wrote: > >>> + /* ignore unknown specifier */ >>> + default: >>> + *str_cur = '%'; >>> + offset++; >>> + fmt_cur--; >>> + break; >> What do you think ignoring the unknown specifiers and keep continue >> processing the string, instead of break? Just keep unknown specifier >> as it is in the output string. > My comment was that the function should behave the same as > snprintf() does when handed unknown specifier. What snprintf > does is duplicate the string in the output buffer (like any > other non format character). Looks like I need to rewrite comment "ignore unkown specifier". It's not what code do. This function work like snprintf.