Re: [PATCH v2 5/5] dts: add testpmd set ports queues

[Luca Vizzarro <Luca.Vizzarro@arm.com>]

On 23/08/2024 13:22, Juraj Linkeš wrote:
> 
> 
> On 6. 8. 2024 14:46, Luca Vizzarro wrote:
>> Add a facility to update the number of TX/RX queues during the runtime
>> of testpmd.
>>
>> Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
>> Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>
>> ---
>>   dts/framework/remote_session/testpmd_shell.py | 16 ++++++++++++++++
>>   1 file changed, 16 insertions(+)
>>
>> diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/ 
>> framework/remote_session/testpmd_shell.py
>> index ca24b28070..85fbc42696 100644
>> --- a/dts/framework/remote_session/testpmd_shell.py
>> +++ b/dts/framework/remote_session/testpmd_shell.py
>> @@ -805,6 +805,22 @@ def start_all_ports(self, verify: bool = True) -> 
>> None:
>>           self.ports_started = True
>> +    @requires_stopped_ports
>> +    def set_ports_queues(self, number_of: int) -> None:
>> +        """Sets the number of queues per port.
>> +
>> +        Args:
>> +            number_of: The number of RX/TX queues to create per port.
>> +
>> +        Raises:
>> +            InternalError: If `number_of` is invalid.
>> +        """
>> +        if number_of < 1:
>> +            raise InternalError("The number of queues must be 
>> positive and non-zero")
> 
> I don't think we have talked about the message formatting policy, so 
> here's a suggestion: Let's end all exception messages with a dot. This 
> could probably extend to log messages as well. Thomas mentioned in the 
> past that it reads better and I concur - it is an actual sentence.

I gathered the same too, so this was an unvoluntary miss.

> Also, this being an InternalError, do you think the invalid input could 
> only happen because of something going wrong in DTS? This seems 
> reasonable from the possible usecases.

Yes, this is just input sanity check. The only case this would fail is 
if the callee of this function supplied the wrong value, and that would 
be a bug in DTS.