From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 51D602B96 for ; Wed, 7 Dec 2016 16:18:56 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 07 Dec 2016 07:18:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="909719301" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga003.jf.intel.com with ESMTP; 07 Dec 2016 07:18:54 -0800 To: Wenzhuo Lu , dev@dpdk.org References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-30-git-send-email-wenzhuo.lu@intel.com> Cc: "Chen Jing D(Mark)" From: Ferruh Yigit Message-ID: Date: Wed, 7 Dec 2016 15:18:53 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481081535-37448-30-git-send-email-wenzhuo.lu@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 29/32] net/i40e: parse more VF parameter and configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 15:18:57 -0000 On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > When VF requested to configure TX queue, a few parameters are > missed to be configured in PF host. This change have more > fields parsed and configured for TX context. What is the effect of missing Tx paramters configured? If this cause a bug, this patch should be a fix. > > Signed-off-by: Chen Jing D(Mark) > --- > drivers/net/i40e/i40e_pf.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c > index 8319c2c..1ad5ed1 100644 > --- a/drivers/net/i40e/i40e_pf.c > +++ b/drivers/net/i40e/i40e_pf.c > @@ -422,10 +422,12 @@ > > /* clear the context structure first */ > memset(&tx_ctx, 0, sizeof(tx_ctx)); > - tx_ctx.new_context = 1; > tx_ctx.base = txq->dma_ring_addr / I40E_QUEUE_BASE_ADDR_UNIT; > tx_ctx.qlen = txq->ring_len; > tx_ctx.rdylist = rte_le_to_cpu_16(vf->vsi->info.qs_handle[0]); > + tx_ctx.head_wb_ena = txq->headwb_enabled; > + tx_ctx.head_wb_addr = txq->dma_headwb_addr; > + > err = i40e_clear_lan_tx_queue_context(hw, abs_queue_id); > if (err != I40E_SUCCESS) > return err; >