From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 87D725938
 for <dev@dpdk.org>; Thu,  8 Sep 2016 20:11:41 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga101.jf.intel.com with ESMTP; 08 Sep 2016 11:11:36 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,301,1470726000"; 
   d="scan'208";a="6137453"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.92])
 ([10.237.220.92])
 by fmsmga006.fm.intel.com with ESMTP; 08 Sep 2016 11:11:31 -0700
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
 Bruce Richardson <bruce.richardson@intel.com>
References: <1473157994-25101-1-git-send-email-ferruh.yigit@intel.com>
 <2985356.Pbo0hBOtBI@xps13> <20160908092545.GA37096@bricha3-MOBL3>
 <1794333.caoKPGO1RT@xps13>
Cc: dev@dpdk.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <f204ba35-b5e7-4fb5-d51d-5d286dd041db@intel.com>
Date: Thu, 8 Sep 2016 19:11:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1794333.caoKPGO1RT@xps13>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] net/kni: add KNI PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Sep 2016 18:11:41 -0000

On 9/8/2016 10:38 AM, Thomas Monjalon wrote:
> 2016-09-08 10:25, Bruce Richardson:
>> On Thu, Sep 08, 2016 at 09:44:55AM +0200, Thomas Monjalon wrote:
>>> 2016-09-06 11:33, Ferruh Yigit:
>>>> Add KNI PMD which wraps librte_kni for ease of use.
>>>>
>>>> KNI PMD can be used as any regular PMD to send / receive packets to the
>>>> Linux networking stack.
>>>
>>> Good move!
>>> Why not deprecate librte_kni and move all the code in the PMD later?
>>
>> +1 to this plan. However, I don't think it all needs to be done in one patchset,
>> though, does it?
> 
> I think the deprecation notice must be in this patchset along with some
> __rte_deprecated in front of librte_kni functions.
> Then the move of the library in the PMD could be done in the next release.
> 

Not sure about deprecating librte_kni, this means existing KNI
applications needs to be updated. What is the benefit of this effort?

Also librte_kni supports more than what PMD does, like PMD doesn't have
ethtool support or binding kernel threads, it uses hardcoded mbuf_size...

I was thinking PMD as a data only, simplified use case of library.

Regards,
ferruh